Hi,
Patch v2 looks good to me, I have tested it, and pg_basebackup works fine
across the platforms (Windows to Linux and Linux to Windows).
Syntax used for testing
$ pg_basebackup -h remote_server_ip -p 5432 -U user_name -D backup/data -T
olddir=newdir
I have also tested with non-absolute paths,
Thanks, Nathan, for the review comments. Please find the updated patch.
On Sun, Mar 13, 2022 at 3:43 AM Nathan Bossart
wrote:
> Do you think it is worth making this configurable? I don't think it is
> outside the realm of possibility for some users to care more about disk
> space than read
Thanks Dilip, I have fixed your comments, please find the updated patch.
On Tue, Mar 8, 2022 at 9:44 PM Dilip Kumar wrote:.
> +/* incompressible, ignore on subsequent compression passes. */
> +orig_attr->tai_colflags |= TOASTCOL_INCOMPRESSIBLE;
>
> Do we need to set
Hi,
For Toast storage [1] in PostgreSQL, first, the attribute value is
compressed
and then divided into chunks. The problem with storing compressed value is,
if we
are not saving enough space such that it reduces the #chunks then we end up
adding extra decompression cost on every read.
Based on
On Wed, May 6, 2020 at 10:11 AM Amit Kapila wrote:
>
> > I think that the definition of get_iso_localename() should be consistent
> across all versions, that is HEAD like back-patched.
> >
>
> Fair enough. I have changed such that get_iso_localename is the same
> in HEAD as it is backbranch
On Tue, Apr 28, 2020 at 11:45 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
>
> On Tue, Apr 28, 2020 at 5:16 PM davinder singh <
> davindersingh2...@gmail.com> wrote:
>
>> I have tested with different locales with codepages including above.
On Wed, Apr 29, 2020 at 8:24 AM Amit Kapila wrote:
> BTW, do you see any different results for pt_PT with create_locale
> version or the new patch version being discussed here?
>
No, there is no difference for pt_PT. The difference you are noticing is
because of the previous locale setting.
--
On Mon, Apr 27, 2020 at 4:50 PM Amit Kapila wrote:
> Bemba_Zambia
> Bena_Tanzania
> Bulgarian_Bulgaria
> Swedish_Sweden.1252
> Swedish_Sweden
>
I have tested with different locales with codepages including above. There
are few which return different locale code but the error messages in both
On Thu, Apr 23, 2020 at 6:49 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
>
> On Thu, Apr 23, 2020 at 3:00 PM Amit Kapila
> wrote:
>
>>
>> Thanks, I will verify these. BTW, have you done something special to
>> get the error messages which are not in English because on
On Mon, Apr 20, 2020 at 10:10 AM Amit Kapila
wrote:
> Yes, I am planning to look into it. Actually, I think the main thing
> here is to ensure that we don't break something which was working with
> _create_locale API.
I am trying to understand how lc_messages affect the error messages on
name is valid by using _create_locale. I hope that answers your
question.
I have attached the patch.
--
Regards,
Davinder
EnterpriseDB: http://www.enterprisedb.com
On Tue, Apr 14, 2020 at 1:07 PM davinder singh
wrote:
>
> On Fri, Apr 10, 2020 at 5:33 PM Amit Kapila
> wrote:
> &
On Fri, Apr 10, 2020 at 5:33 PM Amit Kapila wrote:
>
> It seems the right direction to use GetLocaleInfoEx as we have already
> used it to handle a similar problem (lc_codepage is missing in
> _locale_t in higher versions of MSVC (cf commit 0fb54de9aa)) in
> chklocale.c. However, I see that we
On Wed, Apr 8, 2020 at 7:39 PM Juan José Santamaría Flecha
> Let me explain further, in pg_config_os.h you can check that the value of
> _WIN32_WINNT is solely based on checking _MSC_VER. This patch should also
> be meaningful for WIN32 builds using MinGW, or we might see this issue
> reappear in
On Tue, Apr 7, 2020 at 8:30 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
>
> * The logic on "defined(_MSC_VER) && (_MSC_VER >= 1900)" is defined as
> "_WIN32_WINNT >= 0x0600" on other parts of the code. I would
> recommend using the later.
>
I think "_WIN32_WINNT >=
On Mon, Apr 6, 2020 at 8:17 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
>
> How do you reproduce this issue with Visual Studio? I see there is an
> ifdef directive above IsoLocaleName():
>
> #if defined(WIN32) && defined(LC_MESSAGES)
>
> I would expect
Hi All,
I am working on “pg_locale compilation error with Visual Studio 2017”,
Related threads[1],[2].
We are getting compilation error in static char *IsoLocaleName(const char
*winlocname) function in pg_locale.c file. This function is trying to
convert the locale name into the Unix style. For
16 matches
Mail list logo
