Re: Useless field ispartitioned in CreateStmtContext

2024-11-05 Thread hugo
Hi, Kirill Sorry for the late reply, thanks for your suggestion. A simple fix has been added to the attached patch. -- hugo v1-0001-Remove-useless-field-ispartitioned-in-CreateStmtC.patch Description: Binary data

Useless field ispartitioned in CreateStmtContext

2024-10-24 Thread hugo
Hi!    When looking at the partition-related code, I found that the ispartitioned field in CreateStmtContext is not used. It looks like we can safely remove it and avoid invalid assignment logic. Here's a very simple fix, any suggestion? diff --git a/src/backend/parser/parse_utilc

Useless parameter 'cur_skey' in IndexScanOK

2024-07-02 Thread Hugo Zhang
Hi, The 'cur_skey' parameter in `IndexScanOK` funciton doesn't seem to be useful. The function does not use cur_skey for any operation. Is there any other consideration for retaining the cur_skey parameter here? Best wishes Hugo zhang

Unexpected abort at llvm::report_bad_alloc_error when load JIT library

2023-02-22 Thread Hugo Zhang
stack that loaded there lib and want to init some options with memory allocation. I didn’t figure out a better way to set an error_handler for this situation when load libLLVM.so. - Hugo.