Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025/05/21 12:54 Fujii Masao :On Mon, May 19, 2025 at 5:18 PM Masahiro Ikeda wrote: > > Thanks for your work and feedback! > > I've updated the patches and added regular regression tests for > both pg_prewarm and amcheck. Thanks for updating the patches! Regarding the 0001 patch: +CR

Fix comments of heap_prune_chain()

Hi,While I’m reading source codes related to vacuum, I found comments whichdon’t seem to fit the reality. I think the commit[1] just forgot to fix them.What do you think?[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=dc7420c2c9274a283779ec19718d2d16323640c0 Regards,-- Masahiro I

Re: About to add WAL write/fsync statistics to pg_stat_wal view

On 2021/03/22 16:50, Fujii Masao wrote: > > > On 2021/03/22 9:50, ikedamsh wrote: >> Agreed. I separated the patches. >> >> If only the former is committed, my trivial concern is that there may be >> a disadvantage, but no advantage for the standby serv

Re: About to add WAL write/fsync statistics to pg_stat_wal view

On 2021-03-19 16:30, Fujii Masao wrote: > On 2021/03/15 10:39, Masahiro Ikeda wrote: >> Thanks, I understood get_sync_bit() checks the sync flags and >> the write unit of generated wal data and replicated wal data is >> different. >> (It's interesting optimization whether to use kernel cache or no

It is not documented that pg_promote can exit standby mode

Hi,  The document(high-availability.sgml) says that there are only two ways to exit standby mode. 　26.2.2. Standby Server Operation 　Standby mode is exited and the server switches to normal operation when pg_ctl promote is run or a trigger file is found (promote_trigger_file). But there is