Hi Alvaro san
Thank you for your fix of trace log code.
> From: 'alvhe...@alvh.no-ip.org'
> Sent: Friday, April 2, 2021 11:30 AM
...
> It still didn't fix it! Drongo is now reporting a difference in the expected
> trace --
> and the differences all seem to be message lengths.
> Now that is
Hi Alvaro san, Tsunakawa san
Thank you for creating the v30 patch.
> From: Tsunakawa, Takayuki/綱川 貴之
> Sent: Monday, March 29, 2021 9:45 AM
...
> Iwata-san,
> Please review Alvaro-san's code, and I think you can integrate all patches
> into
> one except for 0002 and 0007. Those two patches
Hi Tsunakawa san,
Thank you for your review. I update patch to v29.
Output is following. It is fine.
```
2021-03-19 07:21:09.917302 > 4 Terminate
2021-03-19 07:21:09.961494 > 155 Query"CREATE TABLESPACE
regress_tblspacewith LOCATION
Hi Horiguchi san and Tsunakawa san,
Thank you for you review.
I update patch to v28. In this patch, I removed array.
And I fixed some code according to Horiguchi san and Tsunakawa san review
comment.
> From: Tsunakawa, Takayuki/綱川 貴之
> Sent: Thursday, March 18, 2021 12:38 PM
> I sort of
Hi Alvaro san and Tsunakawa san,
Thank you for your review. I updated patch to v27.
`make check` output is following. I think it is OK.
```
2021-03-18 07:02:55.090598 < ReadyForQuery 5 I
2021-03-18 07:02:55.090672 > Terminate 4
Hi Tsunakawa san, Alvaro san,
Thank you very much for your review. It helped me a lot to make the patch
better.
I update patch to v26.
This patch has been updated according to Tsunakawa san and Alvaro san review
comments.
The output is following;
```
2021-03-17 14:43:16.411238 > Terminate
Alvaro san, Tom san Horiguchi san, Tsunakawa san and Kirk san,
Thank you very much for review and advice.
> > Works for me.
>
> Pushed that. I think we're now waiting on Iwata-san to finish a new version
> of
> the tracing patch.
Thank you very much Alvaro san and Tom san. Your patch and code
Hi all,
Following all reviewer's advice, I have created a new patch.
In this patch, I add only two tracing entry points; I call
pqTraceOutputMsg(PGconn conn, int msgCursor, PGCommSource commsource) in
pqParseInput3 () and pqPutMsgEnd () to output log.
The argument contains message first byte
Alvaro san,
Thank you very much for your updating and organizing this patch.
It appears that something is still wrong. I applied lipq pipeline v27 from [1]
and ran src/test/modules/test_libpq/pipeline singlerow, after patching it to do
PQtrace() after PQconn(). Below is the output I get
Hi Kirk san,
Thank you for your review. I update patch to v21.
> -Original Message-
> From: Jamison, Kirk/ジャミソン カーク
> Sent: Wednesday, February 24, 2021 1:04 PM
> (1) Doc: PQtraceSetFlags
> + flags contains flag bits describing the operating
> mode
> + of tracing. If flags
Hi Tsunakawa san,
I update patch to v19.
> -Original Message-
> From: Tsunakawa, Takayuki/綱川 貴之
> Sent: Monday, February 22, 2021 1:30 PM
> (52)
> + of tracing. If (flags contains
> PQTRACE_SUPPRESS_TIMESTAMPS),
>
> () can be removed?
Yes, I removed ().
> (53)
> + int
Hi all,
I update patch to v18. It has been fixed in response to Tsunakawa san's review.
> From: Tsunakawa, Takayuki/綱川 貴之
> Sent: Friday, February 12, 2021 1:53 PM
>
> (48)
>
> void PQtrace(PGconn *conn, FILE *stream);
>
>
>
> +
> + Calls PQtraceSetFlags to output with
Hi all,
Thank you for your review. I update patch to v17.
> From: Tsunakawa, Takayuki/綱川 貴之
> Sent: Tuesday, February 9, 2021 11:26 AM
> (45)
...
> The description of PQtrace() should be written independent of PQtraceEx().
> It is an unnecessary implementation detail to the user that PQtrace()
HI all,
I update the patch.
I modified code according to review comments of Tsunakawa san and Horiguchi san.
And I fixed some bugs.
> This patch should address the following:
> 1. fix 3 bugs
> 1.1 -1 output in "Query" message
The cause of this bug is that it call in pqFlush() function before
Hi all,
Thank you Kirk san for creating the v14 patch.
I update the patch. I fixed all of Tsunakawa san's review comments.
I am trying to solve three bugs. Two bags were pointed out by Alvaro san
in a previous e-mail. And I found one bug.
> From: Alvaro Herrera
> Sent: Friday, January 22,
Tsunakawa san,
> Strangely, Iwata-san's latest mail she sent today at 10:34 JST hasn't appeared
> on pgsql-hackers yet after more than 6 hours. It is not reflected in the CF
> entry [1]. So, I'm putting her original mail below. The v13 patch attached
> to
> the original mail is attached to
Hi,
Thank you for your review. I modified the code in response to those reviews.
This patch includes these items:
- Fix the code according to reviews
- Fix COPY output issue
- Change to not support Protocol v2.0
It is rarely used anymore and de-support it makes code more simpler.
Hi Alvaro san,
> There are some things still to do:
I worked on some to do.
> 1. Is the handling of protocol 2 correct?
Protocol 3.0 is implemented in PostgreSQL v7.4 or later. Therefore, most
servers and clients today want to connect using 3.0.
Also, wishful thinking, I think Protocol 2.0
Hi Alvaro san,
Thank you for your email.
I will review this updated patch and I will let you know when I complete.
Please wait a moment.
Best regards,
Aya Iwata
> -Original Message-
> From: Alvaro Herrera
> Sent: Tuesday, October 27, 2020 1:23 AM
> To: Iwata, Aya/岩田 彩
> Cc:
Hi Alvaro san,
Thank you for your update :)
> Opinions? I experimented by patching psql as below (not intended for
> commit) and it looks good. Only ErrorResponse prints the terminator as a
> control character, or something:
I check code, changes and email. I agree with all of this.
I will
Hello,
Thank you for your review.
I update patch. Please find attached my patch.
> > 2019-04-04 02:39:51.488 UTC > Query 59 "SELECT
> pg_catalog.set_config('search_path', '', false)"
>
> The "59" there seems quite odd, though.
Could you explain more detail about this?
"59" is length of
21 matches
Mail list logo
