On Tue, Feb 20, 2024 at 2:13 PM Amit Kapila wrote:
>
> I would prefer the changed ones as those clearly explain the problem
> without additional information.
okay, attached v2 patch with changed error msgs and double quotes
around logical.
thanks
Shveta
On Tue, Feb 20, 2024 at 8:25 AM Masahiko Sawada wrote:
>
>
> I've reviewed the v91 patch. Here are random comments:
Thanks for the comments.
> ---
> /*
> * Checks the remote server info.
> *
> - * We ensure that the 'primary_slot_name' exists on the remote server and the
> - * remote
On Mon, Feb 19, 2024 at 5:32 PM Amit Kapila wrote:
>
> Few comments on 0001
Thanks for the feedback.
>
> 1. I think it is better to error out when the valid GUC or option is
> not set in ensure_valid_slotsync_params() and
> ensure_valid_remote_info() instead of waiting. And
On Mon, Feb 19, 2024 at 11:10 AM Amit Kapila wrote:
>
> On Thu, Feb 15, 2024 at 11:49 AM Kyotaro Horiguchi
> wrote:
> >
> > At Thu, 15 Feb 2024 09:22:23 +0530, shveta malik
> > wrote in
> > >
> > > +1 on changing the msg(s) suggested way. Plea
On Mon, Feb 19, 2024 at 10:31 AM Robert Haas wrote:
>
> On Mon, Feb 19, 2024 at 10:10 AM Kyotaro Horiguchi
> wrote:
> > A recent commit (7a424ece48) added the following message:
> >
> > > could not sync slot information as remote slot precedes local slot:
> > > remote slot "%s": LSN (%X/%X),
On Sun, Feb 18, 2024 at 7:40 PM Zhijie Hou (Fujitsu)
wrote:
>
> On Friday, February 16, 2024 6:41 PM shveta malik
> wrote:
> Thanks for the patch. Here are few comments:
Thanks for the comments.
>
> 2.
>
> +static bool
> +validate_remote_info(WalRecei
On Thu, Feb 15, 2024 at 8:26 AM Amit Kapila wrote:
>
> On Wed, Feb 14, 2024 at 7:51 PM Euler Taveira wrote:
> >
> > On Wed, Feb 14, 2024, at 8:45 AM, Amit Kapila wrote:
> >
> > Now, I am less clear about whether to quote "logical" or not in the
> > above message. Do you have any suggestions?
> >
On Fri, Feb 9, 2024 at 10:04 AM Amit Kapila wrote:
>
> +reserve_wal_for_local_slot(XLogRecPtr restart_lsn)
> {
> ...
> + /*
> + * Find the oldest existing WAL segment file.
> + *
> + * Normally, we can determine it by using the last removed segment
> + * number. However, if no WAL segment files
On Tue, Feb 13, 2024 at 6:45 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Monday, February 12, 2024 5:40 PM Amit Kapila
> wrote:
>
> Thanks for the comments, I have addressed them.
>
> Here is the new version patch which addressed above and
> most of Bertrand's comments.
Thanks for the patch.
I am
On Thu, Feb 8, 2024 at 4:31 PM shveta malik wrote:
>
> On Thu, Feb 8, 2024 at 12:08 PM Peter Smith wrote:
> >
> > Here are some review comments for patch v80_2-0001.
>
> Thanks for the feedback Peter. Addressed the comments in v81.
Missed to mention, Hou-san h
On Thu, Feb 8, 2024 at 4:03 PM Amit Kapila wrote:
>
> Few comments on 0001
> ===
Thanks Amit. Addressed these in v81.
> 1.
> + * the slots on the standby and synchronize them. This is done on every call
> + * to SQL function pg_sync_replication_slots.
> >
>
> I think the second
On Thu, Feb 8, 2024 at 12:08 PM Peter Smith wrote:
>
> Here are some review comments for patch v80_2-0001.
Thanks for the feedback Peter. Addressed the comments in v81.
Attached patch001 for early feedback. Rest of the patches need
rebasing and thus will post those later.
It also addresses
On Tue, Feb 6, 2024 at 12:25 PM Bertrand Drouvot
wrote:
>
> Hi,
> That said, I still think the commit message needs some re-wording, what about?
>
> =
> If a logical slot on the primary is valid but is invalidated on the standby,
> then that slot is dropped and can be recreated on the
On Tue, Feb 6, 2024 at 7:21 PM Zhijie Hou (Fujitsu)
wrote:
>
> > ---
> > +/* Slot sync worker objects */
> > +extern PGDLLIMPORT char *PrimaryConnInfo; extern PGDLLIMPORT char
> > +*PrimarySlotName;
> >
> > These two variables are declared also in xlogrecovery.h. Is it intentional?
> > If so, I
On Mon, Feb 5, 2024 at 4:36 PM Amit Kapila wrote:
>
> I have pushed the first patch. Next, a few comments on 0002 are as follows:
Thanks for the feedback Amit. Some of these are addressed in v78. Rest
will be addressed in the next version.
> 1.
> +static bool
>
On Fri, Feb 2, 2024 at 12:25 PM Peter Smith wrote:
>
> Here are some review comments for v750002.
Thanks for the feedback Peter. Addressed all in v76 except one.
> (this is a WIP but this is what I found so far...)
> I wonder if it is better to log all the problems in one go instead of
>
On Wed, Jan 31, 2024 at 2:02 PM Masahiko Sawada wrote:
>
> ---
> +static char *
> +wait_for_valid_params_and_get_dbname(void)
> +{
> + char *dbname;
> + int rc;
> +
> + /* Sanity check. */
> + Assert(enable_syncslot);
> +
> + for (;;)
> + {
> + if
On Thu, Feb 1, 2024 at 11:21 AM Peter Smith wrote:
>
> Here are some review comments for v740001.
Thanks Peter for the feedback.
> ==
> src/sgml/logicaldecoding.sgml
>
> 1.
> +
> +Replication Slot Synchronization
> +
> + A logical replication slot on the primary can be
On Tue, Jan 30, 2024 at 11:31 AM Amit Kapila wrote:
>
> In this regard, I feel we don't need to dump/restore the 'FAILOVER'
> option non-binary upgrade paths similar to the 'ENABLE' option. For
> binary upgrade, if the failover option is enabled, then we can enable
> it using Alter Subscription
On Thu, Jan 25, 2024 at 10:39 AM Peter Smith wrote:
> 2. synchronize_one_slot
>
> + /*
> + * Sanity check: Make sure that concerned WAL is received and flushed
> + * before syncing slot to target lsn received from the primary server.
> + *
> + * This check should never pass as on the primary
On Thu, Jan 25, 2024 at 9:13 AM Amit Kapila wrote:
>
> > 3) Removed syncing 'failover' on standby from remote_slot. The
> > 'failover' field will be false for synced slots. Since we do not
> > support sync to cascading standbys yet, thus failover=true was
> > misleading and unused there.
> >
>
>
On Wed, Jan 24, 2024 at 2:38 PM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Wed, Jan 24, 2024 at 01:51:54PM +0530, Amit Kapila wrote:
> > On Wed, Jan 24, 2024 at 11:24 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Jan 24, 2024 at 2:43 PM Amit Kapila
> > > wrote:
> > > >
> > > > >
> > > > > +/*
On Tue, Jan 23, 2024 at 9:45 AM Peter Smith wrote:
>
> Here are some review comments for v65-0002
Thanks Peter for the feedback. I have addressed these in v66.
>
> 4. GetStandbyFlushRecPtr
>
> /*
> - * Returns the latest point in WAL that has been safely flushed to disk, and
> - * can be sent
On Fri, Jan 19, 2024 at 11:48 AM Peter Smith wrote:
>
> Here are some review comments for patch v63-0003.
Thanks Peter. I have addressed all in v65.
>
> 4b.
> It was a bit different when there were ERRORs but now they are LOGs
> somehow it seems wrong for this function to say what the *caller*
On Mon, Jan 22, 2024 at 12:28 PM Amit Kapila wrote:
>
> On Fri, Jan 19, 2024 at 3:55 PM shveta malik wrote:
> >
> > On Fri, Jan 19, 2024 at 10:35 AM Masahiko Sawada
> > wrote:
> > >
> > >
> > > Thank you for updating the patch. I have some co
On Thu, Jan 18, 2024 at 4:49 PM Amit Kapila wrote:
> 2.
> +synchronize_one_slot(WalReceiverConn *wrconn, RemoteSlot *remote_slot)
> {
> ...
> + LWLockAcquire(ProcArrayLock, LW_EXCLUSIVE);
> + xmin_horizon = GetOldestSafeDecodingTransactionId(true);
> + SpinLockAcquire(>mutex);
> +
On Fri, Jan 19, 2024 at 10:35 AM Masahiko Sawada wrote:
>
>
> Thank you for updating the patch. I have some comments:
>
> ---
> +latestWalEnd = GetWalRcvLatestWalEnd();
> +if (remote_slot->confirmed_lsn > latestWalEnd)
> +{
> +elog(ERROR, "exiting from slot
On Fri, Jan 19, 2024 at 11:23 AM Amit Kapila wrote:
>
> > > 5 === (coming from v62-0002)
> > > + Assert(tuplestore_tuple_count(res->tuplestore) == 1);
> > >
> > > Is it even possible for the related query to not return only one row? (I
> > > think the
> > > "count" ensures it).
> >
> > I
On Thu, Jan 18, 2024 at 10:31 AM Peter Smith wrote:
>
> I have one question about the new code in v63-0002.
>
> ==
> src/backend/replication/logical/slotsync.c
>
> 1. ReplSlotSyncWorkerMain
>
> + Assert(SlotSyncWorker->pid == InvalidPid);
> +
> + /*
> + * Startup process signaled the slot
On Wed, Jan 17, 2024 at 3:08 PM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Tue, Jan 16, 2024 at 05:27:05PM +0530, shveta malik wrote:
> > PFA v62. Details:
>
> Thanks!
>
> > v62-003:
> > It is a new patch which attempts to implement slot-sync worker as
On Wed, Jan 17, 2024 at 6:43 AM Masahiko Sawada wrote:
>
> On Tue, Jan 16, 2024 at 6:40 PM shveta malik wrote:
> >
> > On Tue, Jan 16, 2024 at 12:59 PM Masahiko Sawada
> > wrote:
> > >
> > > On Tue, Jan 16, 2024 at 1:07 PM Amit Kapila
> > >
On Sat, Jan 13, 2024 at 12:54 PM Amit Kapila wrote:
>
> On Fri, Jan 12, 2024 at 5:50 PM shveta malik wrote:
> >
> > There are multiple approaches discussed and tried when it comes to
> > starting a slot-sync worker. I am summarizing all here:
> >
> > 1)
On Tue, Jan 16, 2024 at 12:59 PM Masahiko Sawada wrote:
>
> On Tue, Jan 16, 2024 at 1:07 PM Amit Kapila wrote:
> >
> > On Tue, Jan 16, 2024 at 9:03 AM shveta malik wrote:
> > >
> > > On Sat, Jan 13, 2024 at 12:54 PM Amit Kapila
> > > wrote:
&g
On Sat, Jan 13, 2024 at 12:54 PM Amit Kapila wrote:
>
> On Fri, Jan 12, 2024 at 5:50 PM shveta malik wrote:
> >
> > There are multiple approaches discussed and tried when it comes to
> > starting a slot-sync worker. I am summarizing all here:
> >
> > 1)
On Fri, Jan 12, 2024 at 5:30 PM Masahiko Sawada wrote:
>
> On Thu, Jan 11, 2024 at 7:53 PM Amit Kapila wrote:
> >
> > On Tue, Jan 9, 2024 at 6:39 PM Amit Kapila wrote:
> > >
> > > +static bool
> > > +synchronize_one_slot(WalReceiverConn *wrconn, RemoteSlot *remote_slot)
> > > {
> > > ...
> > >
On Thu, Jan 11, 2024 at 7:28 AM Peter Smith wrote:
>
> Here are some review comments for patch v58-0002
Thank You for the feedback. These are addressed in v60. Please find my
response inline for a few.
> (FYI - I quickly checked with the latest v59-0002 and AFAIK all these
> review comments
On Thu, Jan 4, 2024 at 7:24 PM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Thu, Jan 04, 2024 at 10:27:31AM +0530, shveta malik wrote:
> > On Thu, Jan 4, 2024 at 9:18 AM shveta malik wrote:
> > >
> > > On Wed, Jan 3, 2024 at 6:33 PM Zhijie Hou (Fujitsu)
>
On Wed, Jan 3, 2024 at 6:33 PM Zhijie Hou (Fujitsu)
wrote:
>
> On Tuesday, January 2, 2024 6:32 PM shveta malik
> wrote:
> > On Fri, Dec 29, 2023 at 10:25 AM Amit Kapila
> >
> > The topup patch has also changed app_name to
> > {cluster_name}_slotsyncworker
On Mon, Jan 1, 2024 at 5:17 PM shveta malik wrote:
>
> On Mon, Jan 1, 2024 at 4:30 PM Amit Kapila wrote:
> >
> > On Mon, Jan 1, 2024 at 12:32 PM shveta malik wrote:
> > >
> > > PFA v3 after changing column name to 'conflict_reason'
> > >
> >
&g
On Mon, Jan 1, 2024 at 4:30 PM Amit Kapila wrote:
>
> On Mon, Jan 1, 2024 at 12:32 PM shveta malik wrote:
> >
> > PFA v3 after changing column name to 'conflict_reason'
> >
>
> Few minor comments:
> ===
> 1.
> +
> + w
On Mon, Jan 1, 2024 at 9:14 AM shveta malik wrote:
>
> On Fri, Dec 29, 2023 at 3:35 PM Michael Paquier wrote:
> >
> > On Fri, Dec 29, 2023 at 09:20:52AM +0530, Amit Kapila wrote:
> > > Does anyone have a preference for a column name? The options on the
>
On Fri, Dec 29, 2023 at 3:35 PM Michael Paquier wrote:
>
> On Fri, Dec 29, 2023 at 09:20:52AM +0530, Amit Kapila wrote:
> > Does anyone have a preference for a column name? The options on the
> > table are conflict_cause, conflicting_cause, conflict_reason. Any
> > others? I was checking docs for
On Thu, Dec 28, 2023 at 10:16 AM shveta malik wrote:
>
> On Wed, Dec 27, 2023 at 4:16 PM Amit Kapila wrote:
> >
> > On Wed, Dec 27, 2023 at 3:08 PM shveta malik wrote:
> > >
> > > PFA the patch which attempts to implement this.
> > >
> > &g
On Wed, Dec 27, 2023 at 4:16 PM Amit Kapila wrote:
>
> On Wed, Dec 27, 2023 at 3:08 PM shveta malik wrote:
> >
> > PFA the patch which attempts to implement this.
> >
> > This patch changes the existing 'conflicting' field to
> > 'conflicting_cause' in pg_
On Wed, Dec 27, 2023 at 11:36 AM Masahiko Sawada wrote:
>
> Hi,
>
> Thank you for working on this.
>
> On Tue, Dec 26, 2023 at 9:27 PM shveta malik wrote:
> >
> > On Tue, Dec 26, 2023 at 4:41 PM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > &g
On Thu, Dec 21, 2023 at 2:59 PM Amit Kapila wrote:
>
> On Thu, Dec 21, 2023 at 12:07 PM Michael Paquier wrote:
> >
> > On Thu, Dec 21, 2023 at 11:53:04AM +0530, Amit Kapila wrote:
> > > On Thu, Dec 21, 2023 at 11:18 AM Michael Paquier
> > > wrote:
> > > Yeah, if one uses them independently
On Tue, Dec 26, 2023 at 7:35 PM Isaac Morland wrote:
>
> On Thu, 21 Dec 2023 at 09:26, Amit Kapila wrote:
>
>>
>> A conflicting column where NULL indicates no conflict, and other
>> > values indicate the reason for the conflict, doesn't seem too bad.
>> >
>>
>> This is fine too.
>
>
> I prefer
On Tue, Dec 26, 2023 at 4:41 PM Zhijie Hou (Fujitsu)
wrote:
>
> On Wednesday, December 20, 2023 7:37 PM Amit Kapila
> wrote:
> >
> > On Wed, Dec 20, 2023 at 3:29 PM shveta malik
> > wrote:
> > >
> > > On Wed, Dec 20, 2023 at 9:12 AM Amit Kapila
&g
On Fri, Dec 22, 2023 at 7:59 PM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Fri, Dec 22, 2023 at 04:02:21PM +0530, shveta malik wrote:
> > PFA v53. Changes are:
>
> Thanks!
>
> > patch002:
> > 2) Addressed comments in [2] for v52-002.
> > 3) Fixed CFBot
On Thu, Dec 21, 2023 at 6:37 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Shveta,
>
> Thanks for updating the patch! Here is my comments for v52-0002.
Thanks for the feedback Kuroda-san. I have addressed these in v53.
> ~
> system-views.sgml
>
> 01.
>
> ```
> +
> +
> +
> +
On Thu, Dec 21, 2023 at 5:04 PM Andres Freund wrote:
>
> Hi,
>
> On 2023-12-21 16:08:48 +0530, shveta malik wrote:
> > On Thu, Dec 21, 2023 at 3:10 PM Andres Freund wrote:
> > >
> > > Hi,
> > >
> > > On 2023-12-21 09:21:04 +0900, Michael Paq
On Thu, Dec 21, 2023 at 3:10 PM Andres Freund wrote:
>
> Hi,
>
> On 2023-12-21 09:21:04 +0900, Michael Paquier wrote:
> > While listening at Bertrand's talk about logical decoding on standbys
> > last week at Prague, I got surprised by the fact that we do not
> > reflect in the catalogs the
On Wed, Dec 20, 2023 at 12:02 PM Peter Smith wrote:
>
> Here are some comments for the patch v50-0002.
Thank You for the feedback. I have addressed these in v52.
> ==
> GENERAL
>
> (I made a short study of all the ereports in this patch -- here are
> some findings)
>
> ~~~
>
> 0.1 Don't
On Wed, Dec 20, 2023 at 9:12 AM Amit Kapila wrote:
>
> On Tue, Dec 19, 2023 at 5:30 PM shveta malik wrote:
> >
> > Thanks for reviewing. I have addressed these in v50.
> >
>
> I was looking at this patch to see if something smaller could be
> independently co
On Wed, Dec 20, 2023 at 12:46 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/20/23 7:01 AM, shveta malik wrote:
> > Hello hackers,
> >
> > Attached is a patch which attempts to implement a new system function
> > pg_get_slot_invalidation_cause('sl
On Wed, Dec 20, 2023 at 2:20 PM Amit Kapila wrote:
>
> On Wed, Dec 20, 2023 at 12:46 PM Drouvot, Bertrand
> wrote:
> >
> > On 12/20/23 7:01 AM, shveta malik wrote:
> > > Hello hackers,
> > >
> > > Attached is a patch w
Hello hackers,
Attached is a patch which attempts to implement a new system function
pg_get_slot_invalidation_cause('slot_name') to get invalidation cause
of a replication slot.
Currently, users do not have a way to know the invalidation cause. One
can only find out if the slot is invalidated
On Tue, Dec 19, 2023 at 6:58 AM Peter Smith wrote:
>
> Here are some comments for the patch v49-0002.
>
Thanks for reviewing. I have addressed these in v50.
> (This is in addition to my review comments for v48-0002 [1])
>
> ==
> src/backend/access/transam/xlogrecovery.c
>
>
> 1.
On Tue, Dec 19, 2023 at 4:51 AM Peter Smith wrote:
>
> Here are some review comments for v48-0002
>
Thanks for reviewing. Most of these are addressed in v50. Please find
my comments for the rest.
> ==
> doc/src/sgml/config.sgml
>
> 1.
> + If slot synchronization is enabled then it
On Mon, Dec 18, 2023 at 4:22 PM Amit Kapila wrote:
>
> On Fri, Dec 15, 2023 at 11:03 AM shveta malik wrote:
> >
> > Sorry, I missed attaching the patch. PFA v48.
> >
>
> Few comments on v48_0002
>
Thanks for reviewing. These are addresse
On Thu, Dec 14, 2023 at 10:15 AM Peter Smith wrote:
>
> A review comment for v47-0001
>
Thanks for reviewing. I have addressed these in v48. There is some
design change around the code part where we were checking cascading
and were revalidating new GUC values on conf-reload. So code has
changed
On Wed, Dec 13, 2023 at 3:53 PM Peter Smith wrote:
>
> Hi Shveta, here are some review comments for v45-0002.
>
Thanks for the feedback. Addressed these in v48. Please find my
comments on some.
> ==
> doc/src/sgml/bgworker.sgml
>
> 1.
> +
> +
> + BgWorkerStart_PostmasterStart
> +
On Thu, Dec 14, 2023 at 4:40 PM Amit Kapila wrote:
>
> On Thu, Dec 14, 2023 at 7:00 AM Peter Smith wrote:
> >
> > Hi, here are a few more review comments for the patch v47-0002
> >
> > (plus my review comments of v45-0002 [1] are yet to be addressed)
> >
> > ==
> > 1. General
> >
> > For
On Wed, Dec 13, 2023 at 10:40 AM Amit Kapila wrote:
>
> On Mon, Dec 11, 2023 at 5:13 PM shveta malik wrote:
> >
> > On Mon, Dec 11, 2023 at 1:22 PM Drouvot, Bertrand
> > wrote:
> > >
> > > > If we agree
> > > > on that then
On Tue, Dec 12, 2023 at 5:56 PM Nisha Moond wrote:
>
> A review on v45 patch:
>
> If one creates a logical slot with failover=true as -
> select pg_create_logical_replication_slot('logical_slot','pgoutput',
> false, true, true);
>
> Then, uses the existing logical slot while creating a
On Mon, Dec 11, 2023 at 7:12 PM Amit Kapila wrote:
>
> On Mon, Dec 11, 2023 at 2:41 PM shveta malik wrote:
> >
> > >
> > > 5.
> > > +synchronize_slots(WalReceiverConn *wrconn)
> > > {
> > > ...
> > > ...
> > > + /* The
On Sat, Dec 9, 2023 at 9:30 AM Alexander Lakhin wrote:
>
> Hello hackers,
>
> While studying bug #18158, I've come to the conclusion that the existing
> testing infrastructure is unable to detect abnormal situations. of some
> kind.
>
> Just a simple example:
> With Assert(0) injected in
On Mon, Dec 11, 2023 at 1:22 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/8/23 10:06 AM, Amit Kapila wrote:
> > On Wed, Dec 6, 2023 at 4:53 PM shveta malik wrote:
> >>
> >> PFA v43, changes are:
> >>
> >
> > I wanted to discuss 0003 p
On Thu, Dec 7, 2023 at 1:33 PM Peter Smith wrote:
>
> Hi.
>
> Here are my review comments for patch v43-0002.
>
Thanks for the feedback. I have addressed most of these in v45. Please
find my response on a few which are pending or are not needed.
> ==
> Commit message
>
> 1.
> The nap time
On Sun, Dec 10, 2023 at 4:33 PM Amit Kapila wrote:
>
> On Wed, Dec 6, 2023 at 4:53 PM shveta malik wrote:
> >
> > v43-002:
> >
>
> Review comments on v43-0002:
> =
Thanks for the feedback Amit. Addressed these in v45. Please find my
On Mon, Dec 11, 2023 at 1:47 PM Dilip Kumar wrote:
>
> On Fri, Dec 8, 2023 at 2:36 PM Amit Kapila wrote:
> >
> > On Wed, Dec 6, 2023 at 4:53 PM shveta malik wrote:
> > >
> > > PFA v43, changes are:
> > >
> >
> > I wanted to discuss 0003 p
On Thu, Dec 7, 2023 at 2:57 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/7/23 10:07 AM, shveta malik wrote:
> > On Thu, Dec 7, 2023 at 1:19 PM Drouvot, Bertrand
> > wrote:
> >> Might be worth to add comments in the code (around the WalRcv->latestWalEnd
On Thu, Dec 7, 2023 at 1:19 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/6/23 11:58 AM, shveta malik wrote:
> > On Wed, Dec 6, 2023 at 3:00 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 12/6/23 7:18 AM, shveta ma
On Wed, Dec 6, 2023 at 3:00 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/6/23 7:18 AM, shveta malik wrote:
> > On Wed, Dec 6, 2023 at 10:56 AM Amit Kapila wrote:
> >>
> >> I feel that is indirectly relying on the fact that the primary won't
> >> adva
On Wed, Dec 6, 2023 at 10:56 AM Amit Kapila wrote:
>
> On Tue, Dec 5, 2023 at 7:38 PM Drouvot, Bertrand
> wrote:
> >
> > On 12/5/23 12:32 PM, Amit Kapila wrote:
> > > On Tue, Dec 5, 2023 at 10:38 AM shveta malik
> > > wrote:
> > >>
>
On Tue, Dec 5, 2023 at 2:18 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/5/23 6:08 AM, shveta malik wrote:
> > On Mon, Dec 4, 2023 at 10:07 PM Drouvot, Bertrand
> > wrote:
> >> Maybe another option could be to have the walreceiver a way to let the
On Mon, Dec 4, 2023 at 10:07 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/4/23 6:10 AM, shveta malik wrote:
> > On Fri, Dec 1, 2023 at 5:40 PM Nisha Moond wrote:
> >>
> >> Review for v41 patch.
> >
> > Thanks for the feedback.
> >
>
On Mon, Dec 4, 2023 at 10:40 AM shveta malik wrote:
>
> On Fri, Dec 1, 2023 at 5:40 PM Nisha Moond wrote:
> >
> > Review for v41 patch.
>
> Thanks for the feedback.
>
> >
> > 1.
> > ==
> > src/backend/utils/misc/postgresql.conf.s
On Fri, Dec 1, 2023 at 5:40 PM Nisha Moond wrote:
>
> Review for v41 patch.
Thanks for the feedback.
>
> 1.
> ==
> src/backend/utils/misc/postgresql.conf.sample
>
> +#enable_syncslot = on # enables slot synchronization on the physical
> standby from the primary
>
> enable_syncslot is
On Fri, Dec 1, 2023 at 3:43 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/30/23 1:06 PM, Ajin Cherian wrote:
> > On Wed, Nov 29, 2023 at 8:17 PM Zhijie Hou (Fujitsu)
> >
> > 3. If creation of a slot on the standby fails for one slot because a
> > slot of the same name exists, then thereafter no
On Fri, Dec 1, 2023 at 11:17 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Friday, December 1, 2023 12:51 PM shveta malik
> wrote:
>
> Hi,
>
> >
> > On Fri, Dec 1, 2023 at 9:40 AM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > On Wednesday, Nov
On Fri, Dec 1, 2023 at 9:40 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Wednesday, November 29, 2023 5:12 PM Zhijie Hou (Fujitsu)
> wrote:
>
> I was reviewing slotsync worker design and here
> are few comments on 0002 patch:
Thanks for reviewing the patch.
>
> 1.
>
> + if (!WalRcv ||
> +
On Thu, Nov 30, 2023 at 5:37 PM Ajin Cherian wrote:
>
> On Wed, Nov 29, 2023 at 8:17 PM Zhijie Hou (Fujitsu)
> wrote:
> >
> > This has been fixed.
> >
> > Best Regards,
> > Hou zj
>
> Thanks for addressing my comments. Some comments from my testing of patch v41
>
> 1. In my opinion, the second
On Tue, Nov 28, 2023 at 9:28 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/28/23 10:40 AM, shveta malik wrote:
> > On Tue, Nov 28, 2023 at 12:19 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 11/28/23 4:13 AM, shveta ma
On Fri, Nov 17, 2023 at 5:08 PM Amit Kapila wrote:
>
> On Thu, Nov 16, 2023 at 5:34 PM shveta malik wrote:
> >
> > PFA v35.
> >
>
> Review v35-0002*
> ==
> 1.
> As quoted in the commit message,
> >
> If a logical slot is invalid
On Tue, Nov 28, 2023 at 3:10 PM shveta malik wrote:
>
> On Tue, Nov 28, 2023 at 12:19 PM Drouvot, Bertrand
> wrote:
> >
> > Hi,
> >
> > On 11/28/23 4:13 AM, shveta malik wrote:
> > > On Mon, Nov 27, 2023 at 4:08 PM Amit Kapila
> > > wrote:
&
On Mon, Nov 27, 2023 at 4:08 PM Amit Kapila wrote:
>
> On Mon, Nov 27, 2023 at 2:27 PM Zhijie Hou (Fujitsu)
> wrote:
> >
> > Here is the updated version(v39_2) which include all the changes made in
> > 0002.
> > Please use for review, and sorry for the confusion.
> >
>
> ---
On Mon, Nov 27, 2023 at 2:15 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/27/23 7:02 AM, Zhijie Hou (Fujitsu) wrote:
> > On Monday, November 27, 2023 12:03 PM Zhijie Hou (Fujitsu)
> > wrote:
> >>
> >> Attach the V38 patch set which addressed all comments in [1][2] except for
> >> the
> >>
On Tue, Nov 21, 2023 at 1:13 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/21/23 6:16 AM, Amit Kapila wrote:
> > On Mon, Nov 20, 2023 at 6:51 PM Drouvot, Bertrand
> > wrote:
> >> As far the 'i' state here, from what I see, it is currently useful for:
> >>
> >> 1. Cascading standby to not sync
On Tue, Nov 21, 2023 at 10:02 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Friday, November 17, 2023 7:39 PM Amit Kapila
> wrote:
> >
> > On Thu, Nov 16, 2023 at 5:34 PM shveta malik
> > wrote:
> > >
> > > PFA v35.
> > >
> >
> > Review
On Tue, Nov 21, 2023 at 10:02 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Friday, November 17, 2023 7:39 PM Amit Kapila
> wrote:
> >
> > On Thu, Nov 16, 2023 at 5:34 PM shveta malik
> > wrote:
> > >
> > > PFA v35.
> > >
> >
> > Review
On Tue, Nov 21, 2023 at 10:01 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Saturday, November 18, 2023 6:46 PM Amit Kapila
> wrote:
> >
> > On Fri, Nov 17, 2023 at 5:18 PM Drouvot, Bertrand
> > wrote:
> > >
> > > On 11/17/23 2:46 AM, Zhijie Hou (Fujitsu) wrote:
> > > > On Tuesday, November 14, 2023
On Tue, Nov 14, 2023 at 7:56 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/13/23 2:57 PM, Zhijie Hou (Fujitsu) wrote:
> > On Friday, November 10, 2023 4:16 PM Drouvot, Bertrand
> > wrote:
> >> Yeah good point, agree to just error out in all the case then (if we
> >> discard the
> >> sync_
On Mon, Nov 13, 2023 at 11:02 AM Ajin Cherian wrote:
>
> On Thu, Nov 9, 2023 at 9:54 PM shveta malik wrote:
> >
> > PFA v32 patches which has below changes:
> Testing with this patch, I see that if the failover enabled slot is
> invalidated on the primary, then the c
On Thu, Nov 9, 2023 at 8:56 AM Amit Kapila wrote:
>
> On Thu, Nov 9, 2023 at 8:11 AM Amit Kapila wrote:
> >
> > On Wed, Nov 8, 2023 at 8:09 PM Drouvot, Bertrand
> > wrote:
> > >
> > > > Unrelated to above, if there is a user slot on standby with the same
> > > > name which the slot-sync worker
On Mon, Nov 13, 2023 at 6:19 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Thursday, November 9, 2023 6:54 PM shveta malik
> wrote:
> >
> >
> > PFA v32 patches which has below changes:
>
> Thanks for updating the patch.
>
> Here are few comments:
>
>
>
On Thu, Nov 9, 2023 at 9:15 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/9/23 11:54 AM, shveta malik wrote:
> >
> > PFA v32 patches which has below changes:
>
> Thanks!
>
> > 7) Added warning for cases where a user-slot with the same name is
> > alr
On Wed, Nov 8, 2023 at 3:19 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/8/23 9:57 AM, Amit Kapila wrote:
> > On Wed, Nov 8, 2023 at 12:32 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 11/8/23 4:50 AM, Amit Kapila wrote:
> >>
> >>> I think if we want to follow
> >>> this approach
On Mon, Nov 6, 2023 at 7:01 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Friday, November 3, 2023 7:32 PM Amit Kapila
> >
> > On Thu, Nov 2, 2023 at 2:35 PM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > Here is the new version patch set(V29) which addressed Peter
> > > comments[1][2] and fixed one doc
On Fri, Oct 27, 2023 at 8:43 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/27/23 11:56 AM, shveta malik wrote:
> > On Wed, Oct 25, 2023 at 3:15 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 10/25/23 5:00 AM, shveta
101 - 200 of 298 matches
Mail list logo
