On Fri, May 27, 2022 at 12:34 PM shiy.f...@fujitsu.com
wrote:
>
> On Wed, May 25, 2022 7:55 PM vignesh C wrote:
> >
> > The attached v16 patch has the changes for the same.
> >
>
> Thanks for updating the patch.
>
> Some comments for the document in 0
On Fri, May 27, 2022 at 10:56 AM Peter Smith wrote:
>
> Here are some more review comments for v15-0002 I found while working
> through the documented examples. These are all for
> doc/src/sgml/logical-replication.sgml. The section numbers (e.g.
> 31.11.1) are the assigned numbers after HTML
On Fri, May 27, 2022 at 7:54 AM Amit Kapila wrote:
>
> On Wed, Apr 6, 2022 at 9:36 AM Amit Kapila wrote:
> >
> > On Tue, Apr 5, 2022 at 7:06 PM Ashutosh Bapat
> > wrote:
> > >
> > > On Tue, Apr 5, 2022 at 6:21 AM Peter Smith wrote:
> > > >
> > > > Below are some other name ideas. Maybe they
On Thu, May 26, 2022 at 4:40 PM Amit Kapila wrote:
>
> On Fri, May 20, 2022 at 3:31 PM vignesh C wrote:
> >
> > On Wed, May 18, 2022 at 4:22 PM Amit Kapila wrote:
> > >
> > > 5.
> > > * It is quite possible that subscriber has not yet pulled dat
On Thu, May 26, 2022 at 2:06 PM Peter Smith wrote:
>
> This post completes my review of patch v15*.
>
> ==
>
> 1. A general comment affecting both patches
>
> I realised the things defined in the subscription WITH are referred to
> in the PG DOCS as "parameters" (not "options"). See CREATE
>
On Tue, May 24, 2022 at 8:06 AM shiy.f...@fujitsu.com
wrote:
>
> On Tue, May 24, 2022 1:34 AM vignesh C wrote:
> >
> > Thanks for the comments, the attached v15 patch has the fixes for the same.
> >
>
> Thanks for updating the patch. I have a comment on the documen
On Sat, May 21, 2022 at 11:06 AM vignesh C wrote:
>
> On Fri, May 20, 2022 at 11:23 AM Peter Smith wrote:
> >
> > Below are my review comments for v6-0002.
> >
> > ==
> >
> > 1. Commit message.
> > The psql \d family of commands to display exc
On Fri, May 20, 2022 at 11:23 AM Peter Smith wrote:
>
> Below are my review comments for v6-0002.
>
> ==
>
> 1. Commit message.
> The psql \d family of commands to display excluded tables.
>
> SUGGESTION
> The psql \d family of commands can now display excluded tables.
Modified
> ~~~
>
> 2.
On Fri, May 20, 2022 at 5:49 AM Peter Smith wrote:
>
> FYI, although the v6-0002 patch applied cleanly, I found that the SGML
> was malformed and so the pg docs build fails.
>
> ~~~
> e.g.
>
> [postgres@CentOS7-x64 sgml]$ make STYLE=website html
> { \
> echo ""; \
> echo ""; \
> } >
On Thu, May 19, 2022 at 1:49 PM Peter Smith wrote:
>
> Below are my review comments for v6-0001.
>
> ==
>
> 1. General.
>
> The patch failed 'publication' tests in the make check phase.
>
> Please add this work to the commit-fest so that the 'cfbot' can report
> such errors sooner.
Added
On Thu, May 19, 2022 at 2:12 PM shiy.f...@fujitsu.com
wrote:
>
> On Wed, May 4, 2022 2:47 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v13 patch has the changes for the
> > same.
> >
>
> Here are some comments on v13-0002 patch.
>
>
On Wed, May 18, 2022 at 4:22 PM Amit Kapila wrote:
>
> On Wed, May 18, 2022 at 10:29 AM Amit Kapila wrote:
> >
> > On Wed, May 4, 2022 at 12:17 PM vignesh C wrote:
> > >
> > > Thanks for the comments, the attached v13 patch has the changes for the
> >
On Wed, May 18, 2022 at 1:40 PM shiy.f...@fujitsu.com
wrote:
>
> On Wed, May 4, 2022 2:47 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v13 patch has the changes for the
> > same.
> >
>
> Thanks for your patch. Here are some comments o
On Tue, May 17, 2022 at 7:35 AM Peter Smith wrote:
>
> Below are my review comments for v5-0002.
>
> There may be an overlap with comments recently posted by Osumi-san [1].
>
> (I also have review comments for v5-0002; will post them tomorrow)
>
> ==
>
> 1. General
>
> Is it really necessary
On Mon, May 16, 2022 at 2:00 PM osumi.takami...@fujitsu.com
wrote:
>
> On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> > Thanks for the comments, the attached v5 patch has the changes for the same.
> > Also I have made the changes for SKIP Table based on the new synta
On Wed, May 18, 2022 at 8:30 AM shiy.f...@fujitsu.com
wrote:
>
> On Sat, May 14, 2022 9:33 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v5 patch has the changes for the
> > same. Also I have made the changes for SKIP Table based on the new
On Mon, May 16, 2022 at 2:53 PM Peter Smith wrote:
>
> Below are my review comments for v5-0001.
>
> There is some overlap with comments recently posted by Osumi-san [1].
>
> (I also have review comments for v5-0002; will post them tomorrow)
>
> ==
>
> 1. Commit message
>
> This patch adds a
On Mon, May 16, 2022 at 8:32 AM osumi.takami...@fujitsu.com
wrote:
>
> On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> > Thanks for the comments, the attached v5 patch has the changes for the same.
> > Also I have made the changes for SKIP Table based on the new synta
On Fri, May 13, 2022 at 9:37 AM Peter Smith wrote:
>
> On Thu, May 12, 2022 at 2:24 PM vignesh C wrote:
> >
> ...
> > The attached patch has the implementation for "ALTER PUBLICATION
> > pubname RESET". This command will reset the publication to defau
I wonder if this is worth mentioning:
Raise a WARNING for missing publications.
commit 8f2e2bbf145384784bad07a96d461c6bbd91f597
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=8f2e2bbf145384784bad07a96d461c6bbd91f597
Regards,
Vignesh
On Thu, May 12, 2022 at 7:52 PM Bruce
On Tue, May 10, 2022 at 9:08 AM vignesh C wrote:
>
> On Fri, May 6, 2022 at 8:05 AM Peter Smith wrote:
> >
> > On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
> > >
> > ...
> > >
> > > Another idea that occurred to me today for tables t
l the CREATE PUBLICATION, CREATE
> SUBSCRIPTION, and TRUNCATE steps described above.
>
> Notice this proposal has some external API similarities with the BDR
> extension [3] (which also provides multi-master logical replication),
> although we plan to implement it ent
On Fri, May 6, 2022 at 8:05 AM Peter Smith wrote:
>
> On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
> >
> ...
> >
> > Another idea that occurred to me today for tables this is as follows:
> > 1. Allow to mention except during create publication ... For All Tables.
> > CREATE PUBLICATION
On Thu, May 5, 2022 at 2:41 PM Alvaro Herrera wrote:
>
> On 2022-May-04, vignesh C wrote:
>
> > On Mon, May 2, 2022 at 5:49 AM Peter Smith wrote:
>
> > > 1. Commit message
> > >
> > > In another thread using the terminology "multi-master" se
On Mon, May 2, 2022 at 5:49 AM Peter Smith wrote:
>
> Thanks for updating the patches for all my prior feedback.
>
> For v12* I have only minor feedback for the docs.
>
> ==
> V12-0001
>
> no comments
>
> ==
> V12-0002
>
> 1. Commit message
>
> In another thread using the terminology
On Thu, Apr 28, 2022 at 4:50 PM osumi.takami...@fujitsu.com
wrote:
>
> On Wednesday, April 27, 2022 9:50 PM vignesh C wrote:
> > Thanks for the comments, the attached v3 patch has the changes for the same.
> Hi
>
> Thank you for updating the patch. Several minor comments
On Fri, Apr 29, 2022 at 8:08 AM Peter Smith wrote:
>
> Here are my review comments for the v11* patches.
>
> ==
>
> v11-0001 - no more comments. LGTM
>
> ==
>
> V11-0002
>
> 1. doc/src/sgml/logical-replication.sgml
>
> +
> + Bidirectional replication is useful in creating multi
On Fri, Apr 29, 2022 at 2:35 PM Peter Smith wrote:
>
> On Fri, Apr 29, 2022 at 2:16 PM Yura Sokolov wrote:
> >
> > В Чт, 28/04/2022 в 17:37 +0530, vignesh C пишет:
> > > On Thu, Apr 28, 2022 at 4:24 PM Yura Sokolov
> > > wrote:
> > > > В
On Thu, Apr 28, 2022 at 7:57 AM Peter Smith wrote:
>
> Here are my review comments for v10-0002 (TAP tests part only)
>
> FIle: src/test/subscription/t/032_localonly.pl
>
> ==
>
> 1.
>
> +# Detach node C and clean the table contents.
> +sub detach_node_clean_table_data
> +{
>
> 1a. Maybe say
On Thu, Apr 28, 2022 at 4:24 PM Yura Sokolov wrote:
>
> В Чт, 28/04/2022 в 09:49 +1000, Peter Smith пишет:
>
> > 1.1 ADVANTAGES OF MMLR
> >
> > - Increases write scalability (e.g., all nodes can write arbitrary data).
>
> I've never heard how transactional-aware multimaster increases
> write
On Tue, Apr 26, 2022 at 11:32 AM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, April 21, 2022 12:15 PM vignesh C wrote:
> > Updated patch by changing the syntax to use EXCEPT instead of SKIP.
> Hi
>
>
> This is my review comments on the v2 patch.
>
> (1)
On Fri, Apr 8, 2022 at 2:44 PM houzj.f...@fujitsu.com
wrote:
>
> On Wednesday, April 6, 2022 1:20 PM Amit Kapila
> wrote:
>
> > In this email, I would like to discuss allowing streaming logical
> > transactions (large in-progress transactions) by background workers
> > and parallel apply in
On Wed, Apr 20, 2022 at 11:19 AM Peter Smith wrote:
>
> Below are my review comments for the v9-0002 patch (TAP test part only).
>
> (The order of my comments is a bit muddled because I jumped around in
> the file a bit while reviewing it).
>
> ==
>
> 1. create_subscription - missing comment.
On Wed, Apr 20, 2022 at 7:26 AM Peter Smith wrote:
>
> Below are my review comments for the v9-0002 patch (except I did not
> yet look at the TAP tests).
>
> ~~~
>
> 1. General comment - describe.c
>
> I wondered why the copy_data enum value is not displayed by the psql
> \drs+ command. Should it
On Tue, Apr 19, 2022 at 8:29 AM Peter Smith wrote:
>
> I checked the latest v9-0001 patch. Below are my review comments.
>
> Other than these few trivial comments this 0001 patch looks good to me.
>
> ~~~
>
> 1. src/backend/replication/pgoutput/pgoutput.c - whitespace
>
> @@ -1696,6 +1714,10 @@
On Mon, Apr 18, 2022 at 12:32 PM Amit Kapila wrote:
>
> On Fri, Apr 15, 2022 at 1:26 AM Euler Taveira wrote:
> >
> > On Thu, Apr 14, 2022, at 10:47 AM, Peter Eisentraut wrote:
> >
> > On 12.04.22 08:23, vignesh C wrote:
> > > I have also included the implem
On Thu, Apr 14, 2022 at 7:18 PM Peter Eisentraut
wrote:
>
> On 12.04.22 08:23, vignesh C wrote:
> > I have also included the implementation for skipping a few tables from
> > all tables publication, the 0002 patch has the implementation for the
> > same.
> > This fe
On Fri, Apr 15, 2022 at 11:49 AM Kyotaro Horiguchi
wrote:
>
> At Thu, 14 Apr 2022 10:33:50 +0530, vignesh C wrote in
> > On Wed, Apr 6, 2022 at 12:29 PM vignesh C wrote:
> > >
> > > On Tue, Apr 5, 2022 at 9:18 PM Robert Haas wrote:
> > > > This lo
On Thu, Apr 14, 2022 at 1:53 PM Peter Smith wrote:
>
> Here are my review comments for v8-0001.
>
> ==
>
> 1. Commit message
>
> CREATE SUBSCRIPTION sub1 CONNECTION 'dbname =postgres port='
> PUBLICATION pub1 with (local_only = true);
>
> The spaces in the CONNECTION string are a bit
On Wed, Apr 6, 2022 at 12:29 PM vignesh C wrote:
>
> On Tue, Apr 5, 2022 at 9:18 PM Robert Haas wrote:
> >
> > On Wed, Mar 30, 2022 at 12:03 PM Justin Pryzby wrote:
> > > On Wed, Mar 30, 2022 at 11:53:52AM -0400, Greg Stark wrote:
> > > > Sadly the cfbot
On Tue, Apr 12, 2022 at 4:46 PM Amit Kapila wrote:
>
> On Tue, Apr 12, 2022 at 4:17 PM vignesh C wrote:
> >
> > On Tue, Apr 12, 2022 at 12:19 PM Amit Kapila
> > wrote:
> > >
> > >
> > > For the second syntax (Alter Publication ...), isn't it
On Tue, Apr 12, 2022 at 12:19 PM Amit Kapila wrote:
>
> On Tue, Apr 12, 2022 at 11:53 AM vignesh C wrote:
> >
> > On Sat, Mar 26, 2022 at 7:37 PM vignesh C wrote:
> > >
> > > On Tue, Mar 22, 2022 at 12:38 PM vignesh C wrote:
> > > >
> &g
On Tue, Apr 12, 2022 at 10:26 AM Peter Smith wrote:
>
> On Thu, Apr 7, 2022 at 2:09 PM Peter Smith wrote:
> >
> > FYI, here is a test script that is using the current patch (v6) to
> > demonstrate a way to share table data between different numbers of
> > nodes (up to 5 of them here).
> >
> >
On Tue, Apr 5, 2022 at 8:17 AM Peter Smith wrote:
>
> Here are my comments for the latest patch v6-0002.
>
> PATCH v6-0002 comments
> ==
>
> 2.1 General - should this be an independent patch?
>
> In many ways, I think most of this patch is unrelated to the other
> "local_only"
On Tue, Apr 5, 2022 at 6:21 AM Peter Smith wrote:
>
> Here are my comments for the latest patch v6-0001.
>
> (I will post my v6-0002 review comments separately)
>
> PATCH v6-0001 comments
> ==
>
> 1.1 General - Option name
>
> I still feel like the option name is not ideal.
On Fri, Apr 8, 2022 at 4:38 AM Peter Smith wrote:
>
> Hi Vignesh, FYI the patch is recently broken again and is failing on cfbot
> [1].
>
> --
> [1] http://cfbot.cputube.org/patch_38_3610.log
I'm working on fixing a few review comments, I will be posting an
updated version to handle this
uest to log the backtrace
because allowing any users to issue this request at an unbounded rate
would cause lots of log messages and which can lead to denial of service.
On receipt of the request, at the next CHECK_FOR_INTERRUPTS(),
the target backend logs its backtrace at LOG_SERVER_ONLY level,
so th
On Mon, Apr 4, 2022 at 6:50 PM Ashutosh Bapat
wrote:
>
> I didn't find this in https://commitfest.postgresql.org/37/. Is this
> somewhere in the commitfest?
I missed adding it earlier, I have added it to commitfest today:
https://commitfest.postgresql.org/38/3610/
Regards,
Vignesh
On Thu, Mar 31, 2022 at 2:52 PM Amit Kapila wrote:
>
> On Thu, Mar 31, 2022 at 9:14 AM Amit Kapila wrote:
> >
> > On Wed, Mar 30, 2022 at 7:40 PM Ashutosh Bapat
> > wrote:
> > > >
> > > > The changes for the same are available int the v5 patch available at
> > > > [1].
> > > > [1] -
> > > >
On Wed, Mar 30, 2022 at 7:22 PM Ashutosh Bapat
wrote:
>
> Hi Vignesh,
> Some review comments on 0001
>
> On Wed, Mar 16, 2022 at 11:17 AM vignesh C wrote:
>
> >
> > The changes for the same are available int the v5 patch available at [1].
> > [1] -
>
On Wed, Mar 30, 2022 at 5:42 PM Bharath Rupireddy
wrote:
>
> On Wed, Mar 30, 2022 at 5:37 PM Bharath Rupireddy
> wrote:
> >
> > On Wed, Mar 30, 2022 at 4:29 PM Amit Kapila wrote:
> > >
> > > On Wed, Mar 30, 2022 at 12:22 PM vignesh C wrote:
On Wed, Mar 30, 2022 at 11:22 AM Amit Kapila wrote:
>
> On Tue, Mar 29, 2022 at 8:11 PM vignesh C wrote:
> >
> > On Tue, Mar 29, 2022 at 11:02 AM Amit Kapila
> > wrote:
> > >
> >
> > Thanks for the suggestion, I have changed the patch as sugg
On Tue, Mar 29, 2022 at 4:12 PM Amit Kapila wrote:
>
> On Tue, Mar 29, 2022 at 11:01 AM Amit Kapila wrote:
> >
> > On Sat, Mar 26, 2022 at 7:53 PM vignesh C wrote:
> > >
> > > The patch was not applying on HEAD, attached patch which is rebased on
&
On Tue, Mar 29, 2022 at 11:02 AM Amit Kapila wrote:
>
> On Sat, Mar 26, 2022 at 7:53 PM vignesh C wrote:
> >
> > The patch was not applying on HEAD, attached patch which is rebased on
> > top of HEAD.
> >
>
> IIUC, this patch provides an option that allows us
On Sun, Mar 27, 2022 at 2:54 AM Andres Freund wrote:
>
> Hi,
>
> I'm working to increase the test coverage of pgstat related stuff higher (for
> the shared memory stats patch, of course).
>
> "Accidentally" noticed that
> SELECT * FROM pg_stat_get_replication_slot(NULL);
> crashes. This is
On Tue, Mar 22, 2022 at 3:23 PM vignesh C wrote:
>
> On Tue, Mar 22, 2022 at 5:29 AM Andres Freund wrote:
> >
> > On 2022-02-13 19:34:05 +0530, vignesh C wrote:
> > > Thanks for the comments, the attached v14 patch has the changes for the
> > > sa
On Tue, Mar 22, 2022 at 12:38 PM vignesh C wrote:
>
> Hi,
>
> This feature adds an option to skip changes of all tables in specified
> schema while creating publication.
> This feature is helpful for use cases where the user wants to
> subscribe to all the changes except fo
On Fri, Mar 25, 2022 at 3:29 AM Tomas Vondra
wrote:
>
> Hi,
>
> Pushed, after going through the patch once more, addressed the remaining
> FIXMEs, corrected a couple places in the docs and comments, etc. Minor
> tweaks, nothing important.
While rebasing patch [1] I found a couple of comments:
On Tue, Mar 22, 2022 at 5:29 AM Andres Freund wrote:
>
> On 2022-02-13 19:34:05 +0530, vignesh C wrote:
> > Thanks for the comments, the attached v14 patch has the changes for the
> > same.
>
> The patch needs a rebase, it currently fails to apply:
> http://cfbot.cp
Hi,
This feature adds an option to skip changes of all tables in specified
schema while creating publication.
This feature is helpful for use cases where the user wants to
subscribe to all the changes except for the changes present in a few
schemas.
Ex:
CREATE PUBLICATION pub1 FOR ALL TABLES SKIP
On Tue, Mar 15, 2022 at 9:55 AM kuroda.hay...@fujitsu.com
wrote:
>
> Dear Vignesh,
>
> > Thanks for kind explanation.
> > I read above and your doc in 0002, and I put some comments.
>
> I forgot a comment about 0002 doc.
>
> 5. create_subscription.sgml - about your example
>
> Three possibilities
On Tue, Mar 15, 2022 at 7:09 AM kuroda.hay...@fujitsu.com
wrote:
>
> Dear Vignesh,
>
> Thank you for updating your patch!
>
> > Let's consider an existing Multi master logical replication setup
> > between Node1 and Node2 that is created using the following steps:
> > a) Node1 - Publication
On Mon, Mar 14, 2022 at 5:23 AM Tom Lane wrote:
>
> vignesh C writes:
> > Here "pg_%" should be "pg_%%".
>
> Right you are. Patch pushed, thanks!
Thanks for pushing the patch.
Regards,
Vignesh
Hi,
I noticed that the following commands "CREATE PUBLICATION pub1 FOR ALL
TABLES IN SCHEMA" and "ALTER PUBLICATION pub1 ADD ALL TABLES IN
SCHEMA" does not complete with the schema list. I feel this is because
of the following code in tab-complete.c:
.
On Fri, Dec 3, 2021 at 3:21 PM vignesh C wrote:
>
> On Fri, Dec 3, 2021 at 1:13 PM Michael Paquier wrote:
> >
> > On Thu, Aug 26, 2021 at 09:00:39PM +0530, vignesh C wrote:
> > > The previous patch was failing because of the recent test changes made
> > > by
lots of log messages and which can lead to denial of service.
On receipt of the request, at the next CHECK_FOR_INTERRUPTS(),
the target backend logs its backtrace at LOG_SERVER_ONLY level,
so that the backtrace will appear in the server log but not
be sent to the client.
Bump catalog version.
Auth
On Fri, Mar 11, 2022 at 4:28 PM kuroda.hay...@fujitsu.com
wrote:
>
> Hi Vegnesh,
>
> While considering about second problem, I was very confusing about it.
> I'm happy if you answer my question.
>
> > To handle this if user has specified only_local option, we could throw
> > a warning or error
On Wed, Mar 2, 2022 at 3:59 PM Amit Kapila wrote:
>
> On Wed, Feb 23, 2022 at 11:59 AM vignesh C wrote:
> >
> ...
> ...
> > I have attached a basic patch for this, if the idea is accepted, I
> > will work further to test more scenarios, add documentation, and test
On Mon, Mar 7, 2022 at 9:57 PM vignesh C wrote:
>
> On Mon, Mar 7, 2022 at 5:51 PM Amit Kapila wrote:
> >
> > On Mon, Mar 7, 2022 at 5:01 PM Ashutosh Bapat
> > wrote:
> > >
> > > Hi Vignesh,
> > > I agree with Peter's comment that the chang
On Mon, Mar 7, 2022 at 2:28 PM Peter Smith wrote:
>
> Hi Vignesh,
>
> Here are some review comments for patch v2.
>
> ==
>
> 1. Question about syntax
>
> I already posted some questions about why the syntax is on the CREATE
> SUBSCRCRIBER side.
> IMO "local_only" is a publisher option, so it
On Mon, Mar 7, 2022 at 5:51 PM Amit Kapila wrote:
>
> On Mon, Mar 7, 2022 at 5:01 PM Ashutosh Bapat
> wrote:
> >
> > Hi Vignesh,
> > I agree with Peter's comment that the changes to
> > FilterRemoteOriginData() should be part of FilterByOrigin()
> >
> > Further, I wonder why "onlylocal_data" is
On Mon, Mar 7, 2022 at 1:45 PM Peter Smith wrote:
>
> On Mon, Mar 7, 2022 at 6:17 PM vignesh C wrote:
> >
> > On Mon, Mar 7, 2022 at 11:45 AM Peter Smith wrote:
> > >
> > > On Mon, Mar 7, 2022 at 4:20 PM vignesh C wrote:
> > > >
>
On Mon, Mar 7, 2022 at 11:45 AM Peter Smith wrote:
>
> On Mon, Mar 7, 2022 at 4:20 PM vignesh C wrote:
> >
> > On Mon, Mar 7, 2022 at 10:26 AM Peter Smith wrote:
> > >
> > > Hi Vignesh, I also have not looked at the patch yet, but I have what
> > >
On Tue, Mar 1, 2022 at 4:12 PM kuroda.hay...@fujitsu.com
wrote:
>
> Hi Vignesh,
>
> > In logical replication, currently Walsender sends the data that is
> > generated locally and the data that are replicated from other
> > instances. This results in infinite recursion in circular logical
> >
On Mon, Mar 7, 2022 at 10:26 AM Peter Smith wrote:
>
> Hi Vignesh, I also have not looked at the patch yet, but I have what
> seems like a very fundamental (and possibly dumb) question...
>
> Basically, I do not understand the choice of syntax for setting things up.
>
> IMO that "only-local"
On Tue, Mar 1, 2022 at 4:12 PM kuroda.hay...@fujitsu.com
wrote:
>
> Hi Vignesh,
>
> > In logical replication, currently Walsender sends the data that is
> > generated locally and the data that are replicated from other
> > instances. This results in infinite recursion in circular logical
> >
On Tue, Mar 1, 2022 at 4:12 PM kuroda.hay...@fujitsu.com
wrote:
>
> Hi Vignesh,
>
> > In logical replication, currently Walsender sends the data that is
> > generated locally and the data that are replicated from other
> > instances. This results in infinite recursion in circular logical
> >
Hi,
In logical replication, currently Walsender sends the data that is
generated locally and the data that are replicated from other
instances. This results in infinite recursion in circular logical
replication setup.
Here the user is trying to have a 2-way replication setup with node 1
On Fri, Feb 11, 2022 at 7:14 PM Ashutosh Sharma wrote:
>
> I have spent little time looking at the latest patch. The patch looks
> to be in good shape as it has already been reviewed by many people
> here, although I did get some comments. Please take a look and let me
> know your thoughts.
>
>
>
On Thu, Feb 10, 2022 at 3:15 PM Ashutosh Sharma wrote:
>
> On Wed, Feb 9, 2022 at 11:53 PM Euler Taveira wrote:
> >
> > On Wed, Feb 9, 2022, at 12:06 PM, Ashutosh Sharma wrote:
> >
> > Just wondering if we should also be detecting the incorrect conninfo
> > set with ALTER SUBSCRIPTION command as
On Sat, Jan 29, 2022 at 8:06 AM vignesh C wrote:
>
> On Fri, Jan 28, 2022 at 1:54 PM Bharath Rupireddy
> wrote:
> >
> > On Thu, Jan 27, 2022 at 10:45 AM vignesh C wrote:
> > >
> > > On Wed, Jan 26, 2022 at 11:07 AM Bharath Rupireddy
> > > wrote:
On Fri, Jan 28, 2022 at 1:54 PM Bharath Rupireddy
wrote:
>
> On Thu, Jan 27, 2022 at 10:45 AM vignesh C wrote:
> >
> > On Wed, Jan 26, 2022 at 11:07 AM Bharath Rupireddy
> > wrote:
> > >
> > > On Tue, Jan 25, 2022 at 12:00 PM vignesh C wrote:
> >
On Wed, Jan 26, 2022 at 11:07 AM Bharath Rupireddy
wrote:
>
> On Tue, Jan 25, 2022 at 12:00 PM vignesh C wrote:
> > Thanks for the comments, attached v17 patch has the fix for the same.
>
> Have a minor comment on v17:
>
> can we modify the elog(LOG, to new style
On Mon, Jan 24, 2022 at 1:05 PM torikoshia wrote:
>
> On 2022-01-14 19:48, Bharath Rupireddy wrote:
> > On Sat, Nov 20, 2021 at 11:50 AM Bharath Rupireddy
> > wrote:
> >>
> >> On Fri, Nov 19, 2021 at 4:07 PM vignesh C wrote:
> >> > T
On Mon, Jan 24, 2022 at 10:06 PM Fujii Masao
wrote:
>
>
>
> On 2022/01/24 16:35, torikoshia wrote:
> > On 2022-01-14 19:48, Bharath Rupireddy wrote:
> >> On Sat, Nov 20, 2021 at 11:50 AM Bharath Rupireddy
> >> wrote:
> >>>
> &
On Sat, Jan 15, 2022 at 3:58 PM Amit Kapila wrote:
>
> On Fri, Jan 14, 2022 at 5:35 PM vignesh C wrote:
> >
> > Thanks for the updated patch, few minor comments:
> > 1) Should "SKIP" be "SKIP (" here:
> > @@ -1675,7 +1675,7 @@ ps
On Fri, Jan 14, 2022 at 7:49 AM Masahiko Sawada wrote:
>
> On Wed, Jan 12, 2022 at 11:10 PM vignesh C wrote:
> >
> > On Wed, Jan 12, 2022 at 11:32 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Jan 12, 2022 at 12:21 PM Amit Kapila
> > >
On Wed, Jan 12, 2022 at 11:32 AM Masahiko Sawada wrote:
>
> On Wed, Jan 12, 2022 at 12:21 PM Amit Kapila wrote:
> >
> > On Wed, Jan 12, 2022 at 5:49 AM Masahiko Sawada
> > wrote:
> > >
> > > On Tue, Jan 11, 2022 at 7:08 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Tue, Jan 11, 2022 at 1:51
On Tue, Jan 11, 2022 at 7:52 AM Amit Kapila wrote:
>
> On Mon, Jan 10, 2022 at 2:57 PM vignesh C wrote:
> >
> > 2) Can we have an option to specify last_error_xid of
> > pg_stat_subscription_workers. Something like:
> > alter subscription sub1 skip (
On Fri, Jan 7, 2022 at 11:23 AM Masahiko Sawada wrote:
>
> On Fri, Jan 7, 2022 at 10:04 AM Masahiko Sawada wrote:
> >
> > On Wed, Jan 5, 2022 at 12:31 PM Amit Kapila wrote:
> > >
> > > On Mon, Dec 27, 2021 at 9:54 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Thu, Dec 16, 2021 at 2:42 PM
On Tue, Jan 4, 2022 at 9:58 AM Peter Smith wrote:
>
> Here is the v58* patch set:
>
> Main changes from v57* are
> 1. Couple of review comments fixed
>
> ~~
>
> Review comments (details)
> =
>
> v58-0001 (main)
> - PG docs updated as suggested [Alvaro, Euler 26/12]
>
>
On Tue, Dec 21, 2021 at 2:29 PM Peter Smith wrote:
>
> Here is the v51* patch set:
>
I tweaked the query slightly based on Euler's changes, the explain
analyze of the updated query based on Euler's suggestions, existing
query and Euler's query is given below:
1) updated query based on Euler's
On Tue, Dec 21, 2021 at 2:29 PM Peter Smith wrote:
>
> Here is the v51* patch set:
>
> Main changes from Euler's v50* are
> 1. Most of Euler's "fixes" patches are now merged back in
> 2. Patches are then merged per Amit's suggestion [Amit 20/12]
> 3. Some other review comments are addressed
>
>
On Mon, Dec 20, 2021 at 8:41 AM houzj.f...@fujitsu.com
wrote:
>
> On Fri, Dec 17, 2021 6:09 PM Amit Kapila wrote:
> > On Fri, Dec 17, 2021 at 4:11 AM Peter Smith wrote:
> > >
> > > PSA the v47* patch set.
> Thanks for the comments, I agree with all the comments.
> Attach the V49 patch set,
On Tue, Dec 14, 2021 at 7:58 AM Amit Kapila wrote:
>
> On Mon, Dec 13, 2021 at 5:48 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, December 13, 2021 6:19 PM Amit Kapila
> > wrote:
> > > On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
> > > wrote:
> > >
> > > Few
On Fri, Dec 10, 2021 at 11:14 AM Masahiko Sawada wrote:
>
> On Thu, Dec 9, 2021 at 6:16 PM Amit Kapila wrote:
> >
> > On Thu, Dec 9, 2021 at 2:24 PM Masahiko Sawada
> > wrote:
> > >
> > > On Thu, Dec 9, 2021 at 11:47 AM Amit Kapila
> > > wrote:
> > > >
> > > > I am thinking that we can start
On Fri, Dec 10, 2021 at 11:14 AM Masahiko Sawada wrote:
>
> On Thu, Dec 9, 2021 at 6:16 PM Amit Kapila wrote:
> >
> > On Thu, Dec 9, 2021 at 2:24 PM Masahiko Sawada
> > wrote:
> > >
> > > On Thu, Dec 9, 2021 at 11:47 AM Amit Kapila
> > > wrote:
> > > >
> > > > I am thinking that we can start
On Wed, Dec 8, 2021 at 11:07 AM tanghy.f...@fujitsu.com
wrote:
>
> On Wednesday, December 8, 2021 1:49 PM, vignesh C wrote:
>
> > The patch no longer applies, could you post a rebased patch.
>
> Thanks for your kindly reminder. Attached a rebased patch.
> Some changes in
On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, December 6, 2021 11:27 PM vignesh C wrote:
> > Thanks for the updated patch, few comments:
> Thank you for your review !
>
> > 1) We can keep the documentation similar to mention the count
On Mon, Dec 6, 2021 at 4:22 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, December 6, 2021 1:16 PM Greg Nancarrow
> wrote:
> > On Sat, Dec 4, 2021 at 12:20 AM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > Hi, I've made a new patch v11 that incorporated suggestions described
> >
701 - 800 of 1505 matches
Mail list logo
