Re: 'converts internal representation to "..."' comment is confusing

On 24/06/2023 23:52, Steve Chavez wrote: On Tue, 16 May 2023 at 07:49, Robert Haas > wrote: On Sun, May 14, 2023 at 9:37 PM Tom Lane mailto:t...@sss.pgh.pa.us>> wrote: > Steve Chavez mailto:st...@supabase.io>> writes: > > I found "..." confusing in som

Re: 'converts internal representation to "..."' comment is confusing

Hello hackers, Tom, could we apply this patch since Robert agrees it's an improvement? Best regards, Steve On Tue, 16 May 2023 at 07:49, Robert Haas wrote: > On Sun, May 14, 2023 at 9:37 PM Tom Lane wrote: > > Steve Chavez writes: > > > I found "..." confusing in some comments, so this patch

Re: 'converts internal representation to "..."' comment is confusing

On Sun, May 14, 2023 at 9:37 PM Tom Lane wrote: > Steve Chavez writes: > > I found "..." confusing in some comments, so this patch changes it to > > "cstring". Which seems to be the intention after all. > > Those comments are Berkeley-era, making them probably a decade older > than the "cstring"

Re: 'converts internal representation to "..."' comment is confusing

Thanks a lot for the clarification! The "..." looks enigmatic right now. I think cstring would save newcomers some head-scratching. Open to suggestions though. Best regards, Steve On Sun, 14 May 2023 at 22:36, Tom Lane wrote: > Steve Chavez writes: > > I found "..." confusing in some comment

Re: 'converts internal representation to "..."' comment is confusing

Steve Chavez writes: > I found "..." confusing in some comments, so this patch changes it to > "cstring". Which seems to be the intention after all. Those comments are Berkeley-era, making them probably a decade older than the "cstring" pseudotype (invented in b663f3443). Perhaps what you sugges

'converts internal representation to "..."' comment is confusing

Hello hackers, I found "..." confusing in some comments, so this patch changes it to "cstring". Which seems to be the intention after all. Best regards, Steve From cb1792c45ea9a2fbd2c08e185653b60dc262a17d Mon Sep 17 00:00:00 2001 From: steve-chavez Date: Sun, 14 May 2023 18:00:49 -0300 Subject: