Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

2024-01-26 Thread vignesh C
On Wed, 22 Nov 2023 at 21:54, Daniel Verite wrote: > > Shlok Kyal wrote: > > > > The error was corrected and a new diff file was created. > > > The diff file was created based on 16 RC1. > > > We confirmed that 5 places where errors occurred when performing > > > make check were changed

Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

2023-11-22 Thread Daniel Verite
Shlok Kyal wrote: > > The error was corrected and a new diff file was created. > > The diff file was created based on 16 RC1. > > We confirmed that 5 places where errors occurred when performing > > make check were changed to ok. Reviewing the patch, I see these two problems in the

Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

2023-11-06 Thread Shlok Kyal
Hi, On Mon, 6 Nov 2023 at 13:47, 쿼리트릭스 wrote: > > The error was corrected and a new diff file was created. > The diff file was created based on 16 RC1. > We confirmed that 5 places where errors occurred when performing make check > were changed to ok. > I went through Cfbot and still see that

Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

2023-09-18 Thread 쿼리트릭스
The error was corrected and a new diff file was created. The diff file was created based on 16 RC1. We confirmed that 5 places where errors occurred when performing make check were changed to ok. Team Query Tricks --- querytricks2023.gmail.com Query

Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

2023-09-13 Thread Peter Eisentraut
On 12.09.23 09:27, 쿼리트릭스 wrote: Thank you for letting me know more about the test method. As you said, we applied the patch using git diff and created a test case on the src/test/regress/sql. Because of the change of the psql output, a lot of existing test cases are now failing. You should

Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

2023-09-12 Thread 쿼리트릭스
Thank you for letting me know more about the test method. As you said, we applied the patch using git diff and created a test case on the src/test/regress/sql. Considering your question, we think it is enough to assume just one subpartition level. Because, Concidering the common partition

Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

2023-08-25 Thread Cary Huang
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: not tested Spec compliant: not tested Documentation:not tested Hello Thank you for the patch and the effort to enhance \d+ 's output

[ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

2023-06-08 Thread 쿼리트릭스
Hi, We are Query Tricks. We are a project team created to provide better usability for PostgreSQL DBAs and users. and I'm Hyunhee Ryu, a member of the project team. There is something I would like you to consider introducing in a new version of the release. This is related to \d+ table_name and