Re: [BUG] Skipped initialization of some xl_xact_parsed_prepare fields

2025-05-20 Thread Daniil Davydov
Hi, On Wed, May 21, 2025 at 9:59 AM Fujii Masao wrote: > I've pushed the patch. Thanks! > Glad to hear it, thank you! -- Best regards, Daniil Davydov

Re: [BUG] Skipped initialization of some xl_xact_parsed_prepare fields

2025-05-20 Thread Fujii Masao
On Thu, May 15, 2025 at 8:30 PM Fujii Masao wrote: > > I suppose to add initialization of `nstats` and `nabortstats` to > > ParsePrepareRecord (see attached patch). > > LGTM. Barring any objection, I will commit this patch. I've pushed the patch. Thanks! Regards, -- Fujii Masao

Re: [BUG] Skipped initialization of some xl_xact_parsed_prepare fields

2025-05-15 Thread Fujii Masao
On 2025/05/15 14:39, Daniil Davydov wrote: Hi, I noticed that inside ParsePrepareRecord function we are missing initialization of `nstats` and `nabortstats` fields of xl_xact_parsed_prepare structure: *** (current code in master) memset(parsed, 0, sizeof(*parsed)); parsed->xact_time = xlrec->

[BUG] Skipped initialization of some xl_xact_parsed_prepare fields

2025-05-14 Thread Daniil Davydov
Hi, I noticed that inside ParsePrepareRecord function we are missing initialization of `nstats` and `nabortstats` fields of xl_xact_parsed_prepare structure: *** (current code in master) memset(parsed, 0, sizeof(*parsed)); parsed->xact_time = xlrec->prepared_at; parsed->origin_lsn = xlrec->origin_