Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2021-05-28 Thread Etsuro Fujita
On Fri, May 28, 2021 at 8:25 AM Alvaro Herrera wrote: > On 2019-Mar-15, Etsuro Fujita wrote: > > (2019/03/04 12:10), Etsuro Fujita wrote: > > > (2019/03/02 3:57), Andres Freund wrote: > > > > FWIW, I pushed the EPQ patch, doing this conversion blindly. It'd be > > > > awesome if you'd check that

Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2021-05-27 Thread Alvaro Herrera
On 2019-Mar-15, Etsuro Fujita wrote: > (2019/03/04 12:10), Etsuro Fujita wrote: > > (2019/03/02 3:57), Andres Freund wrote: > > > FWIW, I pushed the EPQ patch, doing this conversion blindly. It'd be > > > awesome if you'd check that it actually works... > > > > I'll start the work later this

Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2019-03-15 Thread Andres Freund
On 2019-03-15 21:58:25 +0900, Etsuro Fujita wrote: > (2019/03/04 12:10), Etsuro Fujita wrote: > > (2019/03/02 3:57), Andres Freund wrote: > > > FWIW, I pushed the EPQ patch, doing this conversion blindly. It'd be > > > awesome if you'd check that it actually works... > > > > I'll start the work

Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2019-03-15 Thread Etsuro Fujita
(2019/03/04 12:10), Etsuro Fujita wrote: (2019/03/02 3:57), Andres Freund wrote: FWIW, I pushed the EPQ patch, doing this conversion blindly. It'd be awesome if you'd check that it actually works... I'll start the work later this week. I think I can post an (initial) report on that next week,

Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2019-03-03 Thread Etsuro Fujita
Hi Andres, (2019/03/02 3:57), Andres Freund wrote: FWIW, I pushed the EPQ patch, doing this conversion blindly. It'd be awesome if you'd check that it actually works... I'll start the work later this week. I think I can post an (initial) report on that next week, maybe. Best regards,

Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2019-03-01 Thread Andres Freund
Hi, On 2019-02-28 10:18:36 -0800, Andres Freund wrote: > On 2019-02-28 18:28:37 +0900, Etsuro Fujita wrote: > > > I'm currently > > > converting the EPQ machinery to slots, and in course of that I (with > > > Horiguchi-san's help), converted RefetchForeignRow to return a slot. But > > > there's

Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2019-02-28 Thread Andres Freund
Hi, Thanks for the quick response. On 2019-02-28 18:28:37 +0900, Etsuro Fujita wrote: > > I'm currently > > converting the EPQ machinery to slots, and in course of that I (with > > Horiguchi-san's help), converted RefetchForeignRow to return a slot. But > > there's currently no in-core user of

Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2019-02-28 Thread Etsuro Fujita
Hi Andres, (2019/02/28 5:33), Andres Freund wrote: On 2015-05-12 14:24:34 -0400, Tom Lane wrote: I did a very basic update of your postgres_fdw patch to test this with, and attach that so that you don't have to repeat the effort. I'm not sure whether we want to try to convert that into

Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2019-02-27 Thread Andres Freund
Hi, On 2015-05-12 14:24:34 -0400, Tom Lane wrote: > I did a very basic update of your postgres_fdw patch to test this with, > and attach that so that you don't have to repeat the effort. I'm not sure > whether we want to try to convert that into something committable. I'm > afraid that the