Re: [HACKERS] wrong t_bits alignment in pageinspect

Maksim Milyutin writes: > Attached a new version of patch with regression test. Looks good, pushed. I also removed one error check from tuple_data_split --- there doesn't seem to be a lot of point in checking that bits_str_len is some multiple of 8 when we're about to

Re: [HACKERS] wrong t_bits alignment in pageinspect

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: tested, passed Documentation:tested, passed Everything is fixed, works properly and I have no new notices. I

Re: [HACKERS] wrong t_bits alignment in pageinspect

Hi! 02.01.2018 12:33, Andrey Borodin wrote: 15 дек. 2017 г., в 18:53, Maksim Milyutin написал(а): I found out the problem in exposing values of t_bits field from heap_page_items function. Probably, this [0] place contains similar bug too? [0]

Re: [HACKERS] wrong t_bits alignment in pageinspect

Hi! > 15 дек. 2017 г., в 18:53, Maksim Milyutin написал(а): > > I found out the problem in exposing values of t_bits field from > heap_page_items function. Probably, this [0] place contains similar bug too? Also, may be macro HeapTupleHeaderGetNatts() will be a little bit

[HACKERS] wrong t_bits alignment in pageinspect

Hi! I found out the problem in exposing values of t_bits field from heap_page_items function. When the number of attributes in table is multiple of eight, t_bits column shows double number of bits in which data fields are included. For example: # create table tbl(f1 int, f2 int, f3 int,