Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall

2021-09-13 Thread Daniel Gustafsson
> On 9 Apr 2021, at 15:34, Nitin Jadhav wrote: > I have reviewed and tested the patch. Following are a few comments. This review has gone unanswered since April, has been WoA since early April and the patch no longer applies. I'm marking this Returned with Feedback, a new version can be

Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall

2021-04-09 Thread Nitin Jadhav
Hi, I have reviewed and tested the patch. Following are a few comments. 1. The main objective of this patch is to get the dump which consists of SQLs related to CREATEDB only. I have tested the patch and it generates a proper dump file. But my concern is, it should execute the code which is

Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall

2021-04-08 Thread Magnus Hagander
On Tue, Mar 30, 2021 at 6:02 PM Michael Banck wrote: > > Hi, > > Am Montag, den 29.03.2021, 17:59 + schrieb Cary Huang: > > I have tried the patch and the new option is able to control the > > contents of pg_dump outputs to include only create db related > > commands. > > Thanks for testing!

Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall

2021-03-30 Thread Michael Banck
Hi, Am Montag, den 29.03.2021, 17:59 + schrieb Cary Huang: > I have tried the patch and the new option is able to control the > contents of pg_dump outputs to include only create db related > commands. Thanks for testing! > I also agree that the option name is a little misleading to the

Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall

2021-03-29 Thread Cary Huang
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Hi I have tried the patch and the new option is able to control

Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall

2021-03-03 Thread Peter Eisentraut
On 01.03.21 11:12, Michael Banck wrote: postgres@kohn:~$ pg_dump --create-only -p 65432 -d test -h /tmp | egrep -v '^($|--|SET)' SELECT pg_catalog.set_config('search_path', '', false); CREATE DATABASE test WITH TEMPLATE = template0 ENCODING = 'UTF8' LOCALE = 'de_DE.UTF-8'; ALTER DATABASE test

[PATCH] Add --create-only option to pg_dump/pg_dumpall

2021-03-01 Thread Michael Banck
17 00:00:00 2001 From: Michael Banck Date: Thu, 31 Dec 2020 16:12:31 +0100 Subject: [PATCH] Add --create-only option to pg_dump/pg_dumpall. This makes pg_dump only output the database creation and assorted commands (notably also ALTER DATABASE [...] SET [...]). If only the database-specific