Re: [PATCH] Add `truncate` option to subscription commands

2021-05-25 Thread Amit Kapila
On Mon, May 24, 2021 at 2:10 PM Bharath Rupireddy wrote: > > On Mon, May 24, 2021 at 11:01 AM Amit Kapila wrote: > > > 1) Whether a table the sync worker is trying to truncate is having any > > > referencing (foreign key) tables on the subscriber? If yes, whether > > > all the referencing tables

Re: [PATCH] Add `truncate` option to subscription commands

2021-05-24 Thread Bharath Rupireddy
On Mon, May 24, 2021 at 11:01 AM Amit Kapila wrote: > > 1) Whether a table the sync worker is trying to truncate is having any > > referencing (foreign key) tables on the subscriber? If yes, whether > > all the referencing tables are present in the list of subscription > > tables (output of

Re: [PATCH] Add `truncate` option to subscription commands

2021-05-23 Thread Amit Kapila
On Sat, May 22, 2021 at 9:58 AM Bharath Rupireddy wrote: > > On Thu, Nov 26, 2020 at 12:16 AM David Christensen wrote: > > > > Hi, > > > > At this time I do not have time to make the necessary changes for this > > commitfest so I am voluntarily withdrawing this patch, but will > > revisit at a

Re: [PATCH] Add `truncate` option to subscription commands

2021-05-21 Thread Bharath Rupireddy
On Thu, Nov 26, 2020 at 12:16 AM David Christensen wrote: > > Hi, > > At this time I do not have time to make the necessary changes for this > commitfest so I am voluntarily withdrawing this patch, but will > revisit at a future time. Hi, This feature looks useful in the sense that it avoids

Re: [PATCH] Add `truncate` option to subscription commands

2020-11-25 Thread David Christensen
Hi, At this time I do not have time to make the necessary changes for this commitfest so I am voluntarily withdrawing this patch, but will revisit at a future time. Best, David On Wed, Oct 28, 2020 at 1:06 PM Rahila Syed wrote: > > Hi David, > > The feature seems useful to me. The code will

Re: [PATCH] Add `truncate` option to subscription commands

2020-10-28 Thread Rahila Syed
Hi David, The feature seems useful to me. The code will need to be refactored due to changes in commit : b05fe7b442 Please see the following comments. 1. Is there a specific reason behind having new relstate for truncate? The current state flow is

Re: [PATCH] Add `truncate` option to subscription commands

2020-10-12 Thread David Christensen
> On Oct 11, 2020, at 10:00 PM, Amit Kapila wrote: > > On Mon, Oct 12, 2020 at 3:44 AM David Christensen wrote: >> >> >> On Oct 11, 2020, at 1:14 PM, Euler Taveira >> wrote: >> >>  >> On Fri, 9 Oct 2020 at 15:54, David Christensen wrote: >>> >>> >>> Enclosed find a patch to add a

Re: [PATCH] Add `truncate` option to subscription commands

2020-10-11 Thread Amit Kapila
On Mon, Oct 12, 2020 at 3:44 AM David Christensen wrote: > > > On Oct 11, 2020, at 1:14 PM, Euler Taveira > wrote: > >  > On Fri, 9 Oct 2020 at 15:54, David Christensen wrote: >> >> >> Enclosed find a patch to add a “truncate” option to subscription commands. >> >> When adding new tables to a

Re: [PATCH] Add `truncate` option to subscription commands

2020-10-11 Thread David Christensen
> On Oct 11, 2020, at 1:14 PM, Euler Taveira > wrote: > >  >> On Fri, 9 Oct 2020 at 15:54, David Christensen wrote: > >> >> Enclosed find a patch to add a “truncate” option to subscription commands. >> >> When adding new tables to a subscription (either via `CREATE SUBSCRIPTION` >> or

Re: [PATCH] Add `truncate` option to subscription commands

2020-10-11 Thread Euler Taveira
On Fri, 9 Oct 2020 at 15:54, David Christensen wrote: > > Enclosed find a patch to add a “truncate” option to subscription commands. > > When adding new tables to a subscription (either via `CREATE SUBSCRIPTION` > or `REFRESH PUBLICATION`), tables on the target which are being newly > subscribed

Re: [PATCH] Add `truncate` option to subscription commands

2020-10-10 Thread David Christensen
> On Oct 10, 2020, at 12:14 AM, Amit Kapila wrote: > > On Sat, Oct 10, 2020 at 12:24 AM David Christensen > wrote: >> >> -hackers, >> >> Enclosed find a patch to add a “truncate” option to subscription commands. >> >> When adding new tables to a subscription (either via `CREATE

Re: [PATCH] Add `truncate` option to subscription commands

2020-10-09 Thread Amit Kapila
On Sat, Oct 10, 2020 at 12:24 AM David Christensen wrote: > > -hackers, > > Enclosed find a patch to add a “truncate” option to subscription commands. > > When adding new tables to a subscription (either via `CREATE SUBSCRIPTION` or > `REFRESH PUBLICATION`), tables on the target which are being

[PATCH] Add `truncate` option to subscription commands

2020-10-09 Thread David Christensen
-hackers, Enclosed find a patch to add a “truncate” option to subscription commands. When adding new tables to a subscription (either via `CREATE SUBSCRIPTION` or `REFRESH PUBLICATION`), tables on the target which are being newly subscribed will be truncated before the data copy step. This