Re: [PATCH] Add a few suppression rules for Valgrind

2018-02-20 Thread Tom Lane
Andres Freund writes: >> I decided to run the code from master branch under Valgrind and >> discovered that it reports some errors. > On my systems I just include a global valgrind suppression file which > includes libc specific things and then the postgres valgrind.supp. I'm > very hesitant to a

Re: [PATCH] Add a few suppression rules for Valgrind

2018-02-20 Thread Andres Freund
Hi, > I decided to run the code from master branch under Valgrind and > discovered that it reports some errors. > > There are multiple reports like this one (seems to be a false alarm): > > ``` > Invalid read of size 16 >at 0x605F488: __wcsnlen_sse4_1 (in /usr/lib/libc-2.26.so) >by 0x604

Re: [PATCH] Add a few suppression rules for Valgrind

2018-02-20 Thread Aleksander Alekseev
Hello hackers, > I suggest a patch that adds corresponding suppression rules to the > src/tools/valgrind.supp file. Though I'm having difficulties > understanding why Valgrind complains on wcstombs and thus I can't > explain why in fact everything is OK (or it's actually not?). Hopefully > someone

[PATCH] Add a few suppression rules for Valgrind

2018-02-20 Thread Aleksander Alekseev
Hello hackers, I decided to run the code from master branch under Valgrind and discovered that it reports some errors. There are multiple reports like this one (seems to be a false alarm): ``` Invalid read of size 16 at 0x605F488: __wcsnlen_sse4_1 (in /usr/lib/libc-2.26.so) by 0x604F5C2: w