Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On 3/4/21 6:28 AM, Ibrar Ahmed wrote: This patch set no longer applies http://cfbot.cputube.org/patch_32_1533.log It has been over a year since the last update to this patch and it no longer applies, so marking Returned with Feedback. Please

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Mon, Aug 3, 2020 at 9:31 PM Wolfgang Walther wrote: > Tom Lane: > > We don't generally act that way in other ALTER commands and I don't see > > a strong argument to start doing so here. [...] > > > > In short, I'm inclined to argue that this variant of ALTER TABLE > > should replace *all*

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Tom Lane: We don't generally act that way in other ALTER commands and I don't see a strong argument to start doing so here. [...] In short, I'm inclined to argue that this variant of ALTER TABLE should replace *all* the fields of the constraint with the same properties it'd have if you'd

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Hi All, I've took some time today to rebase the patch with master. Follows attached. I'm still not sure if the chosen path is the best way. But I'd be glad to follow any directions we all see fit. For now, this patch applies two methods: 1. Changes full constraint definition (which keeps

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Matheus de Oliveira writes: > [ postgresql-alter-constraint.v7.patch ] cfbot says this isn't applying --- looks like a minor conflict in the regression test file. Please rebase. regards, tom lane

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Sorry about the long delay in answering that, I hope to get to a consensus on how to do that feature, which I think it is really valuable. Sending few options and observations bellow... On Sun, Jul 28, 2019 at 2:37 PM Tom Lane wrote: > Matheus de Oliveira writes: > > [

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Matheus, any replies to this? I've marked the patch as Waiting on Author for now. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Matheus de Oliveira writes: > [ postgresql-alter-constraint.v5.patch ] Somebody seems to have marked this Ready For Committer without posting any review, which is not very kosher, but I took a quick look at it anyway. * It's failing to apply, as noted by the cfbot, because somebody added an

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Mon, Jul 1, 2019 at 6:21 AM Thomas Munro wrote: > > Hi Matheus, > > As the commitfest is starting, could you please send a rebased patch? > > Hi all, Glad to start working on that again... Follows the rebased version (at 5925e55498). Thank you all. Best regards, -- Matheus de Oliveira

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Tue, Mar 19, 2019 at 1:04 PM Matheus de Oliveira wrote: > Sorry for the long delay. I've rebased the patch to current master (at > f2004f19ed now), attached as postgresql-alter-constraint.v4.patch. All tests > passed cleanly. Hi Matheus, As the commitfest is starting, could you please send

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Sun, Feb 3, 2019 at 8:28 AM Andres Freund wrote: > > > > > It compiled, worked as expected, but some tests broke executing make > check: > > > > test create_table ... FAILED > > constraints ... FAILED > > inherit ... FAILED > >

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Sun, 14 Oct 2018, Matheus de Oliveira wrote: Updated the last patch so it can apply cleanly on HEAD. Hi Matheus. I applied your patch on top of bb874e30fbf9e85bdb117bad34865a5fae29dbf6. It compiled, worked as expected, but some tests broke executing make check: test create_table

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

> On Sun, Oct 14, 2018 at 8:30 PM Matheus de Oliveira > wrote: > > Updated the last patch so it can apply cleanly on HEAD. > > About the bugfixes, do you think it is better to move to another thread? I think it makes sense, this way discussions on two relatively different topics will not

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Tue, Oct 2, 2018 at 3:40 AM Michael Paquier wrote: > > The last patch set does not apply, so this is moved to next CF, waiting > on author as new status. > Updated the last patch so it can apply cleanly on HEAD. About the bugfixes, do you think it is better to move to another thread? Best

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Mon, Sep 17, 2018 at 12:03:17AM -0300, Matheus de Oliveira wrote: > You are correct. I have made a test that tries all combinations of ALTER > CONSTRAINT ON UPDATE/DELETE ACTION, but it caused a really huge output. I > have changed that to a simple DO block, and still trying all possibilities >

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Hi all. Sorry about the long delay. On Tue, Jul 10, 2018 at 10:17 AM Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > On Wed, Mar 7, 2018 at 11:49 PM, Matheus de Oliveira > wrote: > > > > > > Em 3 de mar de 2018 19:32, "Peter Eisentraut" > > escreveu: > > > > On 2/20/18 10:10,

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Wed, Mar 7, 2018 at 11:49 PM, Matheus de Oliveira wrote: > > > Em 3 de mar de 2018 19:32, "Peter Eisentraut" > escreveu: > > On 2/20/18 10:10, Matheus de Oliveira wrote: >> Besides that, there is a another change in this patch on current ALTER >> CONSTRAINT about deferrability options.

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Matheus de Oliveira wrote: > You think this should be applied to all versions that support ALTER > CONSTRAINT, right? This seems a bug fix to me, so yes. > I can do that, no problem. It'll take awhile though, I'm on a trip and will > be home around March 20th. Please do send at your earliest

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Em 3 de mar de 2018 19:32, "Peter Eisentraut" < peter.eisentr...@2ndquadrant.com> escreveu: On 2/20/18 10:10, Matheus de Oliveira wrote: > Besides that, there is a another change in this patch on current ALTER > CONSTRAINT about deferrability options. Previously, if the user did > ALTER

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Em 2 de mar de 2018 08:15, "Andres Freund" escreveu: Hi, On 2018-02-20 12:10:22 -0300, Matheus de Oliveira wrote: > I attached a patch to add support for changing ON UPDATE/DELETE actions of > a constraint using ALTER TABLE ... ALTER CONSTRAINT. This patch has been

Re: Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Hi Matheus, On 3/3/18 1:32 PM, Peter Eisentraut wrote: > On 2/20/18 10:10, Matheus de Oliveira wrote: >> Besides that, there is a another change in this patch on current ALTER >> CONSTRAINT about deferrability options. Previously, if the user did >> ALTER CONSTRAINT without specifying an option

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On 2/20/18 10:10, Matheus de Oliveira wrote: > Besides that, there is a another change in this patch on current ALTER > CONSTRAINT about deferrability options. Previously, if the user did > ALTER CONSTRAINT without specifying an option on deferrable or > initdeferred, it was implied the default

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

Hi, On 2018-02-20 12:10:22 -0300, Matheus de Oliveira wrote: > I attached a patch to add support for changing ON UPDATE/DELETE actions of > a constraint using ALTER TABLE ... ALTER CONSTRAINT. This patch has been submitted to the last commitfest for v11 and is not a trivial patch. As we don't

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Tue, Feb 20, 2018 at 12:38 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > ... > > I didn't read your patch yet but make sure to register it to the next open > commitfest. > Thanks a lot Fabrízio, I've done that already [1]. Please let me know if I did something wrong,

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On Tue, Feb 20, 2018 at 12:10 PM, Matheus de Oliveira < matioli.math...@gmail.com> wrote: > > Hi all. > > I attached a patch to add support for changing ON UPDATE/DELETE actions of a constraint using ALTER TABLE ... ALTER CONSTRAINT. > > Besides that, there is a another change in this patch on