Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-03-29 Thread Jacob Champion
On Tue, 2022-03-29 at 14:08 +0200, Daniel Gustafsson wrote: > Pushed with a few small tweaks to make it match project style, thanks! Thank you! --Jacob

Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-03-29 Thread Daniel Gustafsson
Pushed with a few small tweaks to make it match project style, thanks! -- Daniel Gustafsson https://vmware.com/

Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-03-28 Thread Daniel Gustafsson
> On 25 Mar 2022, at 23:45, Jacob Champion wrote: > > On Fri, 2022-03-25 at 18:00 -0400, Tom Lane wrote: >> Jacob Champion writes: >>> Do I need to merge my tiny test program into the libpq_pipeline tests? >> >> Doesn't seem worth the trouble to me, notably because you'd >> then have to cope

Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-03-25 Thread Jacob Champion
On Fri, 2022-03-25 at 18:00 -0400, Tom Lane wrote: > Jacob Champion writes: > > Do I need to merge my tiny test program into the libpq_pipeline tests? > > Doesn't seem worth the trouble to me, notably because you'd > then have to cope with non-SSL builds too. Fine by me. v5 moves the docs out

Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-03-25 Thread Tom Lane
Jacob Champion writes: > Do I need to merge my tiny test program into the libpq_pipeline tests? Doesn't seem worth the trouble to me, notably because you'd then have to cope with non-SSL builds too. regards, tom lane

Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-03-25 Thread Daniel Gustafsson
> On 25 Mar 2022, at 22:25, Jacob Champion wrote: > On Fri, 2022-03-25 at 15:32 -0400, Robert Haas wrote: >> This seems totally reasonable. However, I think it should update the >> documentation somehow. > > Done in v4. I would prefer to not introduce a for this, I think adding it as a under

Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-03-25 Thread Jacob Champion
On Fri, 2022-03-25 at 15:32 -0400, Robert Haas wrote: > On Mon, Feb 28, 2022 at 3:21 PM Jacob Champion wrote: > > v3 rebases over Andres' changes and actually adds the Perl driver that > > I missed the git-add for. > > This seems totally reasonable. However, I think it should update the >

Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-03-25 Thread Robert Haas
On Mon, Feb 28, 2022 at 3:21 PM Jacob Champion wrote: > v3 rebases over Andres' changes and actually adds the Perl driver that > I missed the git-add for. This seems totally reasonable. However, I think it should update the documentation somehow. -- Robert Haas EDB: http://www.enterprisedb.com

Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-02-28 Thread Jacob Champion
On Wed, 2022-02-23 at 23:20 +, Jacob Champion wrote: > First stab in v2-0002. Though I see that Andres is overhauling the > tests in this folder today [1], so I'll need to watch that thread. :) v3 rebases over Andres' changes and actually adds the Perl driver that I missed the git-add for.

Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-02-23 Thread Jacob Champion
On Wed, 2022-02-23 at 14:11 -0500, Andrew Dunstan wrote: > On 2/23/22 13:38, Jacob Champion wrote: > > > > If this looks good, I'm not sure how best to test it in the regression > > suite. I see that libpq has an installcheck recipe that compiles a test > > executable for URI parsing; should I

Re: [PATCH] Enable SSL library detection via PQsslAttribute

2022-02-23 Thread Andrew Dunstan
On 2/23/22 13:38, Jacob Champion wrote: > Hello, > > As part of the NSS work it came up [1] that clients don't have a good > way to ask libpq what SSL library it was compiled with, unless they > already have a connection pointer so that they can call > PQsslAttribute(conn, "library"). This poses

[PATCH] Enable SSL library detection via PQsslAttribute

2022-02-23 Thread Jacob Champion
Hello, As part of the NSS work it came up [1] that clients don't have a good way to ask libpq what SSL library it was compiled with, unless they already have a connection pointer so that they can call PQsslAttribute(conn, "library"). This poses a chicken-and-egg problem: with the NSS proposal,