Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-13 Thread Fujii Masao
On 2021/01/14 14:38, Masahiko Sawada wrote: On Wed, Jan 13, 2021 at 1:55 PM Fujii Masao wrote: On Tue, Jan 12, 2021 at 11:09 AM Fujii Masao wrote: On Tue, Jan 12, 2021 at 10:00 AM Masahiko Sawada wrote: On Mon, Jan 11, 2021 at 11:00 PM Peter Eisentraut wrote: On 2021-01-05 10:56,

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-13 Thread Masahiko Sawada
On Wed, Jan 13, 2021 at 1:55 PM Fujii Masao wrote: > > On Tue, Jan 12, 2021 at 11:09 AM Fujii Masao wrote: > > > > On Tue, Jan 12, 2021 at 10:00 AM Masahiko Sawada > > wrote: > > > > > > On Mon, Jan 11, 2021 at 11:00 PM Peter Eisentraut > > > wrote: > > > > > > > > On 2021-01-05 10:56,

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-12 Thread Fujii Masao
On Tue, Jan 12, 2021 at 11:09 AM Fujii Masao wrote: > > On Tue, Jan 12, 2021 at 10:00 AM Masahiko Sawada > wrote: > > > > On Mon, Jan 11, 2021 at 11:00 PM Peter Eisentraut > > wrote: > > > > > > On 2021-01-05 10:56, Masahiko Sawada wrote: > > > > BTW according to the documentation, the options

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-11 Thread Fujii Masao
On Tue, Jan 12, 2021 at 10:00 AM Masahiko Sawada wrote: > > On Mon, Jan 11, 2021 at 11:00 PM Peter Eisentraut > wrote: > > > > On 2021-01-05 10:56, Masahiko Sawada wrote: > > > BTW according to the documentation, the options of DECLARE statement > > > (BINARY, INSENSITIVE, SCROLL, and NO SCROLL)

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-11 Thread Masahiko Sawada
On Mon, Jan 11, 2021 at 11:00 PM Peter Eisentraut wrote: > > On 2021-01-05 10:56, Masahiko Sawada wrote: > > BTW according to the documentation, the options of DECLARE statement > > (BINARY, INSENSITIVE, SCROLL, and NO SCROLL) are order-sensitive. > > > > DECLARE name [ BINARY ] [ INSENSITIVE ] [

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-11 Thread Peter Eisentraut
On 2021-01-05 10:56, Masahiko Sawada wrote: BTW according to the documentation, the options of DECLARE statement (BINARY, INSENSITIVE, SCROLL, and NO SCROLL) are order-sensitive. DECLARE name [ BINARY ] [ INSENSITIVE ] [ [ NO ] SCROLL ] CURSOR [ { WITH | WITHOUT } HOLD ] FOR query But I

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-10 Thread Masahiko Sawada
On Thu, Jan 7, 2021 at 9:32 PM Fujii Masao wrote: > > > > On 2021/01/07 17:28, shinya11.k...@nttdata.com wrote: > >> On Thu, Jan 7, 2021 at 1:30 PM Fujii Masao > >> wrote: > >>> > >>> On 2021/01/07 12:42, Masahiko Sawada wrote: > On Thu, Jan 7, 2021 at 10:59 AM Fujii Masao > wrote:

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-07 Thread Fujii Masao
On 2021/01/07 17:28, shinya11.k...@nttdata.com wrote: On Thu, Jan 7, 2021 at 1:30 PM Fujii Masao wrote: On 2021/01/07 12:42, Masahiko Sawada wrote: On Thu, Jan 7, 2021 at 10:59 AM Fujii Masao wrote: On 2021/01/07 10:01, Masahiko Sawada wrote: On Wed, Jan 6, 2021 at 3:37 PM wrote:

RE: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-07 Thread Shinya11.Kato
>On Thu, Jan 7, 2021 at 1:30 PM Fujii Masao > wrote: >> >> On 2021/01/07 12:42, Masahiko Sawada wrote: >> > On Thu, Jan 7, 2021 at 10:59 AM Fujii Masao >> > wrote: >> >> >> >> On 2021/01/07 10:01, Masahiko Sawada wrote: >> >>> On Wed, Jan 6, 2021 at 3:37 PM >> >>> wrote: >> >> >

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-06 Thread Masahiko Sawada
On Thu, Jan 7, 2021 at 1:30 PM Fujii Masao wrote: > > > > On 2021/01/07 12:42, Masahiko Sawada wrote: > > On Thu, Jan 7, 2021 at 10:59 AM Fujii Masao > > wrote: > >> > >> > >> > >> On 2021/01/07 10:01, Masahiko Sawada wrote: > >>> On Wed, Jan 6, 2021 at 3:37 PM wrote: > > > +#define

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-06 Thread Fujii Masao
On 2021/01/07 12:42, Masahiko Sawada wrote: On Thu, Jan 7, 2021 at 10:59 AM Fujii Masao wrote: On 2021/01/07 10:01, Masahiko Sawada wrote: On Wed, Jan 6, 2021 at 3:37 PM wrote: +#define Query_for_list_of_cursors \ +" SELECT name FROM pg_cursors"\ This query should be the following?

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-06 Thread Masahiko Sawada
On Thu, Jan 7, 2021 at 10:59 AM Fujii Masao wrote: > > > > On 2021/01/07 10:01, Masahiko Sawada wrote: > > On Wed, Jan 6, 2021 at 3:37 PM wrote: > >> > >>> +#define Query_for_list_of_cursors \ > >>> +" SELECT name FROM pg_cursors"\ > >>> > >>> This query should be the following? > >>> > >>> "

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-06 Thread Fujii Masao
On 2021/01/07 10:01, Masahiko Sawada wrote: On Wed, Jan 6, 2021 at 3:37 PM wrote: +#define Query_for_list_of_cursors \ +" SELECT name FROM pg_cursors"\ This query should be the following? " SELECT pg_catalog.quote_ident(name) "\ " FROM pg_catalog.pg_cursors "\ " WHERE

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-06 Thread Masahiko Sawada
On Wed, Jan 6, 2021 at 3:37 PM wrote: > > >+#define Query_for_list_of_cursors \ > >+" SELECT name FROM pg_cursors"\ > > > >This query should be the following? > > > >" SELECT pg_catalog.quote_ident(name) "\ > >" FROM pg_catalog.pg_cursors "\ > >" WHERE

RE: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-05 Thread Shinya11.Kato
>+#define Query_for_list_of_cursors \ >+" SELECT name FROM pg_cursors"\ > >This query should be the following? > >" SELECT pg_catalog.quote_ident(name) "\ >" FROM pg_catalog.pg_cursors "\ >" WHERE substring(pg_catalog.quote_ident(name),1,%d)='%s'" > >+/* CLOSE */ >+ else if

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-05 Thread Fujii Masao
On 2021/01/06 11:13, Masahiko Sawada wrote: On Tue, Jan 5, 2021 at 6:08 PM Fujii Masao wrote: + COMPLETE_WITH_QUERY(Query_for_list_of_cursors + " UNION SELECT 'ABSOLUTE'" +

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-05 Thread Masahiko Sawada
On Tue, Jan 5, 2021 at 6:08 PM Fujii Masao wrote: > > > + COMPLETE_WITH_QUERY(Query_for_list_of_cursors > + " UNION SELECT > 'ABSOLUTE'" > + " UNION SELECT > 'BACKWARD'" > +

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-05 Thread Masahiko Sawada
On Tue, Jan 5, 2021 at 3:03 PM wrote: > > Thank you for your review! > I fixed some codes and attach a new patch. Thank you for updating the patch! > > >When I applied the patch, I got the following whitespace warnings: > > > >$ git apply ~/patches/fix_tab_complete_close_fetch_move.patch >

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-05 Thread Fujii Masao
On 2021/01/05 15:02, shinya11.k...@nttdata.com wrote: Thank you for your review! I fixed some codes and attach a new patch. Thanks for updating the patch! +#define Query_for_list_of_cursors \ +" SELECT name FROM pg_cursors"\ This query should be the following? " SELECT

RE: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-04 Thread Shinya11.Kato
Thank you for your review! I fixed some codes and attach a new patch. >When I applied the patch, I got the following whitespace warnings: > >$ git apply ~/patches/fix_tab_complete_close_fetch_move.patch >/home/masahiko/patches/fix_tab_complete_close_fetch_move.patch:40: >indent with spaces. >

Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2021-01-04 Thread Masahiko Sawada
On Wed, Dec 9, 2020 at 12:59 PM wrote: > > Hi! > > > > I created a patch for improving CLOSE, FETCH, MOVE tab completion. > > Specifically, I add CLOSE, FETCH, MOVE tab completion for completing a > predefined cursors. > Thank you for the patch! When I applied the patch, I got the following

[PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion

2020-12-08 Thread Shinya11.Kato
Hi! I created a patch for improving CLOSE, FETCH, MOVE tab completion. Specifically, I add CLOSE, FETCH, MOVE tab completion for completing a predefined cursors. Regards, Shinya Kato fix_tab_complete_close_fetch_move.patch Description: fix_tab_complete_close_fetch_move.patch