Re: [PATCH] Little refactoring of portalcmds.c

2025-10-27 Thread wenhui qiu
Hi Aleksander Alekseev > The proposed patch places some repetitive code in a helper function. > The value of this change is arguably not that high but it makes the > code a bit neater IMO. I agree with your suggestion to refactor the duplicated code into a function. Thanks On Mon, Oct 27, 2025 a

Re: [PATCH] Little refactoring of portalcmds.c

2025-10-26 Thread Quan Zongliang
On 10/8/25 10:02 PM, Aleksander Alekseev wrote: Hi, The proposed patch places some repetitive code in a helper function. The value of this change is arguably not that high but it makes the code a bit neater IMO. It also reduces the ease of reading the code. Just add a function for a single

[PATCH] Little refactoring of portalcmds.c

2025-10-18 Thread Aleksander Alekseev
Hi, The proposed patch places some repetitive code in a helper function. The value of this change is arguably not that high but it makes the code a bit neater IMO. -- Best regards, Aleksander Alekseev From af051406d09dedf87bde8802d7f7dea0ab4458ec Mon Sep 17 00:00:00 2001 From: Aleksander Aleksee