Re: [PATCH] More docs on what to do and not do in extension code

> On 30 Aug 2021, at 04:20, Craig Ringer wrote: > > On Tue, 29 Jun 2021 at 13:30, Craig Ringer > wrote: > Laurenz, > > Thanks for your comments. Sorry it's taken me so long to get back to you. > Commenting inline below on anything I think needs comment;

Re: [PATCH] More docs on what to do and not do in extension code

On Tue, 29 Jun 2021 at 13:30, Craig Ringer wrote: > Laurenz, > > Thanks for your comments. Sorry it's taken me so long to get back to you. > Commenting inline below on anything I think needs comment; other proposed > changes look good. > I'm not going to get back to this anytime soon. If

Re: [PATCH] More docs on what to do and not do in extension code

Laurenz, Thanks for your comments. Sorry it's taken me so long to get back to you. Commenting inline below on anything I think needs comment; other proposed changes look good. On Sun, 30 May 2021 at 19:20, Laurenz Albe wrote: > + always use

Re: [PATCH] More docs on what to do and not do in extension code

On Mon, 2021-01-18 at 15:56 +0800, Craig Ringer wrote: > The attached patch expands the xfunc docs and bgworker docs a little, > providing a starting point for developers > to learn how to do some common tasks the Postgres Way. I like these changes! Here is a review: + + See for

Re: [PATCH] More docs on what to do and not do in extension code

On Fri, 26 Mar 2021 at 06:15, Bruce Momjian wrote: > On Thu, Mar 25, 2021 at 08:49:44AM -0400, David Steele wrote: > > On 1/22/21 1:36 AM, Craig Ringer wrote: > > > > > > Would you mind attaching a revised version of the patch with your > edits? > > > Otherwise I'll go and merge them in once

Re: [PATCH] More docs on what to do and not do in extension code

On Thu, Mar 25, 2021 at 08:49:44AM -0400, David Steele wrote: > On 1/22/21 1:36 AM, Craig Ringer wrote: > > > > Would you mind attaching a revised version of the patch with your edits? > > Otherwise I'll go and merge them in once you've had your say on my > > comments inline below. > > Bharath,

Re: [PATCH] More docs on what to do and not do in extension code

On 1/22/21 1:36 AM, Craig Ringer wrote: Would you mind attaching a revised version of the patch with your edits? Otherwise I'll go and merge them in once you've had your say on my comments inline below. Bharath, do the revisions in [1] look OK to you? Bruce, Robert, can I have an opinion

Re: [PATCH] More docs on what to do and not do in extension code

Hi Thanks so much for reading over this! Would you mind attaching a revised version of the patch with your edits? Otherwise I'll go and merge them in once you've had your say on my comments inline below. Bruce, Robert, can I have an opinion from you on how best to locate and structure these

Re: [PATCH] More docs on what to do and not do in extension code

On Mon, Jan 18, 2021 at 1:27 PM Craig Ringer wrote: > Hi folks > > The attached patch expands the xfunc docs and bgworker docs a little, > providing a starting point for developers to learn how to do some common > tasks the Postgres Way. > > It mentions in brief these topics: > > * longjmp()

[PATCH] More docs on what to do and not do in extension code

Hi folks The attached patch expands the xfunc docs and bgworker docs a little, providing a starting point for developers to learn how to do some common tasks the Postgres Way. It mentions in brief these topics: * longjmp() based exception handling with elog(ERROR), PG_CATCH() and PG_RE_THROW()