Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

On Thu, 19 Mar 2020 at 18:47, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2020-03-15 02:28, Craig Ringer wrote: > > On Fri, 13 Mar 2020 at 15:04, Andres Freund > > wrote: > > > > On 2020-03-13 14:08:12 +0800, Craig Ringer wrote: > > > The

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

On 2020-03-15 02:28, Craig Ringer wrote: On Fri, 13 Mar 2020 at 15:04, Andres Freund > wrote: On 2020-03-13 14:08:12 +0800, Craig Ringer wrote: > The alternative would be to detect a missing clang and emit a much more > informative error than the

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

On Fri, 13 Mar 2020 at 15:04, Andres Freund wrote: > On 2020-03-13 14:08:12 +0800, Craig Ringer wrote: > > The alternative would be to detect a missing clang and emit a much more > > informative error than the current one that explicitly suggests retrying > > with > > > > make with_llvm=no >

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

On 2020-03-13 14:08:12 +0800, Craig Ringer wrote: > The alternative would be to detect a missing clang and emit a much more > informative error than the current one that explicitly suggests retrying > with > > make with_llvm=no > > or setting with_llvm=no in the environment. That, that,

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

On Fri, 13 Mar 2020 at 04:35, Andres Freund wrote: > > IMO only if the packager screwed up. The dependencies of the package > that includes pgxs, headers should have the dependencies to llvm. Which > e.g. debian's does: > Yes, I agree that the underlying issue is mainly with packaging. This

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

Sorry, that mail is almost duplicate with another one, which was sent by accident. At Thu, 12 Mar 2020 14:59:44 +0900 (JST), Kyotaro Horiguchi wrote in > +1 for requiring such options for the same reason. The current patch > disables LLVM for the enviroment where clang is installed but ccache

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

At Wed, 11 Mar 2020 12:43:22 -0700, Andres Freund wrote in > Hi, > > On 2020-03-11 11:25:28 +0800, Craig Ringer wrote: > > I propose that per the attached patch PGXS should simply skip adding > > the automatic dependency for .bc files if clang cannot be found. > > Extensions may still choose to

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

Hi, On 2020-03-12 17:22:09 -0300, Euler Taveira wrote: > On Thu, 12 Mar 2020 at 16:25, Andres Freund wrote: > > > Hi, > > > > On 2020-03-12 14:08:31 +0800, Craig Ringer wrote: > > > > > > I thought about that at first, but that'll only benefit people who're > > > hand-compiling things, and it's

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

On Thu, 12 Mar 2020 at 16:25, Andres Freund wrote: > Hi, > > On 2020-03-12 14:08:31 +0800, Craig Ringer wrote: > > > > I thought about that at first, but that'll only benefit people who're > > hand-compiling things, and it's already possible with > > > > make with_llvm=no ... > > Well, the

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

Hi, On 2020-03-12 14:08:31 +0800, Craig Ringer wrote: > On Thu, 12 Mar 2020 at 03:43, Andres Freund wrote: > > > On 2020-03-11 11:25:28 +0800, Craig Ringer wrote: > > > I propose that per the attached patch PGXS should simply skip adding > > > the automatic dependency for .bc files if clang

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

At Thu, 12 Mar 2020 14:08:31 +0800, Craig Ringer wrote in > On Thu, 12 Mar 2020 at 03:43, Andres Freund wrote: > > > On 2020-03-11 11:25:28 +0800, Craig Ringer wrote: > > > I propose that per the attached patch PGXS should simply skip adding > > > the automatic dependency for .bc files if

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

On Thu, 12 Mar 2020 at 03:43, Andres Freund wrote: > On 2020-03-11 11:25:28 +0800, Craig Ringer wrote: > > I propose that per the attached patch PGXS should simply skip adding > > the automatic dependency for .bc files if clang cannot be found. > > Extensions may still choose to explicitly

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

Hi, On 2020-03-11 11:25:28 +0800, Craig Ringer wrote: > I propose that per the attached patch PGXS should simply skip adding > the automatic dependency for .bc files if clang cannot be found. > Extensions may still choose to explicitly declare the rule in their > own Makefile if they want to

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

On Wed, 11 Mar 2020 at 13:47, Pavel Stehule wrote: > > st 11. 3. 2020 v 6:43 odesílatel Julien Rouhaud napsal: >> >> Le mer. 11 mars 2020 à 05:28, Laurenz Albe a >> écrit : >>> >>> On Wed, 2020-03-11 at 11:25 +0800, Craig Ringer wrote: >>> > Short version: Currently if the server is built with

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

st 11. 3. 2020 v 6:43 odesílatel Julien Rouhaud napsal: > Le mer. 11 mars 2020 à 05:28, Laurenz Albe a > écrit : > >> On Wed, 2020-03-11 at 11:25 +0800, Craig Ringer wrote: >> > Short version: Currently if the server is built with --with-llvm the >> > -devel packages must depend on clang for

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

Le mer. 11 mars 2020 à 05:28, Laurenz Albe a écrit : > On Wed, 2020-03-11 at 11:25 +0800, Craig Ringer wrote: > > Short version: Currently if the server is built with --with-llvm the > > -devel packages must depend on clang for PGXS to work, even though > > llvm is otherwise optional. This is a

Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

On Wed, 2020-03-11 at 11:25 +0800, Craig Ringer wrote: > Short version: Currently if the server is built with --with-llvm the > -devel packages must depend on clang for PGXS to work, even though > llvm is otherwise optional. This is a particular problem on older > platforms where 3rd party LLVM

[PATCH] Skip llvm bytecode generation if LLVM is missing

Short version: Currently if the server is built with --with-llvm the -devel packages must depend on clang for PGXS to work, even though llvm is otherwise optional. This is a particular problem on older platforms where 3rd party LLVM may be required to build the server's llvmjit support. Work