Re: [PATCH] Tab completion for ALTER TABLE … ADD …

2021-08-31 Thread Dagfinn Ilmari Mannsåker
On Tue, 31 Aug 2021, at 04:20, Michael Paquier wrote: > On Mon, Aug 30, 2021 at 02:38:19PM +0100, Dagfinn Ilmari Mannsåker wrote: > > That was because I forgot to exclude all the other object types that can > > come after ADD. Attached is a patch that does that. I also moved it > > right next to

Re: [PATCH] Tab completion for ALTER TABLE … ADD …

2021-08-30 Thread Michael Paquier
On Mon, Aug 30, 2021 at 02:38:19PM +0100, Dagfinn Ilmari Mannsåker wrote: > That was because I forgot to exclude all the other object types that can > come after ADD. Attached is a patch that does that. I also moved it > right next to the ALTER TABLE … ADD completion, and added a comment to >

Re: [PATCH] Tab completion for ALTER TABLE … ADD …

2021-08-30 Thread Dagfinn Ilmari Mannsåker
Michael Paquier writes: > On Fri, Aug 27, 2021 at 11:52:33AM +0100, Dagfinn Ilmari Mannsåker wrote: >> That was easy enough to add (just a bit of extra fiddling to handle >> COLUMN being optional), done in the attached v2 patch. > > This part was a bit misleading, as it would recommend a list of

Re: [PATCH] Tab completion for ALTER TABLE … ADD …

2021-08-29 Thread Michael Paquier
On Fri, Aug 27, 2021 at 11:52:33AM +0100, Dagfinn Ilmari Mannsåker wrote: > That was easy enough to add (just a bit of extra fiddling to handle > COLUMN being optional), done in the attached v2 patch. This part was a bit misleading, as it would recommend a list of types when specifying just ADD

Re: [PATCH] Tab completion for ALTER TABLE … ADD …

2021-08-27 Thread Dagfinn Ilmari Mannsåker
Michael Paquier writes: > On Tue, Aug 03, 2021 at 12:48:38PM +0100, Dagfinn Ilmari Mannsåker wrote: >> The other day I noticed that there's no tab completion after ALTER TABLE >> … ADD, so here's a patch. In addition to COLUMN and all the table >> constraint types, it also completes with the

Re: [PATCH] Tab completion for ALTER TABLE … ADD …

2021-08-26 Thread Michael Paquier
On Tue, Aug 03, 2021 at 12:48:38PM +0100, Dagfinn Ilmari Mannsåker wrote: > The other day I noticed that there's no tab completion after ALTER TABLE > … ADD, so here's a patch. In addition to COLUMN and all the table > constraint types, it also completes with the list of unique indexes on > the

Re: [PATCH] Tab completion for ALTER TABLE … ADD …

2021-08-07 Thread Dagfinn Ilmari Mannsåker
ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > Hi Hackers, > > The other day I noticed that there's no tab completion after ALTER TABLE > … ADD, so here's a patch. In addition to COLUMN and all the table > constraint types, it also completes with the list of unique indexes on > the table

[PATCH] Tab completion for ALTER TABLE … ADD …

2021-08-03 Thread Dagfinn Ilmari Mannsåker
Hi Hackers, The other day I noticed that there's no tab completion after ALTER TABLE … ADD, so here's a patch. In addition to COLUMN and all the table constraint types, it also completes with the list of unique indexes on the table after ALTER TABLE … ADD … USING INDEX. - ilmari >From