Re: [PATCH] Tab completion for SET COMPRESSION

2022-09-10 Thread Michael Paquier
On Thu, Sep 08, 2022 at 04:40:32PM +0900, Shinya Kato wrote: > Thanks! I marked it as ready for committer. I thought that there was a gotcha in this area for composite types, but on second look it looks that I was wrong. Hence, applied. -- Michael signature.asc Description: PGP signature

Re: [PATCH] Tab completion for SET COMPRESSION

2022-09-08 Thread Shinya Kato
On 2022-09-06 20:57, Aleksander Alekseev wrote: Hi Shinya, A minor modification has been made so that the composite type is also completed after "ALTER TABLE OF". LGTM. Here is v3 created with `git format-path`. Unlike v2 it also includes the commit message. Thanks! I marked it as ready fo

Re: [PATCH] Tab completion for SET COMPRESSION

2022-09-06 Thread Aleksander Alekseev
Hi Shinya, > A minor modification has been made so that the composite type is also > completed after "ALTER TABLE OF". LGTM. Here is v3 created with `git format-path`. Unlike v2 it also includes the commit message. -- Best regards, Aleksander Alekseev v3-0001-Add-psql-tab-compression-for-OF-

Re: [PATCH] Tab completion for SET COMPRESSION

2022-09-06 Thread Shinya Kato
On 2022-09-06 17:28, Aleksander Alekseev wrote: In addition, why not take this opportunity to create a tab completion for "ALTER TABLE OF " and "ALTER TABLE NOT OF"? Thanks for reviewing, Shinya. Let's fix this too. The patch is attached. Thanks for the new patch! A minor modification ha

Re: [PATCH] Tab completion for SET COMPRESSION

2022-09-06 Thread Aleksander Alekseev
Hi hackers, > Right. That looks fine to me, so applied. Thanks, Michael. > In addition, why not take this opportunity to create a tab completion for > "ALTER TABLE OF " and "ALTER TABLE NOT OF"? Thanks for reviewing, Shinya. Let's fix this too. The patch is attached. -- Best regards, Aleks

Re: [PATCH] Tab completion for SET COMPRESSION

2022-09-05 Thread Michael Paquier
On Tue, Sep 06, 2022 at 09:54:53AM +0900, Shinya Kato wrote: > In addition, why not take this opportunity to create a tab completion for > "ALTER TABLE OF " and "ALTER TABLE NOT OF"? Right. That looks fine to me, so applied. -- Michael signature.asc Description: PGP signature

Re: [PATCH] Tab completion for SET COMPRESSION

2022-09-05 Thread Shinya Kato
On 2022-08-22 21:48, Aleksander Alekseev wrote: Hi hackers, The proposed patch adds the missing tab completion for 'ALTER TABLE ... SET COMPRESSION ...' syntax. Thanks, LGTM. In addition, why not take this opportunity to create a tab completion for "ALTER TABLE OF " and "ALTER TABLE NOT OF"

[PATCH] Tab completion for SET COMPRESSION

2022-08-22 Thread Aleksander Alekseev
Hi hackers, The proposed patch adds the missing tab completion for 'ALTER TABLE ... SET COMPRESSION ...' syntax. -- Best regards, Aleksander Alekseev v1-0001-Tab-completion-for-SET-COMPRESSION.patch Description: Binary data