Re: [PATCH] Write Notifications Through WAL

2025-11-03 Thread Rishu Bagga
Hi, apologies for the delay, attached a new patch addressing the concerns, as well as enabling a standby to listen and receive notifications from the primary. On Fri, Oct 17, 2025 at 6:33 AM Arseniy Mukhin wrote: > > Good catch, I've fixed this in the new patch. > > Hmmm, looks like we still hav

[PATCH] Write Notifications Through WAL

2025-10-18 Thread Rishu Bagga
Hello all,

creating a new thread here in continuation of [1], as the patch has changed direction significantly from the subject there. TLDR: 
The attached patch here aims to increase performance of the NOTIFY codepath, in the case of concurrent notifying transactions, by eliminating the need for

Re: [PATCH] Write Notifications Through WAL

2025-10-17 Thread Rishu Bagga
Thank you Arseniy for the thoughtful and detailed feedback, I have addressed the concerns in the new patch. On Wed, Oct 8, 2025 at 3:07 AM Arseniy Mukhin wrote: > Yes, we hold the lock while we are writing the commit record to wal, > but other transactions don't see our transaction as committed

Re: [PATCH] Write Notifications Through WAL

2025-10-17 Thread Arseniy Mukhin
Hi, Thank you for the new patch version! On Tue, Oct 14, 2025 at 12:14 AM Rishu Bagga wrote: > > Thank you Arseniy for the thoughtful and detailed feedback, I have > addressed the concerns in the new patch. > > On Wed, Oct 8, 2025 at 3:07 AM Arseniy Mukhin > wrote: > > > Yes, we hold the lock w

Re: [PATCH] Write Notifications Through WAL

2025-10-08 Thread Arseniy Mukhin
Hi, On Thu, Sep 25, 2025 at 4:12 AM Rishu Bagga wrote: > > Hello all,

creating a new thread here in continuation of [1], as the patch > has changed direction significantly from the subject there. There are a lot of improvements, thank you for the new version! I'm still in the process of reviewi

Re: [PATCH] Write Notifications Through WAL

2025-09-25 Thread Rishu Bagga
Attached a new patch that resolves failing tests reported by cfbot. There were still some failing tests on cfbot - related to expecting new pages to be zeroed in the notify queue, but since we only write a single compact notify record in a transaction, regardless of the size or number of notificat