On Wed, Feb 14, 2024 at 01:45:31PM -0500, Tom Lane wrote:
> "Pavlo Golub" writes:
>> Oh, thanks! I forgot, indeed, to update docs and catalog version! My
>> bad!
>
> Docs, yes, but don't include catversion bumps in submitted patches.
> They'll just lead to merge problems when somebody else
On Wed, Feb 14, 2024, 19:45 Tom Lane wrote:
> "Pavlo Golub" writes:
> > Oh, thanks! I forgot, indeed, to update docs and catalog version! My
> > bad!
>
> Docs, yes, but don't include catversion bumps in submitted patches.
> They'll just lead to merge problems when somebody else changes the
>
"Pavlo Golub" writes:
> Oh, thanks! I forgot, indeed, to update docs and catalog version! My
> bad!
Docs, yes, but don't include catversion bumps in submitted patches.
They'll just lead to merge problems when somebody else changes the
current catversion. We rely on the committer to remember to
On Mon, Feb 12, 2024 at 09:49:45AM -0600, Nathan Bossart wrote:
Okay. I'll plan on committing this in the next few days.
Here is what I have staged for commit.
Oh, thanks! I forgot, indeed, to update docs and catalog version! My
bad!
In my defense, I was trying to find tests but I
On Wed, Feb 14, 2024 at 08:59:06AM +0100, Daniel Gustafsson wrote:
> LGTM.
Committed.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
> On 13 Feb 2024, at 22:29, Nathan Bossart wrote:
>
> On Mon, Feb 12, 2024 at 09:49:45AM -0600, Nathan Bossart wrote:
>> Okay. I'll plan on committing this in the next few days.
>
> Here is what I have staged for commit.
LGTM.
--
Daniel Gustafsson
On Mon, Feb 12, 2024 at 09:49:45AM -0600, Nathan Bossart wrote:
> Okay. I'll plan on committing this in the next few days.
Here is what I have staged for commit.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From bfe542c5d7b3c981e75ac6551abb34fbdf646eea Mon Sep 17 00:00:00
On Mon, Feb 12, 2024 at 12:27:54PM +, Pavlo Golub wrote:
>> Are there any other
>> functions that pg_monitor ought to have privileges for?
>>
> Not that I'm aware of at the moment. This one was found by chance.
Okay. I'll plan on committing this in the next few days.
--
Nathan Bossart
Are there any other
functions that pg_monitor ought to have privileges for?
Not that I'm aware of at the moment. This one was found by chance.
Kind regards,
Pavlo Golub
On Fri, Feb 09, 2024 at 04:01:58PM +0100, Pavlo Golub wrote:
> The patch attached fixes an oversight/inconsistency of disallowing the
> pg_monitor system role to execute pg_current_logfile([text]).
I think this is reasonable. We allow pg_monitor to execute functions like
pg_ls_logdir(), so it
Hello,
The patch attached fixes an oversight/inconsistency of disallowing the
pg_monitor system role to execute pg_current_logfile([text]).
pgwatch3=# create user joe;
CREATE ROLE
pgwatch3=# set role joe;
SET
pgwatch3=> select pg_current_logfile();
ERROR: permission denied for function
11 matches
Mail list logo
