Re: [PATCH] libpq improvements and fixes

2020-02-14 Thread Ranier Vilela
Em sex., 14 de fev. de 2020 às 03:13, Michael Paquier escreveu: > On Thu, Feb 13, 2020 at 02:22:36PM -0300, Ranier Vilela wrote: > > I just kept it, even if I duplicated the error message, the style was > kept > > and in my opinion it is much more coherent and readable. > > But your solution is a

Re: [PATCH] libpq improvements and fixes

2020-02-13 Thread Michael Paquier
On Thu, Feb 13, 2020 at 02:22:36PM -0300, Ranier Vilela wrote: > I just kept it, even if I duplicated the error message, the style was kept > and in my opinion it is much more coherent and readable. > But your solution is also good, and yes, it is worth it, because even with > small benefits, the c

Re: [PATCH] libpq improvements and fixes

2020-02-13 Thread Ranier Vilela
Em qua., 12 de fev. de 2020 às 22:25, Tom Lane escreveu: > Ranier Vilela writes: > > Coverity detected a dead code in the src / interfaces / libpq / fe-auth.c > > file, to correct it, a simplification was made and the oom_error goto was > > removed, since it is clearly redundant and its presence

Re: [PATCH] libpq improvements and fixes

2020-02-12 Thread Tom Lane
Ranier Vilela writes: > Coverity detected a dead code in the src / interfaces / libpq / fe-auth.c > file, to correct it, a simplification was made and the oom_error goto was > removed, since it is clearly redundant and its presence can be confusing. I'm kind of disinclined to let Coverity dictate

[PATCH] libpq improvements and fixes

2020-02-12 Thread Ranier Vilela
Hi, Coverity detected a dead code in the src / interfaces / libpq / fe-auth.c file, to correct it, a simplification was made and the oom_error goto was removed, since it is clearly redundant and its presence can be confusing. The second part of the patch refers to the file src / interfaces / libpq