Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-02-23 Thread Amit Kapila
On Mon, Feb 22, 2021 at 6:08 PM Euler Taveira wrote: > > On Sat, Feb 20, 2021, at 7:33 AM, Amit Kapila wrote: > > I have used a bit of different wording here to make things clear. > > Let me know what you think of the attached? > > WFM. > Thanks, Pushed! -- With Regards, Amit Kapila.

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-02-22 Thread Euler Taveira
On Sat, Feb 20, 2021, at 7:33 AM, Amit Kapila wrote: > I have used a bit of different wording here to make things clear. > > Let me know what you think of the attached? WFM. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-02-20 Thread Amit Kapila
On Thu, Feb 18, 2021 at 2:42 PM Amit Kapila wrote: > > On Thu, Feb 18, 2021 at 5:59 AM Euler Taveira wrote: > > > > On Wed, Feb 17, 2021, at 8:01 AM, Amit Kapila wrote: > > > > Before fix > > ERROR: could not connect to the publisher: connection to server at > > "localhost" (::1), port 5432

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-02-18 Thread Amit Kapila
On Thu, Feb 18, 2021 at 5:59 AM Euler Taveira wrote: > > On Wed, Feb 17, 2021, at 8:01 AM, Amit Kapila wrote: > > Before fix > ERROR: could not connect to the publisher: connection to server at > "localhost" (::1), port 5432 failed: FATAL: pg_hba.conf rejects > replication connection for host

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-02-17 Thread Euler Taveira
On Wed, Feb 17, 2021, at 8:01 AM, Amit Kapila wrote: > Before fix > ERROR: could not connect to the publisher: connection to server at > "localhost" (::1), port 5432 failed: FATAL: pg_hba.conf rejects > replication connection for host "::1", user "KapilaAm", no encryption > > After fix error: >

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-02-17 Thread Amit Kapila
On Tue, Feb 16, 2021 at 10:40 PM Paul Martinez wrote: > > On Tue, Feb 16, 2021 at 2:22 AM Amit Kapila wrote: > > > > I don't think we need to update the error messages, it makes the code > > a bit difficult to parse without much benefit. How about just adding > > errdetail? See attached and let

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-02-16 Thread Paul Martinez
On Tue, Feb 16, 2021 at 2:22 AM Amit Kapila wrote: > > I don't think we need to update the error messages, it makes the code > a bit difficult to parse without much benefit. How about just adding > errdetail? See attached and let me know what you think? > Yeah, I think that looks good. Thanks!

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-02-16 Thread Amit Kapila
On Tue, Feb 2, 2021 at 1:43 AM Paul Martinez wrote: > > On Fri, Jan 29, 2021 at 8:41 PM Amit Kapila wrote: > > > > Yeah, hints or more details might improve the situation but I am not > > sure we want to add more branching here. Can we write something > > similar to HOSTNAME_LOOKUP_DETAIL for

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-02-01 Thread Paul Martinez
On Fri, Jan 29, 2021 at 8:41 PM Amit Kapila wrote: > > Yeah, hints or more details might improve the situation but I am not > sure we want to add more branching here. Can we write something > similar to HOSTNAME_LOOKUP_DETAIL for hints? Also, I think what you > are proposing to write is more of a

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-01-30 Thread Paul Martinez
On Thu, Jan 28, 2021 at 8:17 PM Amit Kapila wrote: > > What exactly are you bothered about here? Is the database name not > present in the message your concern or the message uses 'replication' > but actually it doesn't relate to 'replication' specified in > pg_hba.conf your concern? I think with

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-01-29 Thread Amit Kapila
On Sat, Jan 30, 2021 at 12:24 AM Paul Martinez wrote: > > On Thu, Jan 28, 2021 at 8:17 PM Amit Kapila wrote: > > > > What exactly are you bothered about here? Is the database name not > > present in the message your concern or the message uses 'replication' > > but actually it doesn't relate to

Re: [PATCH] pg_hba.conf error messages for logical replication connections

2021-01-28 Thread Amit Kapila
On Thu, Jan 28, 2021 at 1:51 PM Paul Martinez wrote: > > Hey, all, > > When creating a logical replication connection that isn't allowed by the > current pg_hba.conf, the error message states that a "replication > connection" is not allowed. > > This error message is confusing because although

[PATCH] pg_hba.conf error messages for logical replication connections

2021-01-28 Thread Paul Martinez
Hey, all, When creating a logical replication connection that isn't allowed by the current pg_hba.conf, the error message states that a "replication connection" is not allowed. This error message is confusing because although the user is trying to create a replication connection and specified