Re: [PATCH] pgbench log file headers

2024-03-30 Thread Andrey M. Borodin
> On 6 Jan 2024, at 20:20, vignesh C wrote: > > One of the test has failed in CFBOT at[1] with: Hi Adam, This is a kind reminder that CF entry [0] is waiting for an update. Thanks! Best regards, Andrey Borodin. [0] https://commitfest.postgresql.org/47/4660/

Re: [PATCH] pgbench log file headers

2024-01-06 Thread vignesh C
On Tue, 21 Nov 2023 at 09:52, Adam Hendel wrote: > > Hello, > > On Mon, Nov 13, 2023 at 6:01 PM Andres Freund wrote: >> >> Hi, >> >> On 2023-11-13 11:55:07 -0600, Adam Hendel wrote: >> > Currently, pgbench will log individual transactions to a logfile when the >> > `--log` parameter flag is

Re: [PATCH] pgbench log file headers

2023-11-20 Thread Adam Hendel
Hello, On Mon, Nov 13, 2023 at 6:01 PM Andres Freund wrote: > Hi, > > On 2023-11-13 11:55:07 -0600, Adam Hendel wrote: > > Currently, pgbench will log individual transactions to a logfile when the > > `--log` parameter flag is provided. The logfile, however, does not > include > > column

Re: [PATCH] pgbench log file headers

2023-11-15 Thread Adam Hendel
Hello On Mon, Nov 13, 2023 at 6:01 PM Andres Freund wrote: > Hi, > > On 2023-11-13 11:55:07 -0600, Adam Hendel wrote: > > Currently, pgbench will log individual transactions to a logfile when the > > `--log` parameter flag is provided. The logfile, however, does not > include > > column

Re: [PATCH] pgbench log file headers

2023-11-13 Thread Andres Freund
Hi, On 2023-11-13 11:55:07 -0600, Adam Hendel wrote: > Currently, pgbench will log individual transactions to a logfile when the > `--log` parameter flag is provided. The logfile, however, does not include > column header. It has become a fairly standard expectation of users to have > column

Re: [PATCH] pgbench log file headers

2023-11-13 Thread Andrew Atkinson
Hi Adam. Column headers in pgbench log files seem helpful. Besides programs, it seems helpful for humans to understand the column data as well. I was able to apply your patch and verify that the headers are added to the log file: andy@MacBook-Air-4 ~/P/postgres (master)> rm pgbench_log.*

[PATCH] pgbench log file headers

2023-11-13 Thread Adam Hendel
Hello Hackers! Currently, pgbench will log individual transactions to a logfile when the `--log` parameter flag is provided. The logfile, however, does not include column header. It has become a fairly standard expectation of users to have column headers present in flat files. Without the header