Re: [PATCH] src/interfaces/libpq/Makefile: fix pkg-config without openssl

2022-04-01 Thread Peter Eisentraut
On 31.03.22 18:37, Fabrice Fontaine wrote: Do not add openssl dependencies to libpq pkg-config file if openssl is disabled to avoid the following build failure with libdbi-drivers raised since commit beff361bc1edc24ee5f8b2073a1e5e4c92ea66eb: configure: error: Package requirements (libpq) were

Re: [PATCH] src/interfaces/libpq/Makefile: fix pkg-config without openssl

2022-04-01 Thread Tom Lane
Daniel Gustafsson writes: >> On 31 Mar 2022, at 18:37, Fabrice Fontaine >> wrote: >> +ifeq ($(with_ssl),openssl) >> PKG_CONFIG_REQUIRES_PRIVATE = libssl libcrypto >> +endif > That seems reasonable, is there any reason why the referenced commit didn't do > that? Looks like a clear oversight to

Re: [PATCH] src/interfaces/libpq/Makefile: fix pkg-config without openssl

2022-04-01 Thread Daniel Gustafsson
> On 31 Mar 2022, at 18:37, Fabrice Fontaine wrote: > +ifeq ($(with_ssl),openssl) > PKG_CONFIG_REQUIRES_PRIVATE = libssl libcrypto > +endif That seems reasonable, is there any reason why the referenced commit didn't do that? -- Daniel Gustafsson https://vmware.com/

[PATCH] src/interfaces/libpq/Makefile: fix pkg-config without openssl

2022-04-01 Thread Fabrice Fontaine
Do not add openssl dependencies to libpq pkg-config file if openssl is disabled to avoid the following build failure with libdbi-drivers raised since commit beff361bc1edc24ee5f8b2073a1e5e4c92ea66eb: configure: error: Package requirements (libpq) were not met: Package 'libssl', required by