Re: [PROPOSAL] comments in repl_scanner

2025-10-18 Thread Peter Eisentraut
On 14.10.25 13:13, Matěj Klonfar wrote: certain instrumentation tools do prefix each statement with an informational comment, typically to provide some tracing information to logs (datadog for example). While this works for SQL statements, it's not possible with logical replication statements b

Re: [PROPOSAL] comments in repl_scanner

2025-10-18 Thread Matěj Klonfar
Hi Michael, Thanks for your notes. čt 16. 10. 2025 v 6:08 odesílatel Michael Paquier napsal: > On Tue, Oct 14, 2025 at 01:13:38PM +0200, Matěj Klonfar wrote: > > I can imagine this limitation is likely a holdover from the system's > > evolution from physical replication where comments make no s

Re: [PROPOSAL] comments in repl_scanner

2025-10-17 Thread Michael Paquier
On Tue, Oct 14, 2025 at 01:13:38PM +0200, Matěj Klonfar wrote: > I can imagine this limitation is likely a holdover from the system's > evolution from physical replication where comments make no sense. However, > in logical replication walsender mode both SQL and replication statements > can be iss

[PROPOSAL] comments in repl_scanner

2025-10-17 Thread Matěj Klonfar
Hi hackers, certain instrumentation tools do prefix each statement with an informational comment, typically to provide some tracing information to logs (datadog for example). While this works for SQL statements, it's not possible with logical replication statements because their grammar doesn't su