Re: [RFC] Add jit deform_counter

2023-10-13 Thread Daniel Gustafsson
> On 12 Oct 2023, at 15:40, Daniel Gustafsson wrote: >> On 12 Oct 2023, at 15:37, Nazir Bilal Yavuz wrote: >> I realized that pg_stat_statements is bumped to 1.11 with this patch >> but oldextversions test is not updated. So, I attached a patch for >> updating oldextversions. > > Thanks for

Re: [RFC] Add jit deform_counter

2023-10-12 Thread Daniel Gustafsson
> On 12 Oct 2023, at 15:37, Nazir Bilal Yavuz wrote: > > Hi, > > On Fri, 8 Sept 2023 at 20:22, Dmitry Dolgov <9erthali...@gmail.com> wrote: >> >>> On Fri, Sep 08, 2023 at 03:34:42PM +0200, Daniel Gustafsson wrote: On 5 Sep 2023, at 16:37, Daniel Gustafsson wrote: >>> I've gone over

Re: [RFC] Add jit deform_counter

2023-10-12 Thread Nazir Bilal Yavuz
Hi, On Fri, 8 Sept 2023 at 20:22, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Fri, Sep 08, 2023 at 03:34:42PM +0200, Daniel Gustafsson wrote: > > > On 5 Sep 2023, at 16:37, Daniel Gustafsson wrote: > > > > > I've gone over this version of the patch and I think it's ready to go in. > >

Re: [RFC] Add jit deform_counter

2023-09-08 Thread Dmitry Dolgov
> On Fri, Sep 08, 2023 at 03:34:42PM +0200, Daniel Gustafsson wrote: > > On 5 Sep 2023, at 16:37, Daniel Gustafsson wrote: > > > I've gone over this version of the patch and I think it's ready to go in. > > I'm > > marking this Ready for Committer and will go ahead with it shortly barring > >

Re: [RFC] Add jit deform_counter

2023-09-08 Thread Daniel Gustafsson
> On 5 Sep 2023, at 16:37, Daniel Gustafsson wrote: > I've gone over this version of the patch and I think it's ready to go in. I'm > marking this Ready for Committer and will go ahead with it shortly barring any > objections. Pushed, after another round of review with some minor fixes. --

Re: [RFC] Add jit deform_counter

2023-09-05 Thread Daniel Gustafsson
> On 14 Aug 2023, at 16:36, Dmitry Dolgov <9erthali...@gmail.com> wrote: > And here is it. The json version of EXPLAIN now looks like this: > > "JIT": { > [...] > "Timing": { > "Generation": { > "Deform": 0.000, > "Total": 0.205 > }, >

Re: [RFC] Add jit deform_counter

2023-08-14 Thread Dmitry Dolgov
> On Wed, Jul 19, 2023 at 05:18:29PM +0200, Dmitry Dolgov wrote: > > On Tue, Jul 18, 2023, 3:32 PM Daniel Gustafsson wrote > >> Here is the patch with the proposed variation. > > > > This version still leaves non-text EXPLAIN formats with timing which > doesn't > > add up. Below are JSON and XML

Re: [RFC] Add jit deform_counter

2023-07-19 Thread Dmitry Dolgov
> On Tue, Jul 18, 2023, 3:32 PM Daniel Gustafsson wrote >> Here is the patch with the proposed variation. > > This version still leaves non-text EXPLAIN formats with timing which doesn't > add up. Below are JSON and XML examples: Good point. For the structured formats it should be represented

Re: [RFC] Add jit deform_counter

2023-07-18 Thread Daniel Gustafsson
> On 15 Apr 2023, at 16:40, Dmitry Dolgov <9erthali...@gmail.com> wrote: >> On Fri, Mar 31, 2023 at 07:39:27PM +0200, Dmitry Dolgov wrote: >>> On Wed, Mar 29, 2023 at 01:50:37PM +1300, David Rowley wrote: I had a look at this patch today and I agree that it would be good to give the user an

Re: [RFC] Add jit deform_counter

2023-04-15 Thread Dmitry Dolgov
> On Fri, Mar 31, 2023 at 07:39:27PM +0200, Dmitry Dolgov wrote: > > On Wed, Mar 29, 2023 at 01:50:37PM +1300, David Rowley wrote: > > On Sun, 12 Jun 2022 at 21:14, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > I've noticed that JIT performance counter generation_counter seems to > > >

Re: [RFC] Add jit deform_counter

2023-03-31 Thread Dmitry Dolgov
> On Wed, Mar 29, 2023 at 01:50:37PM +1300, David Rowley wrote: > On Sun, 12 Jun 2022 at 21:14, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > I've noticed that JIT performance counter generation_counter seems to > > include > > actions, relevant for both jit_expressions and jit_tuple_deforming

Re: [RFC] Add jit deform_counter

2023-03-28 Thread David Rowley
On Sun, 12 Jun 2022 at 21:14, Dmitry Dolgov <9erthali...@gmail.com> wrote: > I've noticed that JIT performance counter generation_counter seems to include > actions, relevant for both jit_expressions and jit_tuple_deforming options. It > means one can't directly see what is the influence of

Re: [RFC] Add jit deform_counter

2023-01-15 Thread Pavel Stehule
Hi Thanks for noticing. Similarly to the previous issue, the order of > columns was incorrect -- deform counters have to be the last columns in > the view. > I tested it and now looks well check-world passed make doc passed I mark this patch as ready for committer Regards Pavel

Re: [RFC] Add jit deform_counter

2023-01-15 Thread Dmitry Dolgov
> On Sun, Jan 08, 2023 at 09:06:33PM +0100, Pavel Stehule wrote: > It is working although I am not sure if it is correctly > > when I run EXPLAIN ANALYZE for query `explain analyze select > count(length(prosrc) > 0) from pg_proc;` > > I got plan and times > >

Re: [RFC] Add jit deform_counter

2023-01-08 Thread Pavel Stehule
Hi > > I'm not sure why, but pgss jit metrics are always nulls for explain >> > > analyze queries. I have noticed this with surprise myself, when >> recently >> > > was reviewing the lazy jit patch, but haven't yet figure out what is >> the >> > > reason. Anyway, without "explain analyze" you'll

Re: [RFC] Add jit deform_counter

2023-01-08 Thread Pavel Stehule
ne 8. 1. 2023 v 11:57 odesílatel Dmitry Dolgov <9erthali...@gmail.com> napsal: > > On Sat, Jan 07, 2023 at 07:09:11PM +0100, Pavel Stehule wrote: > > so 7. 1. 2023 v 16:48 odesílatel Dmitry Dolgov <9erthali...@gmail.com> > > napsal: > > > > > > On Fri, Jan 06, 2023 at 09:42:09AM +0100, Pavel

Re: [RFC] Add jit deform_counter

2023-01-08 Thread Dmitry Dolgov
> On Sat, Jan 07, 2023 at 07:09:11PM +0100, Pavel Stehule wrote: > so 7. 1. 2023 v 16:48 odesílatel Dmitry Dolgov <9erthali...@gmail.com> > napsal: > > > > On Fri, Jan 06, 2023 at 09:42:09AM +0100, Pavel Stehule wrote: > > > The explain part is working, the part of pg_stat_statements doesn't > > >

Re: [RFC] Add jit deform_counter

2023-01-07 Thread Pavel Stehule
so 7. 1. 2023 v 16:48 odesílatel Dmitry Dolgov <9erthali...@gmail.com> napsal: > > On Fri, Jan 06, 2023 at 09:42:09AM +0100, Pavel Stehule wrote: > > The explain part is working, the part of pg_stat_statements doesn't > > > > set jit_above_cost to 10; > > set jit_optimize_above_cost to 10; > >

Re: [RFC] Add jit deform_counter

2023-01-07 Thread Dmitry Dolgov
> On Fri, Jan 06, 2023 at 09:42:09AM +0100, Pavel Stehule wrote: > The explain part is working, the part of pg_stat_statements doesn't > > set jit_above_cost to 10; > set jit_optimize_above_cost to 10; > set jit_inline_above_cost to 10; > > (2023-01-06 09:08:59) postgres=# explain analyze select >

Re: [RFC] Add jit deform_counter

2023-01-06 Thread Pavel Stehule
Hi po 2. 1. 2023 v 17:55 odesílatel Dmitry Dolgov <9erthali...@gmail.com> napsal: > > On Sun, Dec 25, 2022 at 06:55:02PM +0100, Pavel Stehule wrote: > > there are some problems with stability of regress tests > > > > http://cfbot.cputube.org/dmitry-dolgov.html > > Looks like this small change

Re: [RFC] Add jit deform_counter

2023-01-02 Thread Dmitry Dolgov
> On Sun, Dec 25, 2022 at 06:55:02PM +0100, Pavel Stehule wrote: > there are some problems with stability of regress tests > > http://cfbot.cputube.org/dmitry-dolgov.html Looks like this small change predates moving to meson, the attached version should help. >From

Re: [RFC] Add jit deform_counter

2022-12-25 Thread Pavel Stehule
Hi ne 11. 12. 2022 v 5:44 odesílatel Pavel Stehule napsal: > Hi > > ne 11. 12. 2022 v 1:14 odesílatel Ian Lawrence Barwick > napsal: > >> 2022年6月12日(日) 18:14 Dmitry Dolgov <9erthali...@gmail.com>: >> > >> > Hi, >> > >> > I've noticed that JIT performance counter generation_counter seems to >>

Re: [RFC] Add jit deform_counter

2022-12-10 Thread Pavel Stehule
Hi ne 11. 12. 2022 v 1:14 odesílatel Ian Lawrence Barwick napsal: > 2022年6月12日(日) 18:14 Dmitry Dolgov <9erthali...@gmail.com>: > > > > Hi, > > > > I've noticed that JIT performance counter generation_counter seems to > include > > actions, relevant for both jit_expressions and

Re: [RFC] Add jit deform_counter

2022-12-10 Thread Ian Lawrence Barwick
2022年6月12日(日) 18:14 Dmitry Dolgov <9erthali...@gmail.com>: > > Hi, > > I've noticed that JIT performance counter generation_counter seems to include > actions, relevant for both jit_expressions and jit_tuple_deforming options. It > means one can't directly see what is the influence of

[RFC] Add jit deform_counter

2022-06-12 Thread Dmitry Dolgov
Hi, I've noticed that JIT performance counter generation_counter seems to include actions, relevant for both jit_expressions and jit_tuple_deforming options. It means one can't directly see what is the influence of jit_tuple_deforming alone, which would be helpful when adjusting JIT options. To