Re: 10% drop in code line count in PG 17

2025-11-19 Thread David Rowley
On Thu, 20 Nov 2025 at 10:58, Bruce Momjian wrote: > I think you are right. Attached is the difference between the output > for 16 & 17. Let me do some more research and run all the versions > again and report back, thanks. Maybe you'd be better with git ls-files if you only want just what's in

Re: 10% drop in code line count in PG 17

2025-11-19 Thread Álvaro Herrera
On 2025-Nov-19, Tom Lane wrote: > > No, I just followed the shell comment I wrote above the 'find' command > > shown above: > > > # This script is used to compute the total number of "C" lines in the > > # release This should be run from the top of the Git tree after a 'make > > # dis

Re: 10% drop in code line count in PG 17

2025-11-19 Thread Bruce Momjian
On Wed, Nov 19, 2025 at 04:22:37PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Nov 19, 2025 at 03:21:33PM -0500, Tom Lane wrote: > >> Also ... are you in fact counting only what is in git? Because > >> I get different answers: > > > No, I just followed the shell comment I wrote ab

Re: 10% drop in code line count in PG 17

2025-11-19 Thread Tom Lane
Bruce Momjian writes: > On Wed, Nov 19, 2025 at 03:21:33PM -0500, Tom Lane wrote: >> Also ... are you in fact counting only what is in git? Because >> I get different answers: > No, I just followed the shell comment I wrote above the 'find' command > shown above: > # This script is used t

Re: 10% drop in code line count in PG 17

2025-11-19 Thread Bruce Momjian
On Wed, Nov 19, 2025 at 03:21:33PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > While working on a talk, I studied the number of code line changes in > > each major release, and found PG 17 surprisingly reduced code line count > > by 10%. To get the code line count, I used /pgtop/src/tools/c

Re: 10% drop in code line count in PG 17

2025-11-19 Thread Tom Lane
Bruce Momjian writes: > While working on a talk, I studied the number of code line changes in > each major release, and found PG 17 surprisingly reduced code line count > by 10%. To get the code line count, I used /pgtop/src/tools/codelines, > which runs: > find . -name '*.[chyl]' | xargs c

10% drop in code line count in PG 17

2025-11-19 Thread Bruce Momjian
While working on a talk, I studied the number of code line changes in each major release, and found PG 17 surprisingly reduced code line count by 10%. To get the code line count, I used /pgtop/src/tools/codelines, which runs: find . -name '*.[chyl]' | xargs cat| wc -l Any ideas on the cau