Re: A couple of random BF failures in kerberosCheck

2019-08-04 Thread Tom Lane
Andrew Dunstan writes: > On 8/3/19 6:42 PM, Tom Lane wrote: >> So I propose the attached patch, which seems to fix this for me. > Looks good. A couple of minor nits: Will fix, thanks for the review! regards, tom lane

Re: A couple of random BF failures in kerberosCheck

2019-08-04 Thread Andrew Dunstan
On 8/3/19 6:42 PM, Tom Lane wrote: > I wrote: >> * kerberos/t/001_auth.pl just blithely assumes that it can pick >> any random port above 48K and that's guaranteed to be free. >> Maybe we should split out the code in get_new_node for finding >> a free TCP port, so we can call it here? > I've conf

Re: A couple of random BF failures in kerberosCheck

2019-08-03 Thread Tom Lane
I wrote: > * kerberos/t/001_auth.pl just blithely assumes that it can pick > any random port above 48K and that's guaranteed to be free. > Maybe we should split out the code in get_new_node for finding > a free TCP port, so we can call it here? I've confirmed that the reason it's failing on my mac

Re: A couple of random BF failures in kerberosCheck

2019-08-03 Thread Tom Lane
Thomas Munro writes: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=elver&dt=2019-07-24%2003%3A22%3A17 > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2019-08-02%2007%3A17%3A25 > I wondered if this might be like the recently fixed problem with slapd > not being ready

A couple of random BF failures in kerberosCheck

2019-08-02 Thread Thomas Munro
Hello, https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=elver&dt=2019-07-24%2003%3A22%3A17 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2019-08-02%2007%3A17%3A25 I wondered if this might be like the recently fixed problem with slapd not being ready to handle requests ye