Re: A problem about ParamPathInfo for an AppendPath

2023-03-16 Thread Richard Guo
On Fri, Mar 17, 2023 at 6:15 AM Tom Lane wrote: > Pushed. I thought the comment needed to be completely rewritten not just > tweaked, and I felt it was probably reasonable to continue to exclude > dummy paths from getting the more expensive treatment. Yes agreed. Thanks for the changes and

Re: A problem about ParamPathInfo for an AppendPath

2023-03-16 Thread Tom Lane
Richard Guo writes: > Attached is a patch for this change and the changes described upthread. Pushed. I thought the comment needed to be completely rewritten not just tweaked, and I felt it was probably reasonable to continue to exclude dummy paths from getting the more expensive treatment.

Re: A problem about ParamPathInfo for an AppendPath

2022-12-12 Thread Richard Guo
On Tue, Dec 6, 2022 at 5:00 PM Richard Guo wrote: > As we can see, MemoizePath can be generated for partitioned AppendPath > but not for union-all AppendPath. > > For the fix I think we can relax the check in create_append_path and > always use get_baserel_parampathinfo if the parent is a

A problem about ParamPathInfo for an AppendPath

2022-12-06 Thread Richard Guo
While trying the codes of MemoizePath I noticed that MemoizePath cannot be generated if inner path is a union-all AppendPath, even if it is parameterized. And I found the problem is that for a union-all AppendPath the ParamPathInfo is not created in the usual way. Instead it is created with