Re: A spot of redundant initialization of brin memtuple

2022-01-04 Thread Tom Lane
Richard Guo writes: > On Mon, Nov 22, 2021 at 12:52 PM Bharath Rupireddy < > bharath.rupireddyforpostg...@gmail.com> wrote: >> Thanks. The patch looks good to me. Let's add it to the commitfest to >> not lose track of it. > Done. Here it is: > https://commitfest.postgresql.org/36/3424/ Pushed,

Re: A spot of redundant initialization of brin memtuple

2021-11-21 Thread Richard Guo
On Mon, Nov 22, 2021 at 12:52 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Mon, Nov 22, 2021 at 8:53 AM Richard Guo > wrote: > > > > > > On Sat, Nov 20, 2021 at 12:23 AM Bharath Rupireddy < > bharath.rupireddyforpostg...@gmail.com> wrote: > >> > >> On Fri, Nov 19,

Re: A spot of redundant initialization of brin memtuple

2021-11-21 Thread Bharath Rupireddy
On Mon, Nov 22, 2021 at 8:53 AM Richard Guo wrote: > > > On Sat, Nov 20, 2021 at 12:23 AM Bharath Rupireddy > wrote: >> >> On Fri, Nov 19, 2021 at 1:13 PM Richard Guo wrote: >> > >> > Happened to notice this when reading around the codes. The BrinMemTuple >> > would be initialized in

Re: A spot of redundant initialization of brin memtuple

2021-11-21 Thread Richard Guo
On Sat, Nov 20, 2021 at 12:23 AM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Fri, Nov 19, 2021 at 1:13 PM Richard Guo > wrote: > > > > Happened to notice this when reading around the codes. The BrinMemTuple > > would be initialized in brin_new_memtuple(), right after

Re: A spot of redundant initialization of brin memtuple

2021-11-19 Thread Bharath Rupireddy
On Fri, Nov 19, 2021 at 1:13 PM Richard Guo wrote: > > Happened to notice this when reading around the codes. The BrinMemTuple > would be initialized in brin_new_memtuple(), right after being created. > So we don't need to initialize it again outside. > > diff --git

A spot of redundant initialization of brin memtuple

2021-11-18 Thread Richard Guo
Happened to notice this when reading around the codes. The BrinMemTuple would be initialized in brin_new_memtuple(), right after being created. So we don't need to initialize it again outside. diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c index