Re: AW: Assorted improvements in pg_dump

2021-12-07 Thread Tom Lane
Hans Buschmann writes: > I noticed that you patched master with all the improvements in pg_dump. > Did you change your mind about backpatching patch 0005 to fix the toast size > matter? I looked briefly at that and found that the patch would have to be largely rewritten, because getTables() look

AW: Assorted improvements in pg_dump

2021-12-07 Thread Hans Buschmann
Hello Tom, from your mail from 25.10.2021: >0005 implements your suggestion of accounting for TOAST data while >scheduling parallel dumps. I realized while looking at that that >there's a pre-existing bug, which this'd exacerbate: on machines >with 32-bit off_t, dataLength can overflow. Admitte

AW: Assorted improvements in pg_dump

2021-10-25 Thread Hans Buschmann
1. Von: Tom Lane >Maybe we should back-patch 0005. OTOH, how likely is it that anyone >is wrangling tables exceeding 16TB on a machine with 32-bit off_t? >Or that poor parallel dump scheduling would be a real problem in >such a case? I tested your patch