On Tue, Mar 02, 2021 at 10:01:43AM +0100, Daniel Gustafsson wrote:
> +1, no objections from me after a readthrough of this version.
Thanks, Daniel and Mark. I have applied v2 from upthread, then.
--
Michael
signature.asc
Description: PGP signature
> On Mar 1, 2021, at 10:04 PM, Michael Paquier wrote:
>
> On Mon, Mar 01, 2021 at 10:12:54AM -0800, Mark Dilger wrote:
>> Your check verifies that reindexing a system table on a new
>> tablespace fails, but does not verify what the failure was. I
>> wonder if you might want to make it more ro
> On 2 Mar 2021, at 07:04, Michael Paquier wrote:
> I have also removed the assertions based on the version number of the
> backend, based on Daniel's input sent upthread.
>
> What do you think?
+1, no objections from me after a readthrough of this version.
--
Daniel Gustafsson h
23196c67685fb02782d637538ac4ba1e83c67 Mon Sep 17 00:00:00 2001
From: Michael Paquier
Date: Tue, 2 Mar 2021 14:56:50 +0900
Subject: [PATCH v2] Add --tablespace option to reindexdb
---
src/bin/scripts/reindexdb.c| 109 -
src/bin/scripts/t/090_reindexdb.pl | 81 +
> On Feb 25, 2021, at 10:49 PM, Michael Paquier wrote:
>
> Anyway, I would rather group the whole set of
> tests together, and using the --tablespace option introduced here
> within a TAP test does the job.
Your check verifies that reindexing a system table on a new tablespace fails,
but doe
> On Feb 25, 2021, at 10:49 PM, Michael Paquier wrote:
>
> While on it, I have added tests for toast tables and indexes with a
> tablespace move during a REINDEX.
In t/090_reindexdb.pl, you add:
+# Create a tablespace for testing.
+my $ts = $node->basedir . '/regress_reindex_tbspace';
+mkd
> On Feb 25, 2021, at 10:49 PM, Michael Paquier wrote:
>
> Hi all,
Hi Michael,
> Since c5b2860, it is possible to specify a tablespace for a REINDEX,
> but the equivalent option has not been added to reindexdb. Attached
> is a patch to take care of that.
>
> This includes documentation and
On Fri, Feb 26, 2021 at 11:00:13AM +0100, Daniel Gustafsson wrote:
> Some other small comments:
>
> + Assert(PQserverVersion(conn) >= 14);
> Are these assertions really buying us much when we already check the server
> version in reindex_one_database()?
I found these helpful when
> On 26 Feb 2021, at 07:49, Michael Paquier wrote:
> Since c5b2860, it is possible to specify a tablespace for a REINDEX,
> but the equivalent option has not been added to reindexdb. Attached
> is a patch to take care of that.
>
> This includes documentation and tests.
Makes sense.
> While on
788bc Mon Sep 17 00:00:00 2001
From: Michael Paquier
Date: Fri, 26 Feb 2021 15:35:53 +0900
Subject: [PATCH] Add --tablespace option to reindexdb
---
src/bin/scripts/reindexdb.c| 113 -
src/bin/scripts/t/090_reindexdb.pl | 69 --
doc/src/sgm
10 matches
Mail list logo
