Re: Add PGDLLIMPORT lines to some variables

2019-06-13 Thread Tom Lane
[ blast-from-the-past department ] Craig Ringer writes: > On 5 December 2017 at 22:49, Robert Haas wrote: >> Mark assorted variables PGDLLIMPORT. > I was going to pipe up here to add ReplicationSlotCtl to the list. > Otherwise the only way to access slot information is via the SPI and >

Re: Add PGDLLIMPORT lines to some variables

2017-12-06 Thread Craig Ringer
On 5 December 2017 at 22:49, Robert Haas wrote: > > Committed with these additions. Please check that I haven't messed > anything up. > > Looks good to me. For the record the commit is commit c572599c65bfe0387563233faabecd2845073538 Author: Robert Haas

Re: Add PGDLLIMPORT lines to some variables

2017-12-05 Thread Peter Geoghegan
On Tue, Dec 5, 2017 at 9:09 AM, Peter Geoghegan wrote: >> Committed with these additions. Please check that I haven't messed anything >> up. > > Thanks, but you modified RecentGlobalDataXmin, not RecentGlobalXmin. > Can you fix it, please? I was looking at the wrong branch.

Re: Add PGDLLIMPORT lines to some variables

2017-12-05 Thread Peter Geoghegan
On Tue, Dec 5, 2017 at 6:49 AM, Robert Haas wrote: >> RecentGlobalXmin -- This is only PGDLLIMPORT on Postgres 10+, >> following commit 56018bf2. I'd like to get that back to 9.4, although >> there is no reason to not include 9.3. >> >> TransactionXmin -- This is needed for

Re: Add PGDLLIMPORT lines to some variables

2017-12-05 Thread Robert Haas
On Mon, Dec 4, 2017 at 8:48 PM, Peter Geoghegan wrote: > On Mon, Dec 4, 2017 at 5:41 PM, Noah Misch wrote: >>> I don't think we quite have an established protocol for this. I >>> personally, but I'm biased in this specific case, is that we should >>> adopt a

Re: Add PGDLLIMPORT lines to some variables

2017-12-04 Thread Peter Geoghegan
. On Mon, Dec 4, 2017 at 5:41 PM, Noah Misch wrote: >> I don't think we quite have an established protocol for this. I >> personally, but I'm biased in this specific case, is that we should >> adopt a position that PGDLLIMPORTs should basically backpatched whenever >> a

Re: Add PGDLLIMPORT lines to some variables

2017-12-04 Thread Noah Misch
On Mon, Nov 20, 2017 at 12:02:30PM -0800, Andres Freund wrote: > On 2017-11-20 11:58:44 -0800, Brian Cloutier wrote: > > > please, append session_timezone to your list > > > > Here's a v2 patch which also includes session_timezone. > > > > Separately, is this the kind of thing which is eligible

Re: Add PGDLLIMPORT lines to some variables

2017-11-28 Thread Michael Paquier
On Wed, Nov 29, 2017 at 5:00 AM, Brian Cloutier wrote: > Sorry, I'm new to pg-hackers, so I'm not sure what the next step is. > > Do I submit this to commitfest? > > When submitting, do I submit multiple changes, one per branch this should be > packported to? If you want a

Re: Add PGDLLIMPORT lines to some variables

2017-11-28 Thread Brian Cloutier
Sorry, I'm new to pg-hackers, so I'm not sure what the next step is. Do I submit this to commitfest? When submitting, do I submit multiple changes, one per branch this should be packported to?

Re: Add PGDLLIMPORT lines to some variables

2017-11-16 Thread Pavel Stehule
Hi 2017-11-16 23:59 GMT+01:00 Brian Cloutier : > Hello hackers, > > I'm porting Citus to Windows and found that we use some variables which PG > doesn't export; here is a patch which adds PGDLLIMPORT declarations to > those variables. This is unfortunately required on

Add PGDLLIMPORT lines to some variables

2017-11-16 Thread Brian Cloutier
Hello hackers, I'm porting Citus to Windows and found that we use some variables which PG doesn't export; here is a patch which adds PGDLLIMPORT declarations to those variables. This is unfortunately required on Windows for extensions to be able to use those variables, and appears to already have