The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Hi Pavel,
I have tested this patch, and it proves to be highly useful when h
I've attached v6, which addresses two issues:
* Fixes a bug where XMLNAMESPACES declarations within a view were being
serialized as XMLATTRIBUTES.
* Prevents the makeString function from being called with a NULL
parameter - discussed in this thread [1].
Best regards, Jim
[1]
https://www.postgres
po 27. 1. 2025 v 14:57 odesílatel Umar Hayat
napsal:
> Pavel and Jim,
> If that's the case, it looks good to me.
> Just wanted to highlight potential issues and implementation
> differences compared to other databases.
>
It is correct.
Every Time there will be some differences - DB2 has an abs
Pavel and Jim,
If that's the case, it looks good to me.
Just wanted to highlight potential issues and implementation
differences compared to other databases.
Regards
Umar Hayat
On 21.01.25 11:48, Umar Hayat wrote:
> For XMLAttributes attribute it should have ColumnRef/Expr because
> that's the data/content we want to generate. But namespaces and xml
> tags, IMO they should be considered as part of the structure/schema of
> XML. Allowing namespaces (default or otherwise)
Hi
út 21. 1. 2025 v 11:45 odesílatel Umar Hayat
napsal:
> On Tue, 21 Jan 2025 at 04:04, Jim Jones wrote:
> >
> > Hi Umar
> >
> > On 20.01.25 17:19, Umar Hayat wrote:
> > > Hi Jim & Pavel,
> > > Sorry for getting back a bit late on this. Few more case you might
> > > need consider:
> > >
> > > A
On Tue, 21 Jan 2025 at 04:04, Jim Jones wrote:
>
> Hi Umar
>
> On 20.01.25 17:19, Umar Hayat wrote:
> > Hi Jim & Pavel,
> > Sorry for getting back a bit late on this. Few more case you might
> > need consider:
> >
> > As I mentioned in my first static review about XMLTable existing
> > behaviour m
Hi Umar
On 20.01.25 17:19, Umar Hayat wrote:
> Hi Jim & Pavel,
> Sorry for getting back a bit late on this. Few more case you might
> need consider:
>
> As I mentioned in my first static review about XMLTable existing
> behaviour might change, I give it a run time review and here are few
> finding
Hi Jim & Pavel,
Sorry for getting back a bit late on this. Few more case you might
need consider:
As I mentioned in my first static review about XMLTable existing
behaviour might change, I give it a run time review and here are few
findings:
1. Because of this patch XMLTable namespace will accept
On 16.01.25 08:36, Pavel Stehule wrote:
> Now, I have not any objections against the code
>
> The patch has doc and enough regress tests
> The patching and compilation without problems
> make check-world passed
>
> I'll mark this patch as ready for committer
rebase due to gram.y changes introduc
Hi
st 15. 1. 2025 v 21:35 odesílatel Jim Jones
napsal:
> Hi Umar, Hi Pavel,
>
> On 26.12.24 14:46, Jim Jones wrote:
> > The idea of NO DEFAULT is pretty much to free an element (and its
> > children) from a previous DEFAULT in the same scope.
> >
> > SELECT
> > xmlserialize(DOCUMENT
> > xm
Hi Umar, Hi Pavel,
On 26.12.24 14:46, Jim Jones wrote:
> The idea of NO DEFAULT is pretty much to free an element (and its
> children) from a previous DEFAULT in the same scope.
>
> SELECT
> xmlserialize(DOCUMENT
> xmlelement(NAME "root",
> xmlnamespaces(DEFAULT 'http:/x.y/ns1'),
>
čt 26. 12. 2024 v 14:46 odesílatel Jim Jones
napsal:
> Hi Umar, hi Pavel,
>
> Thanks for taking a look at this patch!
>
> On 26.12.24 05:15, Umar Hayat wrote:
> > Hi,
> > +1 for the enhancement.
> >
> > I haven't compiled and reviewed the full patch yet, please see a few
> > comments from my side
Hi Umar, hi Pavel,
Thanks for taking a look at this patch!
On 26.12.24 05:15, Umar Hayat wrote:
> Hi,
> +1 for the enhancement.
>
> I haven't compiled and reviewed the full patch yet, please see a few
> comments from my side based on static analysis.
>
> 1. Though changes are targeted for XMLNAME
Hi,
+1 for the enhancement.
I haven't compiled and reviewed the full patch yet, please see a few
comments from my side based on static analysis.
1. Though changes are targeted for XMLNAMESPACES for XMLElement but in
my opinion it will affect XMLTABLE as well because the
'xml_namespace_list' rule
Hi
so 21. 12. 2024 v 0:51 odesílatel Jim Jones
napsal:
> Hi,
>
> I'd like to propose the implementation of the XMLNamespaces option for
> XMLElement.
>
> XMLNAMESPACES(nsuri AS nsprefix)
> XMLNAMESPACES(DEFAULT default-nsuri)
> XMLNAMESPACES(NO DEFAULT)
>
> * nsprefix: Namespace's p
Hi,
I'd like to propose the implementation of the XMLNamespaces option for
XMLElement.
XMLNAMESPACES(nsuri AS nsprefix)
XMLNAMESPACES(DEFAULT default-nsuri)
XMLNAMESPACES(NO DEFAULT)
* nsprefix: Namespace's prefix.
* nsuri: Namespace's URI.
* DEFAULT default-nsuri: S
17 matches
Mail list logo
