On Fri, Mar 15, 2024 at 06:37:35PM +1300, David Steele wrote:
> This seems like a reasonable explanation to me.
FYI, drongo has just passed the test. fairywren uses TAP, does not
run the recovery tests.
--
Michael
signature.asc
Description: PGP signature
On 3/15/24 18:32, Michael Paquier wrote:
On Fri, Mar 15, 2024 at 06:23:15PM +1300, David Steele wrote:
Well, this is what we recommend in the docs, i.e. using bin mode to save
backup_label, so it seems OK to me.
Indeed, I didn't notice that this is actually documented, so what I
did took the r
On Fri, Mar 15, 2024 at 06:23:15PM +1300, David Steele wrote:
> Well, this is what we recommend in the docs, i.e. using bin mode to save
> backup_label, so it seems OK to me.
Indeed, I didn't notice that this is actually documented, so what I
did took the right angle. French flair, perhaps..
--
M
On Fri, Mar 15, 2024 at 08:38:47AM +0900, Michael Paquier wrote:
> That's why these tests are not that easy, they can be racy. I've run
> the test 5~10 times in the CI this time to gain more confidence, and
> saw zero failures with the stability fixes in place including Windows.
> I've applied it
On 3/15/24 12:38, Michael Paquier wrote:
On Fri, Mar 15, 2024 at 09:40:38AM +1300, David Steele wrote:
Is the missing test in meson the reason we did not see test failures for
Windows in CI?
The test has to be listed in src/test/recovery/meson.build or the CI
would ignore it.
Right -- I will
On Fri, Mar 15, 2024 at 09:40:38AM +1300, David Steele wrote:
> Is the missing test in meson the reason we did not see test failures for
> Windows in CI?
The test has to be listed in src/test/recovery/meson.build or the CI
would ignore it.
>> The second LOG is something that can be acted on. I'v
On 3/14/24 20:00, Michael Paquier wrote:
On Thu, Mar 14, 2024 at 09:12:52AM +1300, David Steele wrote:
I think you are right that the start message is better since it can only
appear once when the backup_label is found. The completed message could in
theory appear after a restart, though the bac
On Thu, Mar 14, 2024 at 09:12:52AM +1300, David Steele wrote:
> I think you are right that the start message is better since it can only
> appear once when the backup_label is found. The completed message could in
> theory appear after a restart, though the backup_label must have been found
> at so
ted message could
in theory appear after a restart, though the backup_label must have been
found at some point.
Regards,
-DavidFrom 91f8e8a390713760116990be05d96f8a7e0d1bde Mon Sep 17 00:00:00 2001
From: David Steele
Date: Wed, 13 Mar 2024 20:02:40 +
Subject: Add basic tests for the low-level backup
On Wed, Mar 13, 2024 at 01:12:28PM +1300, David Steele wrote:
> On 2/29/24 16:55, Michael Paquier wrote:
>> +unlink("$backup_dir/postmaster.pid")
>> +or BAIL_OUT("unable to unlink $backup_dir/postmaster.pid");
>> +unlink("$backup_dir/postmaster.opts")
>> +or BAIL_OUT("unable to unlink $back
a
backup_label.
Regards,
-DavidFrom 076429a578ece3c213525220a4961cb5b56c190a Mon Sep 17 00:00:00 2001
From: David Steele
Date: Wed, 13 Mar 2024 00:01:55 +
Subject: Add basic tests for the low-level backup method.
There are currently no tests for the low-level backup method. pg_backup_start()
On Thu, Feb 29, 2024 at 10:30:52AM +1300, David Steele wrote:
> On 11/12/23 08:21, David Steele wrote:
>> As promised in [1], attached are some basic tests for the low-level
>> backup method.
>
> Added to the 2024-03 CF.
There is already 040_standby_failover_slots_sync.pl in recovery/ that
uses t
On 11/12/23 08:21, David Steele wrote:
As promised in [1], attached are some basic tests for the low-level
backup method.
Added to the 2024-03 CF.
Regards,
-David
Nov 2023 19:12:49 +
Subject: Add basic tests for the low-level backup method.
There are currently no tests for the low-level backup method. pg_backup_start()
and pg_backup_stop() are called but not exercised in any real fashion.
There is a lot more that can be done, but this at least provides
14 matches
Mail list logo
