Re: Add missing includes

2023-05-22 Thread Tom Lane
Michael Paquier writes: > The standalone compile policy is documented in > src/tools/pginclude/README, AFAIK, so close enough :p Hmm, that needs an update --- the scripts are slightly smarter now than that text gives them credit for. I'll see to it after the release freeze lifts.

Re: Add missing includes

2023-05-22 Thread Michael Paquier
On Mon, May 22, 2023 at 11:34:14AM -0400, Tom Lane wrote: > There is such a policy, but not with respect to those particular > headers. You might find src/tools/pginclude/headerscheck and > src/tools/pginclude/cpluspluscheck to be interesting reading, > as those are the tests we run to verify this

Re: Add missing includes

2023-05-22 Thread Tom Lane
"Tristan Partin" writes: > Interesting. Thanks for the information. Thought I had seen in a > different email thread that header files were supposed to include all > that they needed to. Anyways, ignore the patch :). There is such a policy, but not with respect to those particular headers. You m

Re: Add missing includes

2023-05-22 Thread Tristan Partin
On Mon May 22, 2023 at 10:28 AM CDT, Tom Lane wrote: > >> Some files were missing information from the c.h header. > > > Actually, these omissions are intentional, and we have bespoke handling > > for this in our own header-checking scripts (src/tools/pginclude). I > > imagine this is documented s

Re: Add missing includes

2023-05-22 Thread Tom Lane
Alvaro Herrera writes: > On 2023-May-22, Tristan Partin wrote: >> Some files were missing information from the c.h header. > Actually, these omissions are intentional, and we have bespoke handling > for this in our own header-checking scripts (src/tools/pginclude). I > imagine this is documented

Re: Add missing includes

2023-05-22 Thread Tristan Partin
On Mon May 22, 2023 at 10:16 AM CDT, Alvaro Herrera wrote: > > Some files were missing information from the c.h header. > > Actually, these omissions are intentional, and we have bespoke handling > for this in our own header-checking scripts (src/tools/pginclude). I > imagine this is documented so

Re: Add missing includes

2023-05-22 Thread Alvaro Herrera
Hi, On 2023-May-22, Tristan Partin wrote: > Some files were missing information from the c.h header. Actually, these omissions are intentional, and we have bespoke handling for this in our own header-checking scripts (src/tools/pginclude). I imagine this is documented somewhere, but ATM I can't

Add missing includes

2023-05-22 Thread Tristan Partin
Hi, Some files were missing information from the c.h header. -- Tristan Partin Neon (https://neon.tech) From 3c0c32077bb9626d4ebad1452b9fc9937c99518d Mon Sep 17 00:00:00 2001 From: Tristan Partin Date: Mon, 22 May 2023 10:07:45 -0500 Subject: [PATCH postgres v1] Add some missing includes Both