On Wed, 19 Mar 2025 at 18:12, David Rowley wrote:
>
> On Wed, 19 Mar 2025 at 23:22, Ilia Evdokimov
> wrote:
> > Everything seems fine with the ANALYZE command autocompletion. Regarding
> > VACUUM, I'm not entirely convinced we should provide autocompletion in
> > every case. I'd prefer to keep
vignesh C writes:
> On Wed, 19 Mar 2025 at 18:12, David Rowley wrote:
>> While VACUUM ONLY on a partitioned table has no effect, the same isn't
>> true for inheritance parents. 62ddf7ee9 did change the behaviour of
>> VACUUM for these so that vacuuming the inheritance parent now vacuums
>> all of
On Wed, 19 Mar 2025 at 23:22, Ilia Evdokimov
wrote:
> Everything seems fine with the ANALYZE command autocompletion. Regarding
> VACUUM, I'm not entirely convinced we should provide autocompletion in every
> case. I'd prefer to keep the behavior from the v3 patch because the original
> intentio
On 19.03.2025 12:55, vignesh C wrote:
Looks good overall. However, after pressing Tab, ONLY appears in the completion
list, but it doesn't autocomplete after typing the first letter.
In which case you noticed this?
Ah, I just tested it using these examples from the regression tests:
CREATE
On Wed, 19 Mar 2025 at 14:46, Ilia Evdokimov
wrote:
>
> Looks good overall. However, after pressing Tab, ONLY appears in the
> completion list, but it doesn't autocomplete after typing the first letter.
In which case you noticed this?
Regards,
Vignesh
On 19.03.2025 08:12, vignesh C wrote:
How about we handle it like in the attached patch?
Apart from this, similar handling was required for "ANALYZE VERBOSE" also.
Looks good overall. However, after pressing Tab, ONLY appears in the
completion list, but it doesn't autocomplete after typing t
On Wed, 19 Mar 2025 at 13:27, Ilia Evdokimov
wrote:
>
> It would be nice if this works with VACUUM VERBOSE ANALYZE ONLY table;
Thanks for the comment, here is an updated v3 version with the change
for the same.
Regards,
Vignesh
v3-0001-psql-Tab-completion-for-VACUUM-and-ANALYZE-.-ONLY.patch
De
On 19.03.2025 08:12, vignesh C wrote:
How about we handle it like in the attached patch?
Apart from this, similar handling was required for "ANALYZE VERBOSE" also.
Regards,
Vignesh
It would be nice if this works with VACUUM VERBOSE ANALYZE ONLY table;
--
Best regards,
Ilia Evdokimov,
Tantor
On Tue, 18 Mar 2025 at 20:43, Ilia Evdokimov
wrote:
>
>
> On 18.03.2025 17:57, Ilia Evdokimov wrote:
> > Hi,
> >
> > Thank you for the patch. However, Is it ok if I can't tab 'ONLY' in
> > VACUUM ANALYZE command?
How about we handle it like in the attached patch?
Apart from this, similar handling
On 18.03.2025 17:57, Ilia Evdokimov wrote:
Hi,
Thank you for the patch. However, Is it ok if I can't tab 'ONLY' in
VACUUM ANALYZE command?
CREATE TABLE only_parted (a int, b text) PARTITION BY LIST (a);
CREATE TABLE only_parted1 PARTITION OF only_parted FOR VALUES IN (1);
INSERT INTO only_p
On 18.03.2025 15:25, vignesh C wrote:
On Thu, 27 Feb 2025 at 11:42, vignesh C wrote:
On Thu, 6 Feb 2025 at 16:29, Umar Hayat wrote:
This will include "ONLY" also when we display the tables too:
+ else if (HeadMatches("ANALYZE"))
+
COMPLETE_WITH_SCHEMA_QUERY_PLUS(Query_for_list_of_anal
On Thu, 27 Feb 2025 at 11:42, vignesh C wrote:
>
> On Thu, 6 Feb 2025 at 16:29, Umar Hayat wrote:
>
> This will include "ONLY" also when we display the tables too:
> + else if (HeadMatches("ANALYZE"))
> +
> COMPLETE_WITH_SCHEMA_QUERY_PLUS(Query_for_list_of_analyzables,
> "ONLY");
>
> like b
On Thu, 6 Feb 2025 at 16:29, Umar Hayat wrote:
>
> Hi,
> Recently the ONLY option is introduced [1] for VACUUM and ANALYZE
> commands. Attach provides improved tab completion for this new option
> for both commands.
>
> Along with this also added starting parenthesis "(" auto-complete as
> multipl
Hi,
Recently the ONLY option is introduced [1] for VACUUM and ANALYZE
commands. Attach provides improved tab completion for this new option
for both commands.
Along with this also added starting parenthesis "(" auto-complete as
multiple existing commands provide it and it makes it easier to
separa
14 matches
Mail list logo
