Re: Add pgindent test to check if codebase is correctly formatted

2024-01-17 Thread Tristan Partin
On Wed Jan 17, 2024 at 3:50 AM CST, Alvaro Herrera wrote: Hmm, should this also install typedefs.list and pgindent.man? What about the tooling to reformat Perl code? Good point about pgindent.man. It would definitely be good to install alongside pgindent and pg_bsd_indent. I don't know if we

Re: Add pgindent test to check if codebase is correctly formatted

2024-01-17 Thread Alvaro Herrera
Hmm, should this also install typedefs.list and pgindent.man? What about the tooling to reformat Perl code? -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Linux transformó mi computadora, de una `máquina para hacer cosas', en un aparato realmente entretenido, so

Re: Add pgindent test to check if codebase is correctly formatted

2024-01-16 Thread Bruce Momjian
On Tue, Jan 16, 2024 at 07:32:47PM -0600, Tristan Partin wrote: > It requires changes to at least the Meson build files. pg_bsd_indent is not > marked for installation currently. There is a TODO there. pgindent has no > install_data() for instance. pg_bsd_indent seemingly gets installed > somewhere

Re: Add pgindent test to check if codebase is correctly formatted

2024-01-16 Thread Tristan Partin
On Tue Jan 16, 2024 at 7:27 PM CST, Bruce Momjian wrote: On Tue, Jan 16, 2024 at 07:22:23PM -0600, Tristan Partin wrote: > I think a good solution would be to distribute pgindent and pg_bsd_indent. > At Neon, we are trying to format our extension code using pgindent. I am > sure there are other e

Re: Add pgindent test to check if codebase is correctly formatted

2024-01-16 Thread Bruce Momjian
On Tue, Jan 16, 2024 at 07:22:23PM -0600, Tristan Partin wrote: > I think a good solution would be to distribute pgindent and pg_bsd_indent. > At Neon, we are trying to format our extension code using pgindent. I am > sure there are other extension authors out there too that format using > pgindent

Add pgindent test to check if codebase is correctly formatted

2024-01-16 Thread Tristan Partin
endforeach install_suites += test_group -- Tristan Partin Neon (https://neon.tech) From 13902328b24984ab2d18914b63c6874143715f48 Mon Sep 17 00:00:00 2001 From: Tristan Partin Date: Tue, 16 Jan 2024 19:03:42 -0600 Subject: [PATCH v1 2/2] Add pgindent test to check if codebase is correctly