Re: Add regression coverage for REVOKE ADMIN OPTION

2021-11-26 Thread Daniel Gustafsson
> On 16 Nov 2021, at 15:32, Mark Dilger wrote: > Thanks for the review! Pushed to master along with the bugfix it helped uncover, thanks! -- Daniel Gustafsson https://vmware.com/

Re: Add regression coverage for REVOKE ADMIN OPTION

2021-11-16 Thread Mark Dilger
> On Nov 16, 2021, at 6:31 AM, Daniel Gustafsson wrote: > >> On 16 Nov 2021, at 00:58, Mark Dilger wrote: > >> While working on a fix for dangling references to dropped roles in the >> pg_auth_members.grantor field, I happened to notice we entirely lack >> regression test coverage of the

Re: Add regression coverage for REVOKE ADMIN OPTION

2021-11-16 Thread Daniel Gustafsson
> On 16 Nov 2021, at 00:58, Mark Dilger wrote: > While working on a fix for dangling references to dropped roles in the > pg_auth_members.grantor field, I happened to notice we entirely lack > regression test coverage of the REVOKE ADMIN OPTION FOR form of the > RevokeRoleStmt. I am unaware

Add regression coverage for REVOKE ADMIN OPTION

2021-11-15 Thread Mark Dilger
Hackers, While working on a fix for dangling references to dropped roles in the pg_auth_members.grantor field, I happened to notice we entirely lack regression test coverage of the REVOKE ADMIN OPTION FOR form of the RevokeRoleStmt. I am unaware of any bugs in the current implementation, but