On Fri, Jun 11, 2021 at 12:27 PM Michael Paquier wrote:
>
> On Sun, May 23, 2021 at 04:24:59PM +0530, vignesh C wrote:
> > /* Complete "CREATE SUBSCRIPTION ... WITH ( " */
> > else if (HeadMatches("CREATE", "SUBSCRIPTION") && TailMatches("WITH",
> > "("))
> > - COMPLETE_
On Sun, May 23, 2021 at 04:24:59PM +0530, vignesh C wrote:
> /* Complete "CREATE SUBSCRIPTION ... WITH ( " */
> else if (HeadMatches("CREATE", "SUBSCRIPTION") && TailMatches("WITH",
> "("))
> - COMPLETE_WITH("copy_data", "connect", "create_slot", "enabled",
> -
On Wed, May 19, 2021 at 2:03 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> On Tue, May 18, 2021 at 9:21 PM Alvaro Herrera
wrote:
> >
> > On 2021-May-14, vignesh C wrote:
> >
> > > While I was reviewing one of the logical decoding features, I found
> > > Streaming and bi
On Thu, May 20, 2021 at 9:40 PM Tom Lane wrote:
>
> vignesh C writes:
> > On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera
> > wrote:
> >> I wish we didn't have to keep knowledge in the psql source on which
> >> option names are to be used for each command. If we had some function
> >> SELECT pg
vignesh C writes:
> On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera
> wrote:
>> I wish we didn't have to keep knowledge in the psql source on which
>> option names are to be used for each command. If we had some function
>> SELECT pg_completion_options('alter subscription set');
>> that returned
On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera wrote:
>
> On 2021-May-14, vignesh C wrote:
>
> > While I was reviewing one of the logical decoding features, I found
> > Streaming and binary options were missing in tab completion for the
> > alter subscription set option, the attached patch has the
On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera wrote:
>
> On 2021-May-14, vignesh C wrote:
>
> > While I was reviewing one of the logical decoding features, I found
> > Streaming and binary options were missing in tab completion for the
> > alter subscription set option, the attached patch has the
On Tue, May 18, 2021 at 9:21 PM Alvaro Herrera wrote:
>
> On 2021-May-14, vignesh C wrote:
>
> > While I was reviewing one of the logical decoding features, I found
> > Streaming and binary options were missing in tab completion for the
> > alter subscription set option, the attached patch has the
On 2021-May-14, vignesh C wrote:
> While I was reviewing one of the logical decoding features, I found
> Streaming and binary options were missing in tab completion for the
> alter subscription set option, the attached patch has the changes for
> the same.
> Thoughts?
I wish we didn't have to kee
On Sat, May 15, 2021 at 10:44 AM vignesh C wrote:
> I have added a commitfest entry at [1].
> Thanks for the comments, the attached patch has the changes for the same.
>
> [1] - https://commitfest.postgresql.org/33/3116/
Thanks Vignesh. The v3 patch looks good to me. It applies and compiles
well,
On Fri, May 14, 2021 at 7:10 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> On Fri, May 14, 2021 at 6:51 PM vignesh C wrote:
> >
> > On Fri, May 14, 2021 at 12:25 PM Bharath Rupireddy
> > wrote:
> > >
> > > On Fri, May 14, 2021 at 12:00 PM vignesh C
wrote:
> > > >
> >
On Fri, May 14, 2021 at 6:51 PM vignesh C wrote:
>
> On Fri, May 14, 2021 at 12:25 PM Bharath Rupireddy
> wrote:
> >
> > On Fri, May 14, 2021 at 12:00 PM vignesh C wrote:
> > >
> > > Hi,
> > >
> > > While I was reviewing one of the logical decoding features, I found
> > > Streaming and binary op
ought.
I did not see any rule for this, but also did not see any harm in
keeping it in alphabetical order, so changed it in the attached patch.
Regards,
Vignesh
From 0d209ae307841827aec5478a4ca3f8e3d945eef3 Mon Sep 17 00:00:00 2001
From: vignesh
Date: Fri, 14 May 2021 11:37:05 +0530
Subject: [PAT
On Fri, May 14, 2021 at 12:00 PM vignesh C wrote:
>
> Hi,
>
> While I was reviewing one of the logical decoding features, I found
> Streaming and binary options were missing in tab completion for the
> alter subscription set option, the attached patch has the changes for
> the same.
> Thoughts?
+
Sep 17 00:00:00 2001
From: vignesh
Date: Fri, 14 May 2021 11:37:05 +0530
Subject: [PATCH v1] Added missing tab completion for alter subscription set
option.
Streaming and binary options were missing in tab completion for alter
subscription set option, included it.
---
src/bin/psql/tab
15 matches
Mail list logo
