Re: Adding NetBSD and OpenBSD to Postgres CI

2025-04-08 Thread Daniel Gustafsson
> On 8 Apr 2025, at 13:40, Nazir Bilal Yavuz wrote: > This is already fixed on b2bdb972c0, attached patch just adds > $MBUILD_TARGET to the NetBSD and OpenBSD CI tasks. After review and testing, I applied this to master. -- Daniel Gustafsson

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-04-08 Thread Nazir Bilal Yavuz
Hi, meson version is upgraded 1.7.0 in NetBSD and that causes ecpg tests to fail with [1]: 'Could not open file /home/postgres/postgres/build/src/interfaces/ecpg/test/compat_informix/dec_test.c for reading' This is already fixed on b2bdb972c0, attached patch just adds $MBUILD_TARGET to the NetBS

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-03-04 Thread Andres Freund
Hi, On 2025-02-12 09:49:35 -0500, Andres Freund wrote: > I finally pushed this. One thing I noticed is that occasionally the tests fail on openbsd after exceeding the system wide number of files, not in postgres, but causing meson test to fail. I could either put an increase of kern.maxfiles in

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-03-03 Thread Thomas Munro
On Tue, Mar 4, 2025 at 11:39 AM Andres Freund wrote: > On 2025-03-04 11:35:30 +1300, Thomas Munro wrote: > > I propose to turn these on by default tomorrow, unless someone speaks > > up with reasons why we shouldn't. > I'm worried about enabling them by default eating up CI credits even > faster.

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-03-03 Thread Andres Freund
Hi, On 2025-03-04 11:35:30 +1300, Thomas Munro wrote: > On Sun, Mar 2, 2025 at 1:37 AM Thomas Munro wrote: > > On Sat, Mar 1, 2025 at 6:24 AM Nazir Bilal Yavuz wrote: > > > I think I found the problem, sd0j's fstype is not a swap. It worked like > > > that: > > > > > > $ disklabel -E sd0 > > >

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-03-03 Thread Jacob Champion
On Mon, Mar 3, 2025 at 2:36 PM Thomas Munro wrote: > One non-reason to hold off is a > one-off report[1] from Jacob about an unexplained failure of the oauth > tests on NetBSD, but I'd prefer to see it flap if it's going to so we > can collect clues and tackle it. Agreed. --Jacob

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-03-03 Thread Thomas Munro
On Sun, Mar 2, 2025 at 1:37 AM Thomas Munro wrote: > On Sat, Mar 1, 2025 at 6:24 AM Nazir Bilal Yavuz wrote: > > I think I found the problem, sd0j's fstype is not a swap. It worked like > > that: > > > > $ disklabel -E sd0 > > $ umount /usr/obj > > $ disklabel -E sd0 # prompts are: m -> j -> \n

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-03-01 Thread Thomas Munro
On Sat, Mar 1, 2025 at 6:24 AM Nazir Bilal Yavuz wrote: > I think I found the problem, sd0j's fstype is not a swap. It worked like that: > > $ disklabel -E sd0 > $ umount /usr/obj > $ disklabel -E sd0 # prompts are: m -> j -> \n -> \n -> swap -> w -> q > $ disklabel -E sd0 > $ swapon /dev/sd0j # r

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-02-28 Thread Nazir Bilal Yavuz
Hi, On Fri, 28 Feb 2025 at 19:26, Thomas Munro wrote: > > On Tue, Feb 18, 2025 at 11:33 AM Thomas Munro wrote: > > Maybe we could try this? > > > > https://man.netbsd.org/mount_tmpfs.8 > > https://man.openbsd.org/mount_tmpfs.8 > > NetBSD's test_world: 10:30 -> 3:23 > OpenBSD test_world: 15:45 -

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-02-28 Thread Thomas Munro
On Tue, Feb 18, 2025 at 11:33 AM Thomas Munro wrote: > Maybe we could try this? > > https://man.netbsd.org/mount_tmpfs.8 > https://man.openbsd.org/mount_tmpfs.8 NetBSD's test_world: 10:30 -> 3:23 OpenBSD test_world: 15:45 - >9:10 I think NetBSD would finish around 2nd place if turned on by defau

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-02-17 Thread Thomas Munro
On Fri, Feb 14, 2025 at 2:02 AM Nazir Bilal Yavuz wrote: > On Wed, 12 Feb 2025 at 17:49, Andres Freund wrote: > > Obviously not your fault, but I do think it's pretty crazy that with the > > same > > available resources, netbsd and openbsd take considerably longer than linux > > and freebsd, whi

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-02-13 Thread Nazir Bilal Yavuz
Hi, On Wed, 12 Feb 2025 at 17:49, Andres Freund wrote: > I finally pushed this. The meson fix backpatched to 16. > > I did some very minor polishing, reordering the OS lists to stay alphabetical, > instead of adding netbsd/openbsd somewhere to the front of lists. Thanks! > Obviously not your fa

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-02-12 Thread Andres Freund
Hi, I finally pushed this. The meson fix backpatched to 16. I did some very minor polishing, reordering the OS lists to stay alphabetical, instead of adding netbsd/openbsd somewhere to the front of lists. Thanks for the patches! Obviously not your fault, but I do think it's pretty crazy that w

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-01-08 Thread Nazir Bilal Yavuz
Hi, Thanks for the review! On Tue, 17 Dec 2024 at 19:21, Andres Freund wrote: > > Hi, > > On 2024-11-12 11:38:11 +0300, Nazir Bilal Yavuz wrote: > > On Fri, 1 Nov 2024 at 21:44, Andres Freund wrote: > > > > +CCACHE_DIR: /tmp/ccache_dir > > > > + > > > > +PATH: /usr/sbin:$PATH > > > > +

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-12-17 Thread Tom Lane
I wrote: > Andres Freund writes: >> It'd be helpful if the error message ought to at least include the category >> being tested, perhaps it's just one category failing or such? > Yeah, I will poke into this a little harder to see what's going on. So after a little testing, setlocale(LC_COLLATE,

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-12-17 Thread Tom Lane
Andres Freund writes: > On 2024-12-17 12:44:46 -0500, Tom Lane wrote: >> On mamba's host (pretty vanilla NetBSD 10.0): >> initdb: error: invalid locale settings; check LANG and LC_* environment >> variables > It'd be helpful if the error message ought to at least include the category > being tes

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-12-17 Thread Andres Freund
Hi, On 2024-12-17 14:25:01 -0500, Andres Freund wrote: > On 2024-12-17 13:09:49 -0500, Tom Lane wrote: > > I wrote: > > > Andres Freund writes: > > >> Was about to apply that, but then started to wonder if we don't need the > > >> same > > >> for configure? And it sure looks like that has the sa

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-12-17 Thread Andres Freund
Hi, On 2024-12-17 13:09:49 -0500, Tom Lane wrote: > I wrote: > > Andres Freund writes: > >> Was about to apply that, but then started to wonder if we don't need the > >> same > >> for configure? And it sure looks like that has the same problem? > >> Which also confuses me some, at some point thi

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-12-17 Thread Andres Freund
Hi, On 2024-12-17 12:44:46 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2024-11-12 11:38:11 +0300, Nazir Bilal Yavuz wrote: > >> It was because initdb was failing on NetBSD when the LANG and LC_ALL > >> is not set to C. I rephrased the comment and moved this under NetBSD > >> task. > >

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-12-17 Thread Tom Lane
I wrote: > Andres Freund writes: >> Was about to apply that, but then started to wonder if we don't need the same >> for configure? And it sure looks like that has the same problem? >> Which also confuses me some, at some point this presumably worked? > The configure path does work on NetBSD 10,

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-12-17 Thread Tom Lane
Andres Freund writes: > On 2024-11-12 11:38:11 +0300, Nazir Bilal Yavuz wrote: >> It was because initdb was failing on NetBSD when the LANG and LC_ALL >> is not set to C. I rephrased the comment and moved this under NetBSD >> task. > Do you happen to have a reference to the failure? The environm

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-12-17 Thread Andres Freund
Hi, Missed something until just after I hit send: On 2024-11-12 11:38:11 +0300, Nazir Bilal Yavuz wrote: > + matrix: > +- name: NetBSD - 10 - Meson > + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || > $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*netbsd.*' ... > +- na

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-12-17 Thread Andres Freund
Hi, On 2024-11-12 11:38:11 +0300, Nazir Bilal Yavuz wrote: > On Fri, 1 Nov 2024 at 21:44, Andres Freund wrote: > > > +CCACHE_DIR: /tmp/ccache_dir > > > + > > > +PATH: /usr/sbin:$PATH > > > + > > > +# Postgres interprets LANG as a 'en_US.UTF-8' but it is 'C', then > > > > What does "Po

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-11-12 Thread Nazir Bilal Yavuz
Hi, On Fri, 1 Nov 2024 at 21:44, Andres Freund wrote: > > Hi, > > Thanks for the patch! > > > On 2024-11-01 12:17:00 +0300, Nazir Bilal Yavuz wrote: > > I made these tasks triggered manually like MinGW task to save CI credits > > but a related line is commented out for now to trigger CFBot. > > O

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-11-07 Thread Andres Freund
Hi, On 2024-11-07 16:05:43 +0100, Peter Eisentraut wrote: > On 07.11.24 14:40, Nazir Bilal Yavuz wrote: > > > I noticed that neither the existing FreeBSD task nor the new OpenBSD one > > > find the bsd_auth.h header. I thought this would be good to get more > > > testing of that code. Do you kno

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-11-07 Thread Nazir Bilal Yavuz
Hi, Thanks for the feedback! On Fri, 1 Nov 2024 at 14:16, Peter Eisentraut wrote: > > On 01.11.24 10:17, Nazir Bilal Yavuz wrote: > > NetBSD and OpenBSD Postgres CI images are generated [1] but their tasks > > are not added to the upstream Postgres yet. The attached patch adds > > NetBSD and Ope

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-11-07 Thread Daniel Gustafsson
> On 1 Nov 2024, at 12:16, Peter Eisentraut wrote: > > On 01.11.24 10:17, Nazir Bilal Yavuz wrote: >> NetBSD and OpenBSD Postgres CI images are generated [1] but their tasks are >> not added to the upstream Postgres yet. The attached patch adds NetBSD and >> OpenBSD tasks to the Postgres CI. >>

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-11-01 Thread Andres Freund
Hi, Thanks for the patch! On 2024-11-01 12:17:00 +0300, Nazir Bilal Yavuz wrote: > I made these tasks triggered manually like MinGW task to save CI credits > but a related line is commented out for now to trigger CFBot. Oh, I need to pick my patch which allows repo-level config of which tasks r

Re: Adding NetBSD and OpenBSD to Postgres CI

2024-11-01 Thread Peter Eisentraut
On 01.11.24 10:17, Nazir Bilal Yavuz wrote: NetBSD and OpenBSD Postgres CI images are generated [1] but their tasks are not added to the upstream Postgres yet. The attached patch adds NetBSD and OpenBSD tasks to the Postgres CI. I made these tasks triggered manually like MinGW task to save CI

Adding NetBSD and OpenBSD to Postgres CI

2024-11-01 Thread Nazir Bilal Yavuz
Hi, NetBSD and OpenBSD Postgres CI images are generated [1] but their tasks are not added to the upstream Postgres yet. The attached patch adds NetBSD and OpenBSD tasks to the Postgres CI. I made these tasks triggered manually like MinGW task to save CI credits but a related line is commented out