Re: Adding comments to help understand psql hidden queries

2025-03-31 Thread Maiquel Grassi
Hi! I have read the discussion and would like to share my humble opinion. I believe that a visually appealing way to display the output on the screen is to ensure symmetry in the length of asterisks and description lines. I imagine someone looking at the screen and focusing on symmetrical details.

Re: Adding comments to help understand psql hidden queries

2025-03-31 Thread Maiquel Grassi
Hi! I have read the discussion and would like to share my humble opinion. I believe that a visually appealing way to display the output on the screen is to ensure symmetry in the length of asterisks and description lines. I imagine someone looking at the screen and focusing on symmetrical details.

Re: Adding comments to help understand psql hidden queries

2025-01-30 Thread David Christensen
On Sat, Jan 18, 2025 at 2:37 PM Tom Lane wrote: > > David Christensen writes: > > Any further concerns/issues with this patch that I can address to help > > move it forward? > > I got around to looking at this finally --- sorry that it's been on > the back burner for so long. I think this is bas

Re: Adding comments to help understand psql hidden queries

2025-01-18 Thread Tom Lane
David Christensen writes: > Any further concerns/issues with this patch that I can address to help > move it forward? I got around to looking at this finally --- sorry that it's been on the back burner for so long. I think this is basically a good idea but it still requires a lot of sanding-down

Re: Adding comments to help understand psql hidden queries

2024-06-11 Thread David Christensen
On Thu, Apr 4, 2024 at 11:12 AM David Christensen wrote: > > On Thu, Apr 4, 2024 at 9:32 AM Peter Eisentraut wrote: > > > > On 03.04.24 19:16, David Christensen wrote: > > > I removed _() in the output of the query/stars since there'd be no > > > sensible existing translations for the constructed

Re: Adding comments to help understand psql hidden queries

2024-04-04 Thread David Christensen
On Thu, Apr 4, 2024 at 9:32 AM Peter Eisentraut wrote: > > On 03.04.24 19:16, David Christensen wrote: > > I removed _() in the output of the query/stars since there'd be no > > sensible existing translations for the constructed string, which > > included the query string itself. If we need it fo

Re: Adding comments to help understand psql hidden queries

2024-04-04 Thread Peter Eisentraut
On 03.04.24 19:16, David Christensen wrote: I removed _() in the output of the query/stars since there'd be no sensible existing translations for the constructed string, which included the query string itself. If we need it for the "QUERY" string, this could be added fairly easily, but the exist

Re: Adding comments to help understand psql hidden queries

2024-04-03 Thread David Christensen
I got Greg's blessing on squashing the commits down, and now including a v4 with additional improvements on the output formatting front. Main changes: - all generated comments are the same width - width has been bumped to 80 - removed _() functions for consumers of the new output functions This p

Re: Adding comments to help understand psql hidden queries

2024-03-22 Thread Greg Sabino Mullane
On Fri, Mar 22, 2024 at 11:39 AM David Christensen wrote: > I think it's easier to keep the widths balanced than constant (patch > version included here) Yeah, I'm fine with that, especially because nobody is translating it, nor are they likely to, to be honest. Cheers, Greg

Re: Adding comments to help understand psql hidden queries

2024-03-22 Thread David Christensen
On Fri, Mar 22, 2024 at 9:47 AM Greg Sabino Mullane wrote: > > On Thu, Mar 21, 2024 at 6:20 PM Peter Eisentraut wrote: >> >> lines are supposed to align vertically. With your patch, the first line >> would have variable length depending on the command. > > > Yes, that is a good point. Aligning t

Re: Adding comments to help understand psql hidden queries

2024-03-22 Thread Greg Sabino Mullane
On Thu, Mar 21, 2024 at 6:20 PM Peter Eisentraut wrote: > lines are supposed to align vertically. With your patch, the first line > would have variable length depending on the command. > Yes, that is a good point. Aligning those would be quite tricky, what if we just kept a standard width for t

Re: Adding comments to help understand psql hidden queries

2024-03-21 Thread Peter Eisentraut
On 21.03.24 18:31, David Christensen wrote: Thanks for the feedback. Enclosed is a v2 of this series(?) rebased and with that warning fixed; @Greg Sabino Mullane I just created a commit on your behalf with the message to hackers. I'm also creating a commit-fest entry for this thread. I don't

Re: Adding comments to help understand psql hidden queries

2024-03-21 Thread David Christensen
Created the CF entry in commitfest 48 but didn't see it was already in 47; closing the CFEntry in 48. (Doesn't appear to be a different status than "Withdrawn"...)

Re: Adding comments to help understand psql hidden queries

2024-03-21 Thread David Christensen
Hi Jim, Thanks for the feedback. Enclosed is a v2 of this series(?) rebased and with that warning fixed; @Greg Sabino Mullane I just created a commit on your behalf with the message to hackers. I'm also creating a commit-fest entry for this thread. Best, David v2-0002-Add-output-of-the-comma

Re: Adding comments to help understand psql hidden queries

2024-03-15 Thread Jim Jones
Hi Greg, hi David On 01.02.24 23:39, David Christensen wrote: > On Thu, Feb 1, 2024 at 4:34 PM Greg Sabino Mullane wrote: >> The use of the --echo-hidden flag in psql is used to show people the way >> psql performs its magic for its backslash commands. None of them has more >> magic than "\d re

Re: Adding comments to help understand psql hidden queries

2024-02-01 Thread David Christensen
On Thu, Feb 1, 2024 at 4:34 PM Greg Sabino Mullane wrote: > > The use of the --echo-hidden flag in psql is used to show people the way psql > performs its magic for its backslash commands. None of them has more magic > than "\d relation", but it suffers from needing a lot of separate queries to

Adding comments to help understand psql hidden queries

2023-12-11 Thread Greg Sabino Mullane
The use of the --echo-hidden flag in psql is used to show people the way psql performs its magic for its backslash commands. None of them has more magic than "\d relation", but it suffers from needing a lot of separate queries to gather all of the information it needs. Unfortunately, those queries