Re: Adding tests for inheritance trees with temporary tables

2018-07-01 Thread Michael Paquier
On Thu, Jun 21, 2018 at 02:37:46PM +0900, Michael Paquier wrote: > On Wed, Jun 20, 2018 at 06:34:42PM +0530, Ashutosh Bapat wrote: > > Thanks. I have checked that make check passes with this patch. I have > > marked this entry as ready for committer. > > Thanks, Ashutosh. Now pushed. Thanks Ashu

Re: Adding tests for inheritance trees with temporary tables

2018-06-20 Thread Michael Paquier
On Wed, Jun 20, 2018 at 06:34:42PM +0530, Ashutosh Bapat wrote: > Thanks. I have checked that make check passes with this patch. I have > marked this entry as ready for committer. Thanks, Ashutosh. -- Michael signature.asc Description: PGP signature

Re: Adding tests for inheritance trees with temporary tables

2018-06-20 Thread Ashutosh Bapat
On Wed, Jun 20, 2018 at 11:39 AM, Michael Paquier wrote: > > Good point, I have added those. Except that you meant > tableoid::regclass. Thanks. I have checked that make check passes with this patch. I have marked this entry as ready for committer. -- Best Wishes, Ashutosh Bapat EnterpriseDB

Re: Adding tests for inheritance trees with temporary tables

2018-06-19 Thread Michael Paquier
On Tue, Jun 19, 2018 at 01:04:43PM +0530, Ashutosh Bapat wrote: > Thanks. Some review comments here. Thanks for the review! > +create table inh_perm_parent (a1 int); > +create temp table inh_temp_parent (a1 int); > +create temp table inh_temp_child (a1 int) inherits (inh_perm_parent); -- ok > +N

Re: Adding tests for inheritance trees with temporary tables

2018-06-19 Thread Ashutosh Bapat
Thanks. Some review comments here. +create table inh_perm_parent (a1 int); +create temp table inh_temp_parent (a1 int); +create temp table inh_temp_child (a1 int) inherits (inh_perm_parent); -- ok +NOTICE: merging column "a1" with inherited definition You could actually avoid this notice by chan

Adding tests for inheritance trees with temporary tables

2018-06-18 Thread Michael Paquier
Hi all, While look at the handling of temporary relations with partition trees, I have noticed that there are no tests for inheritance trees with temp tables. This has been mentioned here: https://www.postgresql.org/message-id/20180618060200.gg3...@paquier.xyz Attached is a patch to close the ga