Re: Adjust pg_regress output for new long test names

2021-06-10 Thread Noah Misch
On Wed, Jun 09, 2021 at 09:31:24AM -0400, Alvaro Herrera wrote: > On 2021-Jun-08, Noah Misch wrote: > > > On Wed, Jun 9, 2021 at 2:51 PM Noah Misch wrote: > > > > Not bad, but I would instead shorten the names to detach-[1234] or > > > > detach-partition-[1234]. The marginal value of the second

Re: Adjust pg_regress output for new long test names

2021-06-09 Thread Robert Haas
On Wed, Jun 9, 2021 at 1:37 PM Peter Eisentraut wrote: > Can we scan all the test names first and then pick a suitable length? FWIW, I think this discussion of shortening the test case names is probably going in the wrong direction. It's true that in many cases such a thing can be done, but it's

Re: Adjust pg_regress output for new long test names

2021-06-09 Thread Peter Eisentraut
On 09.06.21 03:57, Thomas Munro wrote: test deadlock-simple ... ok 20 ms test deadlock-hard... ok10624 ms test deadlock-soft... ok 147 ms test deadlock-soft-2 ... ok 5154 ms test deadlock-parallel

Re: Adjust pg_regress output for new long test names

2021-06-09 Thread Peter Eisentraut
On 09.06.21 04:51, Noah Misch wrote: On Wed, Jun 09, 2021 at 01:57:45PM +1200, Thomas Munro wrote: test deadlock-simple ... ok 20 ms test deadlock-hard... ok10624 ms test deadlock-soft... ok 147 ms test deadlock-soft-2

Re: Adjust pg_regress output for new long test names

2021-06-09 Thread Alvaro Herrera
On 2021-Jun-08, Noah Misch wrote: > On Wed, Jun 09, 2021 at 03:21:36PM +1200, Thomas Munro wrote: > > On Wed, Jun 9, 2021 at 2:44 PM Tom Lane wrote: > > > ... or we could shorten those file names. I recall an episode > > > awhile ago where somebody complained that their version of "tar" > > >

Re: Adjust pg_regress output for new long test names

2021-06-08 Thread Noah Misch
On Wed, Jun 09, 2021 at 03:21:36PM +1200, Thomas Munro wrote: > On Wed, Jun 9, 2021 at 2:44 PM Tom Lane wrote: > > ... or we could shorten those file names. I recall an episode > > awhile ago where somebody complained that their version of "tar" > > couldn't handle some of the path names in our

Re: Adjust pg_regress output for new long test names

2021-06-08 Thread Thomas Munro
[Responding to two emails in one] On Wed, Jun 9, 2021 at 2:44 PM Tom Lane wrote: > ... or we could shorten those file names. I recall an episode > awhile ago where somebody complained that their version of "tar" > couldn't handle some of the path names in our tarball, so > keeping things from

Re: Adjust pg_regress output for new long test names

2021-06-08 Thread Noah Misch
On Wed, Jun 09, 2021 at 01:57:45PM +1200, Thomas Munro wrote: > test deadlock-simple ... ok 20 ms > test deadlock-hard... ok10624 ms > test deadlock-soft... ok 147 ms > test deadlock-soft-2 ... ok 5154 ms

Re: Adjust pg_regress output for new long test names

2021-06-08 Thread Tom Lane
Thomas Munro writes: > test detach-partition-concurrently-1 ... ok 553 ms > test detach-partition-concurrently-2 ... ok 234 ms > test detach-partition-concurrently-3 ... ok 2389 ms > test detach-partition-concurrently-4 ... ok 1876 ms > Any objections to making

Re: Adjust pg_regress output for new long test names

2021-06-08 Thread Michael Paquier
On Wed, Jun 09, 2021 at 10:17:35AM +0800, Julien Rouhaud wrote: > On Wed, Jun 09, 2021 at 01:57:45PM +1200, Thomas Munro wrote: >> Any objections to making these new tests line up with the rest? > > No objection, as the output is still way under 80 characters. +1. -- Michael signature.asc

Re: Adjust pg_regress output for new long test names

2021-06-08 Thread Julien Rouhaud
On Wed, Jun 09, 2021 at 01:57:45PM +1200, Thomas Munro wrote: > Hi, > > test deadlock-simple ... ok 20 ms > test deadlock-hard... ok10624 ms > test deadlock-soft... ok 147 ms > test deadlock-soft-2 ... ok

Adjust pg_regress output for new long test names

2021-06-08 Thread Thomas Munro
Hi, test deadlock-simple ... ok 20 ms test deadlock-hard... ok10624 ms test deadlock-soft... ok 147 ms test deadlock-soft-2 ... ok 5154 ms test deadlock-parallel... ok 132 ms test