Re: Allow parallel plan for referential integrity checks?

2024-02-01 Thread vignesh C
On Sun, 21 Jan 2024 at 07:56, vignesh C wrote: > > On Fri, 18 Aug 2023 at 16:29, Juan José Santamaría Flecha > wrote: > > > > > > On Thu, Aug 17, 2023 at 3:51 PM Frédéric Yhuel > > wrote: > >> > >> On 8/17/23 14:00, Frédéric Yhuel wrote: > >> > On 8/17/23 09:32, Frédéric Yhuel wrote: > >> >> On

Re: Allow parallel plan for referential integrity checks?

2024-01-20 Thread vignesh C
On Fri, 18 Aug 2023 at 16:29, Juan José Santamaría Flecha wrote: > > > On Thu, Aug 17, 2023 at 3:51 PM Frédéric Yhuel > wrote: >> >> On 8/17/23 14:00, Frédéric Yhuel wrote: >> > On 8/17/23 09:32, Frédéric Yhuel wrote: >> >> On 8/10/23 17:06, Juan José Santamaría Flecha wrote: >> >>> Recently I r

Re: Allow parallel plan for referential integrity checks?

2023-08-18 Thread Juan José Santamaría Flecha
On Thu, Aug 17, 2023 at 3:51 PM Frédéric Yhuel wrote: > On 8/17/23 14:00, Frédéric Yhuel wrote: > > On 8/17/23 09:32, Frédéric Yhuel wrote: > >> On 8/10/23 17:06, Juan José Santamaría Flecha wrote: > >>> Recently I restored a database from a directory format backup and > >>> having this feature w

Re: Allow parallel plan for referential integrity checks?

2023-08-17 Thread Frédéric Yhuel
On 8/17/23 14:00, Frédéric Yhuel wrote: On 8/17/23 09:32, Frédéric Yhuel wrote: On 8/10/23 17:06, Juan José Santamaría Flecha wrote: Recently I restored a database from a directory format backup and having this feature would have been quite useful Hi, Thanks for resuming work on this

Re: Allow parallel plan for referential integrity checks?

2023-08-17 Thread Frédéric Yhuel
On 8/17/23 09:32, Frédéric Yhuel wrote: On 8/10/23 17:06, Juan José Santamaría Flecha wrote: Recently I restored a database from a directory format backup and having this feature would have been quite useful Hi, Thanks for resuming work on this patch. I forgot to mention this in my origi

Re: Allow parallel plan for referential integrity checks?

2023-08-17 Thread Frédéric Yhuel
On 8/10/23 17:06, Juan José Santamaría Flecha wrote: Recently I restored a database from a directory format backup and having this feature would have been quite useful Hi, Thanks for resuming work on this patch. I forgot to mention this in my original email, but the motivation was also to

Re: Allow parallel plan for referential integrity checks?

2023-08-16 Thread Juan José Santamaría Flecha
On Thu, Aug 10, 2023 at 5:06 PM Juan José Santamaría Flecha < juanjo.santama...@gmail.com> wrote: > On Tue, Jul 4, 2023 at 9:45 AM Daniel Gustafsson wrote: > >> As there is no new patch submitted I will go ahead and do that, please >> feel >> free to resubmit when there is renewed interest in wor

Re: Allow parallel plan for referential integrity checks?

2023-08-10 Thread Juan José Santamaría Flecha
On Tue, Jul 4, 2023 at 9:45 AM Daniel Gustafsson wrote: > > As there is no new patch submitted I will go ahead and do that, please feel > free to resubmit when there is renewed interest in working on this. > > Recently I restored a database from a directory format backup and having this feature w

Re: Allow parallel plan for referential integrity checks?

2023-07-04 Thread Daniel Gustafsson
> On 20 Mar 2023, at 16:48, Frédéric Yhuel wrote: > On 3/20/23 15:58, Gregory Stark (as CFM) wrote: >> Should we move it to next release at this >> point? Even if you get time to work on it this commitfest do you think >> it's likely to be committable in the next few weeks? > > It is very unlike

Re: Allow parallel plan for referential integrity checks?

2023-03-20 Thread Frédéric Yhuel
On 3/20/23 15:58, Gregory Stark (as CFM) wrote: On Mon, 12 Dec 2022 at 11:37, Frédéric Yhuel wrote: I've planned to work on it full time on week 10 (6-10 March), if you agree to bear with me. The idea would be to bootstrap my brain on it, and then continue to work on it from time to time.

Re: Allow parallel plan for referential integrity checks?

2023-03-20 Thread Gregory Stark (as CFM)
On Mon, 12 Dec 2022 at 11:37, Frédéric Yhuel wrote: > > I've planned to work on it full time on week 10 (6-10 March), if you > agree to bear with me. The idea would be to bootstrap my brain on it, > and then continue to work on it from time to time. Any updates on this patch? Should we move it to

Re: Allow parallel plan for referential integrity checks?

2023-01-16 Thread vignesh C
On Mon, 12 Dec 2022 at 22:06, Frédéric Yhuel wrote: > > > > On 12/11/22 06:29, Ian Lawrence Barwick wrote: > > 2022年7月26日(火) 20:58 Frédéric Yhuel : > >> > >> > >> > >> On 4/14/22 14:25, Frédéric Yhuel wrote: > >>> > >>> > >>> On 3/19/22 01:57, Imseih (AWS), Sami wrote: > I looked at your patc

Re: Allow parallel plan for referential integrity checks?

2022-12-12 Thread Frédéric Yhuel
On 12/11/22 06:29, Ian Lawrence Barwick wrote: 2022年7月26日(火) 20:58 Frédéric Yhuel : On 4/14/22 14:25, Frédéric Yhuel wrote: On 3/19/22 01:57, Imseih (AWS), Sami wrote: I looked at your patch and it's a good idea to make foreign key validation use parallel query on large relations. It

Re: Allow parallel plan for referential integrity checks?

2022-12-10 Thread Ian Lawrence Barwick
2022年7月26日(火) 20:58 Frédéric Yhuel : > > > > On 4/14/22 14:25, Frédéric Yhuel wrote: > > > > > > On 3/19/22 01:57, Imseih (AWS), Sami wrote: > >> I looked at your patch and it's a good idea to make foreign key > >> validation > >> use parallel query on large relations. > >> > >> It would be valuabl

Re: Allow parallel plan for referential integrity checks?

2022-07-26 Thread Frédéric Yhuel
On 4/14/22 14:25, Frédéric Yhuel wrote: On 3/19/22 01:57, Imseih (AWS), Sami wrote: I looked at your patch and it's a good idea to make foreign key validation use parallel query on large relations. It would be valuable to add logging to ensure that the ActiveSnapshot and TransactionSnaps

Re: Allow parallel plan for referential integrity checks?

2022-04-14 Thread Frédéric Yhuel
On 3/19/22 01:57, Imseih (AWS), Sami wrote: I looked at your patch and it's a good idea to make foreign key validation use parallel query on large relations. It would be valuable to add logging to ensure that the ActiveSnapshot and TransactionSnapshot is the same for the leader and the worke

Re: Allow parallel plan for referential integrity checks?

2022-03-18 Thread Imseih (AWS), Sami
I looked at your patch and it's a good idea to make foreign key validation use parallel query on large relations. It would be valuable to add logging to ensure that the ActiveSnapshot and TransactionSnapshot is the same for the leader and the workers. This logging could be tested in the TAP tes

Re: Allow parallel plan for referential integrity checks?

2022-03-03 Thread Frédéric Yhuel
Hello, sorry for the late reply. On 2/14/22 15:33, Robert Haas wrote: On Mon, Feb 7, 2022 at 5:26 AM Frédéric Yhuel wrote: I noticed that referential integrity checks aren't currently parallelized. Is it on purpose? It's not 100% clear to me that it is safe. But on the other hand, it's also

Re: Allow parallel plan for referential integrity checks?

2022-02-14 Thread Robert Haas
On Mon, Feb 7, 2022 at 5:26 AM Frédéric Yhuel wrote: > I noticed that referential integrity checks aren't currently > parallelized. Is it on purpose? It's not 100% clear to me that it is safe. But on the other hand, it's also not 100% clear to me that it is unsafe. Generally, I only added CURSOR

Re: Allow parallel plan for referential integrity checks?

2022-02-14 Thread Frédéric Yhuel
On 2/11/22 00:16, Andreas Karlsson wrote: On 2/7/22 11:26, Frédéric Yhuel wrote: Attached is a (naive) patch that aims to fix the case of a FK addition, but the handling of the flag CURSOR_OPT_PARALLEL_OK, generally speaking, looks rather hackish. Thanks, for the patch. You can add it to t

Re: Allow parallel plan for referential integrity checks?

2022-02-10 Thread Andreas Karlsson
On 2/7/22 11:26, Frédéric Yhuel wrote: Attached is a (naive) patch that aims to fix the case of a FK addition, but the handling of the flag CURSOR_OPT_PARALLEL_OK, generally speaking, looks rather hackish. Thanks, for the patch. You can add it to the current open commitfest (https://commitfes

Allow parallel plan for referential integrity checks?

2022-02-07 Thread Frédéric Yhuel
.postgresql.org/docs/current/when-can-parallel-query-be-used.htmlFrom 1353a4b7e7d08b13cbaa85a5f9ae26819b5cf2c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Yhuel?= Date: Sun, 6 Feb 2022 13:31:55 +0100 Subject: [PATCH] Allow parallel plan for referential integrity checks --- s