Re: Alter table documentation page (again)

2018-12-27 Thread Alvaro Herrera
On 2018-Dec-28, Michael Paquier wrote: > On Wed, Dec 26, 2018 at 01:46:48PM +0900, Michael Paquier wrote: > > What's proposed here looks good to me, and all the grounds are > > covered, so I am switching the patch as ready for committer. > > And committed, mentioning on the way Brigitte for the r

Re: Alter table documentation page (again)

2018-12-27 Thread Michael Paquier
On Wed, Dec 26, 2018 at 01:46:48PM +0900, Michael Paquier wrote: > What's proposed here looks good to me, and all the grounds are > covered, so I am switching the patch as ready for committer. And committed, mentioning on the way Brigitte for the report. -- Michael signature.asc Description: PGP

Re: Alter table documentation page (again)

2018-12-25 Thread Michael Paquier
On Fri, Dec 07, 2018 at 07:48:39PM +0100, Lætitia Avrot wrote: > Here's the patch. > The patch should apply to MASTER. I built and tested it successfully on my > laptop. > > I'll add it to January's commitfest. What's proposed here looks good to me, and all the grounds are covered, so I am switch

Re: Alter table documentation page (again)

2018-12-07 Thread Lætitia Avrot
Hi all, Here's the patch. The patch should apply to MASTER. I built and tested it successfully on my laptop. I'll add it to January's commitfest. Cheers, Lætitia diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml index be1647937d..c49a20fb93 100644 --- a/doc/src/

Re: Alter table documentation page (again)

2018-12-06 Thread Alvaro Herrera
On 2018-Dec-06, Lætitia Avrot wrote: > > I'd rename the action in ON DELETE/UPDATE to referential_action, both in > > alter_table and in create_table (the latter just for consistency). > > I love that "option 3" ! So clever! Thanks :-) I checked the SQL standard after sending that email, and i

Re: Alter table documentation page (again)

2018-12-06 Thread Lætitia Avrot
> > > I'd rename the action in ON DELETE/UPDATE to referential_action, both in > alter_table and in create_table (the latter just for consistency). > I love that "option 3" ! So clever!

Re: Alter table documentation page (again)

2018-12-06 Thread Alvaro Herrera
On 2018-Dec-06, Lætitia Avrot wrote: > Any thought ? Which option do you prefer ? I can write the patch, but I'd > like to know what you think about that. I'd rename the action in ON DELETE/UPDATE to referential_action, both in alter_table and in create_table (the latter just for consistency). -

Alter table documentation page (again)

2018-12-06 Thread Lætitia Avrot
Hi, I was trying to answer a former colleague question about postgres' default behaviour when deleting or updating when she pointed out that Postgres alter table documentation page used twice the 'action' keywords for two different things. And indeed she is right : - it's used to described any ac